ros / resource_retriever Goto Github PK

Complains about retriever.h:81

defaulted and deleted functions only available with -std=c++11 or -std=gnu++11

• http://build.ros.org/view/Kdev/job/Kdev__resource_retriever__ubuntu_xenial_amd64/2/warnings17Result/

Downstream packages have the same warning:

• http://build.ros.org/view/Kdev/job/Kdev__robot_model__ubuntu_xenial_amd64/6/warnings17Result/

The deprecate header: retriever.h is in galaxy but missing from foxy branch.

https://github.com/ros/resource_retriever/pull/51

Hello,
I've been struggling to build this package on ROS2 Eloquent on Windows 10.

All other packages (except those dependent on this) build fine, and running the command:
colcon build --merge-install --packages-select resource_retriever --event-handler console_cohesion+

Outputs

Starting >>> resource_retriever
--- output: resource_retriever
[6.968s] -- Found ament_cmake_ros: 0.8.0
(C:/dev/ros2_eloquent/install/share/ament_cmake_ros/cmake)
[7.375s] -- Using PYTHON_EXECUTABLE: C:/Python37/python.exe
[8.640s] -- Found ament_index_cpp: 0.7.2` `(C:/dev/ros2_eloquent/install/share/ament_index_cpp/cmake)
[8.703s] -- Found libcurl_vendor: 2.2.1` `(C:/dev/ros2_eloquent/install/share/libcurl_vendor/cmake)
[8.796s] -- library:
C:/dev/ros2_eloquent/install/opt/libcurl_vendor/bin/libcurl.dll
[9.234s] -- Configuring done
[9.828s] -- Generating done
[9.875s] -- Build files have been written to:` `C:/dev/ros2_eloquent/build/resource_retriever
[10.234s] Microsoft (R) Build Engine version 16.5.0+d4cbfca49 for .NET Framework
[10.234s] Copyright (C) Microsoft Corporation. All rights reserved.
[10.234s]
[11.125s]` `C:\dev\ros2_eloquent\install\opt\libcurl_vendor\bin\libcurl.dll : fatal error LNK1107: invalid or corrupt file: cannot read at 0x310` `[C:\dev\ros2_eloquent\build\resource_retriever\resource_retriever.vcxproj]
---
Failed   <<< resource_retriever [ Exited with code 1 ]
 
Summary: 0 packages finished [12.6s]
1 package failed: resource_retriever

I've been looking at it and found that the source might come from
# TODO(wjwwood): remove libcurl_vendor and just use system curl when possible
find_package(libcurl_vendor REQUIRED)

In the CMakeLists.txt file, but I have no idea how to start and solve it.

Hi,

I receive the following warning when compiling ros2 as well as other code using the libcurl_vendor library.

/usr/bin/cmake: /home/alexis/kobi/ros2_thirdparty/install/opt/libcurl_vendor/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)

I tried both the foxy branch as well as ros2 branch:

Foxy branch:

libcurl_vendor$ git log
commit f20037d20a3a69c4f580a1f127b528884c3575ac (grafted, HEAD -> foxy, tag: 2.3.4, origin/foxy)

Ros2 branch:

libcurl_vendor$ git log
commit 791becb15061bfb064512a17ddbd341eeb14cef7 (grafted, HEAD -> ros2, tag: 2.5.0, origin/ros2)

CMake version:

$ cmake --version 
cmake version 3.10.2

Would this be due to an "old cmake version"?

I'm building resource_retriever for arm64 in a docker build stage, the image has curl and other libs that are needed but i get the following error message from colcon

--- stderr: resource_retriever
CMake Warning (dev) at /usr/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (PkgConfig)
  does not match the name of the calling package (libcurl_vendor).  This can
  lead to problems in calling code that expects `find_package` result
  variables (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  /usr/share/cmake-3.22/Modules/FindPkgConfig.cmake:99 (find_package_handle_standard_args)
  /opt/ros/foxy/install/share/libcurl_vendor/cmake/libcurl_vendor-extras.cmake:21 (include)
  /opt/ros/foxy/install/share/libcurl_vendor/cmake/libcurl_vendorConfig.cmake:41 (include)
  CMakeLists.txt:16 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
library_abs
    linked by target "resource_retriever" in directory /opt/ros/foxy/src/resource_retriever/resource_retriever

CMake Generate step failed.  Build files cannot be regenerated correctly.
---
Failed   <<< resource_retriever [1min 1s, exited with code 1]

I have cmake 3.22.1 and curl 7.58.0 installed. I made a simple CMake project to test and it did not work to use libcurl_vendor to find_package, however using CURL worked.

Any ideas for, I could do a fork and change to CURL but then i can't use rosinstall stuff.

Bug report

Required Info:

• Operating System:
  • Windows 10
• Installation type:
  • source
• Version or commit hash:
  • bf9bd0d (ros2 branch)

Steps to reproduce issue

Follow ROS2 Windows build instructions.

Expected behavior

Build succeeded

Actual behavior

Error while building resource_retriever

Additional information

Starting >>> resource_retriever
-- Selecting Windows SDK version 10.0.18362.0 to target Windows 10.0.19043.
-- The C compiler identification is MSVC 19.29.30037.0
-- The CXX compiler identification is MSVC 19.29.30037.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30037/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30037/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found ament_cmake_ros: 0.10.0 (C:/dev/ros2_rolling/install/share/ament_cmake_ros/cmake)
-- Found Python3: C:/Python38/python.exe (found version "3.8.3") found components: Interpreter
-- Found ament_index_cpp: 1.4.0 (C:/dev/ros2_rolling/install/share/ament_index_cpp/cmake)
-- Found libcurl_vendor: 3.1.0 (C:/dev/ros2_rolling/install/share/libcurl_vendor/cmake)
-- Setting curl_DIR to: 'C:/dev/ros2_rolling/install/share/libcurl_vendor/cmake/../../../opt/libcurl_vendor/CMake'
CMake Error at C:/dev/ros2_rolling/install/share/libcurl_vendor/cmake/libcurl_vendor-extras.cmake:16 (find_package):
  Could not find a package configuration file provided by "curl" with any of
  the following names:

    curlConfig.cmake
    curl-config.cmake

  Add the installation prefix of "curl" to CMAKE_PREFIX_PATH or set
  "curl_DIR" to a directory containing one of the above files.  If "curl"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  C:/dev/ros2_rolling/install/share/libcurl_vendor/cmake/libcurl_vendorConfig.cmake:41 (include)
  CMakeLists.txt:16 (find_package)


-- Configuring incomplete, errors occurred!
See also "C:/dev/ros2_rolling/build/resource_retriever/CMakeFiles/CMakeOutput.log".
--- stderr: resource_retriever
CMake Error at C:/dev/ros2_rolling/install/share/libcurl_vendor/cmake/libcurl_vendor-extras.cmake:16 (find_package):
  Could not find a package configuration file provided by "curl" with any of

    curlConfig.cmake
    curl-config.cmake

  Add the installation prefix of "curl" to CMAKE_PREFIX_PATH or set
  "curl_DIR" to a directory containing one of the above files.  If "curl"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  C:/dev/ros2_rolling/install/share/libcurl_vendor/cmake/libcurl_vendorConfig.cmake:41 (include)
  CMakeLists.txt:16 (find_package)


---
Failed   <<< resource_retriever [6.25s, exited with code 1]

From ros/robot_model#17 created by @eacousineau

It would be nice to have a param:// protocol as well, so that the contents of an URDF could be set to something like 'param:///robot_description' or 'package://my_robot/urdf/robot.urdf'.

If putting that in complicates things (since it requires the ROS be init'd), then there could be an extra boolean flag to make it explicit (and error out if param:// is requested without that flag).

If others are interested, I could implement that feature.

When trying to compile using ROS melodic

It fails with the following:

-- +++ processing catkin package: 'resource_retriever'
-- ==> add_subdirectory(actual_device/sick_line_mlse/resource_retriever-1.12.6)
-- Boost version: 1.65.1
-- Could NOT find CURL (missing: CURL_LIBRARY CURL_INCLUDE_DIR)
CURL not found! Aborting...
CMake Error at actual_device/sick_line_mlse/resource_retriever-1.12.6/CMakeLists.txt:13 (fail):
Unknown CMake command "fail".

-- Configuring incomplete, errors occurred!
See also "/root/Kit_AGV_ws/build/CMakeFiles/CMakeOutput.log".
See also "/root/Kit_AGV_ws/build/CMakeFiles/CMakeError.log".
Invoking "cmake" failed

Apparently URLs containing spaces are rejected by newer versions of curl:

https://stackoverflow.com/questions/69254520/how-to-use-curlu-allow-space-with-curl-easy-perform
curl/curl#7073

will open a corresponding PR tomorrow

I'm building rviz from source (I have a docker image of Ubuntu 18.02 with ros2 galactic built from source) which apparently depends on resource_retriever, however when I add resource_retriever to my workspace and try building, I get this error

ninja: error: build.ninja:161: bad $-escape (literal $ must be written as $$) 

In the build.ninja file there are two instances of $(MAKE) which seem to be at the heart of the issue. If I replace them with make -j then all works fine. I assume these come from these two lines in libcurl_vendor CMakeLists.txt:

      BUILD_COMMAND $(MAKE)
      INSTALL_COMMAND $(MAKE) install

https://github.com/ros/resource_retriever/blob/galactic/libcurl_vendor/CMakeLists.txt#L57-L58

If I replace $(MAKE) in those two lines with a simple /usr/bin/make -j, again all works as it should. I assume these statements are meant to replace MAKE with the actual path of make, but I don't see anywhere in the CMakeLists.txt that would define MAKE. I also haven't seen the $() notation in CMake before. I've seen it in bash for command substitution, but am not sure what it does in cmake. Since Ninja is the default generator for ROS2 I would assume this would cause an issue for anyone that's trying to build this, so I'm a little surprised there's no other issues logged. Am I doing something I shouldn't be?

Retriever constructor creates a CURL handle by raw pointer and deletes it in the destructor. However, the class violates the Rule of Three because there are no user-defined copy or assignment operators defined. This leads to a double-free on the CURL handle if the default implementations are invoked.

This could be resolved by either: (1) defining these to perform a deep copy on the CURL handle or (2) declaring them as private to disable generation of the default methods.

In RViz2, we're using resource_retriever as a dependency. When doing a find_package(resource_retriever REQUIRED) I would have expected the variable resource_retriever_INCLUDE_DIRS to contain the path to the include files of resource retriever and its dependencies.

However, it only contains the paths to the includes of its dependencies (in an isolated build, e.g. <path_to_ros2>/install_isolated/ament_index_cpp/include;/usr/include/x86_64-linux-gnu). Is this expected behaviour? If yes, how do I get the correct include paths for building static and object libraries?

Background: When building all rviz2 libraries dynamically, everything works fine (I don't quite understand how, but ament_export_interfaces seems to play a role), but in order to have tests for its default plugins, I want to build a static library of rviz_default_plugins as well - at that point, ament can't find the correct includes of resource_retriever anymore.

In the cases where file://... or package://... are the input, it would be nice to get an absolute path to the resource on the filesystem rather than the data. This is obviously not possible if the source is off-disk (like http:// or the proposed param:// in #12), but when it's possible the feature would have been used here:

ros2/rviz@1a3b84f#r177022950

Hi,

When is the next bloom schedule with the newly added retriever.hpp?

Thanks!
Jaehyun

When trying to cross-compile using the instructions at: https://github.com/ros2/ros2/tree/master/arm_crosscompilation

It fails with the following:

Process package 'resource_retriever' with context:

source_space => /home/amar/ros2_ws/src/ros/resource_retriever/resource_retriever
build_space => /home/amar/ros2_ws/build/resource_retriever
install_space => /home/amar/ros2_ws/install
make_flags => -j4, -l4
build_tests => False

+++ Building 'resource_retriever'
==> '. /home/amar/ros2_ws/build/resource_retriever/cmake__build.sh && /usr/bin/cmake /home/amar/ros2_ws/src/ros/resource_retriever/resource_retriever -DBUILD_TESTING=0 -DCMAKE_TOOLCHAIN_FILE=/home/amar/ros2_ws/aarch64_toolchainfile.cmake -DTHIRDPARTY=ON -DCMAKE_INSTALL_PREFIX=/home/amar/ros2_ws/install' in '/home/amar/ros2_ws/build/resource_retriever'
/usr/bin/cmake: /home/amar/ros2_ws/install/opt/libcurl_vendor/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
-- Found ament_cmake_ros: 0.4.0 (/home/amar/ros2_ws/install/share/ament_cmake_ros/cmake)
-- Using PYTHON_EXECUTABLE: /usr/bin/python3
-- Found ament_index_cpp: 0.4.0 (/home/amar/ros2_ws/install/share/ament_index_cpp/cmake)
-- Found libcurl_vendor: 2.0.0 (/home/amar/ros2_ws/install/share/libcurl_vendor/cmake)
-- Checking for one of the modules 'libcurl'
-- CURL_FOUND: 1
-- CURL_LIBRARIES: curl
-- CURL_LIBRARY_DIRS: /home/amar/ros2_ws/build/libcurl_vendor/libcurl_install/lib
-- CURL_INCLUDE_DIRS: /home/amar/ros2_ws/build/libcurl_vendor/libcurl_install/include
-- library: curl
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
library_abs
linked by target "resource_retriever" in directory /home/amar/ros2_ws/src/ros/resource_retriever/resource_retriever

-- Configuring incomplete, errors occurred!
See also "/home/amar/ros2_ws/build/resource_retriever/CMakeFiles/CMakeOutput.log".
<== Command '. /home/amar/ros2_ws/build/resource_retriever/cmake__build.sh && /usr/bin/cmake /home/amar/ros2_ws/src/ros/resource_retriever/resource_retriever -DBUILD_TESTING=0 -DCMAKE_TOOLCHAIN_FILE=/home/amar/ros2_ws/aarch64_toolchainfile.cmake -DTHIRDPARTY=ON -DCMAKE_INSTALL_PREFIX=/home/amar/ros2_ws/install' failed in '/home/amar/ros2_ws/build/resource_retriever' with exit code '1'

<== Command '. /home/amar/ros2_ws/build/resource_retriever/cmake__build.sh && /usr/bin/cmake /home/amar/ros2_ws/src/ros/resource_retriever/resource_retriever -DBUILD_TESTING=0 -DCMAKE_TOOLCHAIN_FILE=/home/amar/ros2_ws/aarch64_toolchainfile.cmake -DTHIRDPARTY=ON -DCMAKE_INSTALL_PREFIX=/home/amar/ros2_ws/install' failed in '/home/amar/ros2_ws/build/resource_retriever' with exit code '1'