mozilla / firefox-translations Goto Github PK

Firefox Translations is a webextension that enables client side translations for web browsers.

License: Mozilla Public License 2.0

JavaScript 98.14% CSS 0.25% HTML 0.86% Python 0.65% Shell 0.08% Smarty 0.03%

firefox translation webextension javascript deep-neural-networks nmt nlp

firefox-translations's Issues

Form translation dialogues hidden behind page's modal veil

On booking.com when trying to use "Form translation", two text fields appear behind the grey overlay that booking.com uses to give the impression of a modal dialogue.

Install current extension
https://www.booking.com/hotel/gb/park-plaza-westminster-bridge.es.html
Click translate
Click Yes to enable translations of forms (and wait an unusually long time for "Loading form translation")
Click "Ask a question." lower down in the page to open a modal dialogue.
Click on the textarea.

Disable telemetry when user opt-outs from data colleciton in Firefox

non-HTML input is treated as HTML

It looks like all input is marked as HTML for the translator, even though nodes' text content is submitted. If a node contains something like Hello < world, it would submit Hello < world. Which when parsed as HTML is invalid input and would cause an exception.

Even if HTML was being submitted, it would not be properly used (and cause an abort()) because the model doesn't produce alignment information. In the model configuration yaml, the line alignment: soft is missing.

Implement required adaptations in the extension in order to utilize the intgemm intrinsincs

Integrate Sentry (or something else more appropriate) for error reporting

As @eu9ene and I discussed, we should have better error logging and reporting being submitted to us.

Translation skips paragraphs

Go to https://ru.wikipedia.org/wiki/%D0%A1%D0%B0%D0%BC%D1%87%D0%B5%D0%BD%D0%BA%D0%BE,%D0%93%D0%B5%D0%BE%D1%80%D0%B3%D0%B8%D0%B9%D0%94%D0%BC%D0%B8%D1%82%D1%80%D0%B8%D0%B5%D0%B2%D0%B8%D1%87
Press translate
Scroll to the bottom and wait for a minute to make sure the translation is completed
Scroll up and observe that some paragraphs are translated to English and some are still in Russian

Implement a mechanism to disable word counting on translationWorker::consumeTranslationQueue

Outbound translation dialogues be present at the bottom of screen when activated regardless of scrolling

The outbound translation (aka form form filling) feature is unusable if one has to scroll to the bottom of the page for each form element. The UI specification currently is two text areas at the bottom of the viewport (not page), one for typing and one for feedback. Ideally with a draggable and closeable pane. Something like the Firefox Web Developer tools.

Apparently WebExtensions can't access XUL so the textareas are injected to the HTML page by the extension. (Aside: is there a security problem/resource abuse issue with this if the page can write to the textareas?) Injecting notional Firefox UI elements (at least from the user perspective, but not from a XUL perspective) into the page seems error prone, but doable in most cases.

It should be possible to use position: fixed and z-order to create a bottom pane within the HTML page.

Example of roughly what I'm looking for from the Guardian's cookie warning:

Except without the veil over the top of the page and without preventing me from seeing the footer of the page.

Add telemetry for outbound translation

when it's stable

Is the wormhole being utilized when enabled for real?

When utilizing the wormhole artifact disabling the simd_wormhole preference have no effect

Implement Telemetry

Improved language detection

We should have a more expanded language detection heuristic in terms of content extraction and analysis to determine the page's language instead of traversing just through divs.

Automatically translate as you browse.

Do not send telemetry on debugging

We need to introduce some kind of configuration for this. Telemetry should not be sent from automated tests or local debugging.

Telemetry reporting engine crashes

We need to have telemetry reporting whenever the translation engine crashes or fail (re: browsermt/bergamot-translator#316). Are we capturing those @eu9ene ?

Translating non-German webpages to German doesn't work

Steps to reproduce:

Download Firefox Nightly (German version)
Start extension (latest main branch)
Navigate to page: https://andrenatal.com/translations-playground/?lang=pt
Infobar correctly displays the page language
Click on Übersetzen
The content is not translated

Replacing pt with es, et, en, it, ru and cs in the link https://andrenatal.com/translations-playground/?lang=pt gives same behavior with following error message in web console:

Error: We did not find an alpha in the model named: F0::Wemb_QuantMultA. bergamot-translator-worker.js:1217:12
Error: Aborted from auto marian::cpu::integer::fetchAlphaFromModelNodeOp::forwardOps()::(anonymous class)::operator()() const in /root/checkout/3rd_party/marian-dev/src/tensors/cpu/intgemm_interface.h:583 bergamot-translator-worker.js:1217:12
Callstacks not supported in WASM builds currently bergamot-translator-worker.js:1217:12
undefined bergamot-translator-worker.js:649:9
Translation error:  RuntimeError: abort(undefined). Build with -s ASSERTIONS=1 for more info. translationWorker.js:120:37
RuntimeError: abort(undefined). Build with -s ASSERTIONS=1 for more info. bergamot-translator-worker.js:653:14

Use HTML translation feature including inline tag movement

Currently the code sends text snippets for translation:

firefox-translations/extension/view/js/InPageTranslation.js

Lines 135 to 158 in c21b61f

    
               submitTranslation(node, key) { 
        
                   if (this.messagesSent.has(key)) { 
        
                       // if we already sent this message, we just skip it 
        
                       return; 
        
                   } 
        
                   const text = node.textContent; 
        
                   if (text.trim().length) { 
        
                     /* 
        
                      * send the content back to mediator in order to have the translation 
        
                      * requested by it 
        
                      */ 
        
                     const payload = { 
        
                       text, 
        
                       type: "inpage", 
        
                       attrId: [ 
        
                                this.processingNodeMap, 
        
                                key 
        
                               ], 
        
                     }; 
        
                     this.notifyMediator("translate", payload); 
        
                     this.messagesSent.add(key); 
        
                   } 
        
               }

This leads to very poor translation quality because the system does not have sentence context. Even if it were to have sentence context, keeping text spans as is prevents reordering and is an impossible translation problem. For example, chien translates to dog. In this HTML, what is the translation of h?
chien

Since block elements are sentence-breaking, individual block elements can be sent for translation using their innerHTML. The HTML parser also knows to break sentences at block boundaries so larger elements can also be sent in. It does assume well-formed HTML though; Firefox is better at fixing HTML and this ensures consistency between rendering and how the engine perceives tags. Well-formed implies tags that open also close inside the same block of text; #23 is a blocker.

#51 is a partial blocker. Specifically this part needs to be fixed first:

Even if HTML was being submitted, it would not be properly used (and cause an abort()) because the model doesn't produce alignment information. In the model configuration yaml, the line alignment: soft is missing.

Once that is fixed, HTML processing coming out of the engine should be consistent with https://translate.ikhoefgeen.nl/ .

Quality issues with HTML processing should be raised on https://github.com/browsermt/bergamot-translator

Incorporate end-to-end integration tests

We need incorporate tests. Since them are not going to be shipped in the xpi, I'd be fine if we merge these https://github.com/mozilla-extensions/firefox-translations/tree/main/test after we confirm they actually work (I recall we had issues before), or we can draw inspirations from https://github.com/andrenatal/gecko-dev/tree/fxt/browser/extensions/translations/test/browser and try to run it here.

Disable telemetry when data collection in Firefox is disabled

New translation request required per page

Moving from one page to another - e.g. following a link on a translated page - requires a translation be requested again from the infobar. It's reasonable to assume that if a user translated a page, and a successive page is in the same language or is in the same domain, they'd want to see the next page translated too. Worth adding an "always translate" function, or translate pages following on from previously translated pages ?

Implement Bulgarian models

https://github.com/browsermt/students/tree/master/bgen

Set versions in telemetry

record BERGAMOT_VERSION_FULL from bergamot-translator-workser.js
introduce and record extensionBuildId, like in the legacy extension:

extensionBuildId: `${process.env.VERSION}-${process.env.extensionBuildEnvironment}#${process.env.BRANCH}

Firerox crashing when running on a manually built gecko-dev

I'm getting the following crash when running the extension in a custom built Firefox from gecko-dev on OSX. No issues on Linux

Assertion failure: !loadingPrincipal || loadingPrincipal->GetIsNullPrincipal() || principal->GetIsNullPrincipal() || loadingPrincipal->Subsumes(principal), at /Users/anatal/projects/mozilla/gecko/dom/workers/ScriptLoader.cpp:1223
#01: mozilla::dom::(anonymous namespace)::LoaderListener::OnStreamComplete(nsIStreamLoader*, nsISupports*, nsresult, unsigned int, unsigned char const*)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x3f6671f]
#02: mozilla::net::nsStreamLoader::OnStopRequest(nsIRequest*, nsresult)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x53efb4]
#03: nsBaseChannel::OnStopRequest(nsIRequest*, nsresult)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x4a3aae]
#04: non-virtual thunk to nsBaseChannel::OnStopRequest(nsIRequest*, nsresult)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x4a3ba0]
#05: nsJARChannel::OnStopRequest(nsIRequest*, nsresult)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x114357c]
#06: non-virtual thunk to nsJARChannel::OnStopRequest(nsIRequest*, nsresult)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x114646d]
#07: nsInputStreamPump::OnStateStop()[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x4cdef1]
#08: nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream*)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x4cd44f]
#09: non-virtual thunk to nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream*)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x4ce21d]
#10: nsInputStreamReadyEvent::Run()[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x2acaa9]
#11: mozilla::RunnableTask::Run()[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x31518b]
#12: mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x2ef365]
#13: mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x2ede4a]
#14: mozilla::TaskController::ProcessPendingMTTask(bool)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x2ee11e]
#15: mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_0>::Run()[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x31a4c7]
#16: nsThread::ProcessNextEvent(bool, bool*)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x302dbd]
#17: NS_ProcessNextEvent(nsIThread*, bool)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x30a0ac]
#18: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0xb97e61]
#19: MessageLoop::Run()[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0xb101e4]
#20: nsBaseAppShell::Run()[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x439b509]
#21: nsAppShell::Run()[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x441f7e2]
#22: XRE_RunAppShell()[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x5f013f4]
#23: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0xb98901]
#24: MessageLoop::Run()[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0xb101e4]
#25: XRE_InitChildProcess(int, char**, XREChildData const*)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x5f00e2d]
#26: main[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/dist/NightlyDebug.app/Contents/MacOS/plugin-container.app/Contents/MacOS/plugin-container +0x3f43]

Collect telemetry metrics "words in viewport"

This should be an initial number of words in the viewport, before scrolling. I guess the idea was to estimate how soon a user will see the translated text. Not sure how critical is this metric for us.

Read bergamot-translator version from the module

Stabilize and polish Outbound translation UI

Form translation component should be always on top

Even though the Outbound/Form translation component cannot be implemented as a native panel in the chrome (since it is not allowed for extensions to make use of XUL/XPCOM), it should act so and resemble it as much as possible. One of the expected features is that it always stays on top.

The following webpages show that in the implementation that I tested (https://github.com/mozilla/firefox-translations/actions/runs/1458463171), it is not always the case.

https://karriere.deutschebahn.com/karriere-de/jobs/Kontaktformular-4199212

https://www.tajmac-zps.cz/kontakte (then click on "Schreiben Sie uns/Write to us")

Adapt engineRegistry to load the appropriate wasm artifacts based on if the native matrix multiplications intrinsics are available or not

Basically download intgemm artifacts if in Nightly or the wormhole one if anywhere else.

Download progress update not working on windows

Implement Localization utilizing pontoon

Identify why infobar can't be displayed on packaged/localized versions while it can on individual binaries either from mach or from the obj folder (osx)

I can't label issues

From @andrenatal e-mail "I created a label to categorize it, so please use it when doing so". However, I lack permission to add labels to github issues here.

crypto.subtle not working on custom built linux from latest gecko-dev main (?)

Implement browser tests detection more elegantly

Report translation errors to the infobar

Empty info/notification popup showing

I have Firefox Translations enabled by setting extensions.translations.disabled on Firefox Nightly 97.0a1 (2021-12-17) (64-bit) running on Pop!_OS.

Clicking the translate icon in the URL bar will bring up an empty info bar like so:

Inspecting the browser console, I see the following errors when clicking the translate button:

notif.init is not a function TranslationBrowserChromeUi.js:313
    showTranslationInfoBar moz-extension://93675596-b356-4a58-bf90-e7e021642882/experiment-apis/translateUi/TranslationBrowserChromeUi.js?cachebuster=1640342430870:313
    onClickCallback moz-extension://93675596-b356-4a58-bf90-e7e021642882/experiment-apis/translateUi/TranslationBrowserChromeUi.js?cachebuster=1640342430870:263
    PopupNotifications_fireCallback resource://gre/modules/PopupNotifications.jsm:1693
    notificationsToShow resource://gre/modules/PopupNotifications.jsm:1213
    filter self-hosted:242
    PopupNotifications_showPanel resource://gre/modules/PopupNotifications.jsm:1208
    PopupNotifications_update resource://gre/modules/PopupNotifications.jsm:1422
    PopupNotifications_reshowNotifications resource://gre/modules/PopupNotifications.jsm:1628
    PopupNotifications_onIconBoxCommand resource://gre/modules/PopupNotifications.jsm:1604
    handleEvent resource://gre/modules/PopupNotifications.jsm:802

Followed by:

TypeError: can't access property "split", n.message is null PopupNotifications.jsm:939:17
    _formatDescriptionMessage resource://gre/modules/PopupNotifications.jsm:939
    PopupNotifications_refreshPanel resource://gre/modules/PopupNotifications.jsm:987
    forEach self-hosted:208
    PopupNotifications_refreshPanel resource://gre/modules/PopupNotifications.jsm:967
    PopupNotifications_showPanel resource://gre/modules/PopupNotifications.jsm:1224
    PopupNotifications_update resource://gre/modules/PopupNotifications.jsm:1422
    PopupNotifications_reshowNotifications resource://gre/modules/PopupNotifications.jsm:1628
    PopupNotifications_onIconBoxCommand resource://gre/modules/PopupNotifications.jsm:1604
    handleEvent resource://gre/modules/PopupNotifications.jsm:802

I tried having a look around the code but don't know enough about the workings of internal browser extensions to figure out the issue!

`We did not find an alpha in the model named: F0::Wemb_QuantMultA.` when translating from `pt` to `de` on outbound translations.

I'm getting the crash below [2] in the model/engine when translating from pt to de using outbound translations (although this seems to be a generalized issue). It's not happening from pt to the other languages but it might be happening with different combinations. There's a screen record of the error here:

STR:
1 - Download Nightly pt-br
2 - Load the extension from master
3 - Navigate to: http://andrenatal.github.io/translations-playground
4 - Choose de
5 - Click on Traduzir
6 - Click on Enable translation of form Yes
7 - Click on the textarea
8 - Type something in the textarea withing the outbound translations widget

[1] https://www.dropbox.com/s/7vw5vhykcnlnwjv/ptde_crash.mov?dl=1

[2]

Using fallback gemm implementation bergamot-translator-worker.js:6245:17
Wasm Runtime initialized Successfully (preRun -> onRuntimeInitialized) in 0.011 secs translationWorker.js:67:29
Creating Translation Service with config: [object Object] translationWorker.js:230:25
Translation Service created successfully translationWorker.js:232:25
Constructing model 'dept' via pivoting: 'deen' and 'enpt' translationWorker.js:252:25
Total Download time for all files of 'enpt': 0.185 secs translationWorker.js:321:21
Constructing Aligned memory. Size: 17140836 bytes, Alignment: 256 translationWorker.js:481:21
Aligned memory construction done translationWorker.js:483:21
Aligned memory initialized translationWorker.js:486:21
Constructing Aligned memory. Size: 4472528 bytes, Alignment: 64 translationWorker.js:481:21
Aligned memory construction done translationWorker.js:483:21
Aligned memory initialized translationWorker.js:486:21
Constructing Aligned memory. Size: 812781 bytes, Alignment: 64 translationWorker.js:481:21
Aligned memory construction done translationWorker.js:483:21
Aligned memory initialized translationWorker.js:486:21
Aligned vocab memory1 size: 812781 translationWorker.js:343:23
Aligned model memory size: 17140836 translationWorker.js:345:21
Aligned shortlist memory size: 4472528 translationWorker.js:346:21
Translation Model config: 
            beam-size: 1
            normalize: 1.0
            word-penalty: 0
            max-length-break: 128
            mini-batch-words: 1024
            workspace: 128
            max-length-factor: 2.0
            skip-cost: true
            cpu-threads: 0
            quiet: true
            quiet-translation: true
            gemm-precision: int8shiftAlphaAll
            translationWorker.js:347:21
[2022-01-27 13:15:45] [data] Loading SentencePiece vocabulary from buffer bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:46] Missing list of protected prefixes for sentence splitting. Set with --ssplit-prefix-file. bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:46] [memory] Extending reserved space to 128 MB (device cpu0) bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:46] Loaded model config bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:46] Loading scorer of type transformer as feature F0 bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:46] Memory mapping model at 0x682a00 bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:46] [memory] Reserving 31 MB, device cpu0 bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:46] [memory] Reserving 8 MB, device cpu0 bergamot-translator-worker.js:1217:12
Total Download time for all files of 'deen': 0.803 secs translationWorker.js:321:21
Constructing Aligned memory. Size: 17140837 bytes, Alignment: 256 translationWorker.js:481:21
Aligned memory construction done translationWorker.js:483:21
Aligned memory initialized translationWorker.js:486:21
Constructing Aligned memory. Size: 5047568 bytes, Alignment: 64 translationWorker.js:481:21
Aligned memory construction done translationWorker.js:483:21
Aligned memory initialized translationWorker.js:486:21
Constructing Aligned memory. Size: 784269 bytes, Alignment: 64 translationWorker.js:481:21
Aligned memory construction done translationWorker.js:483:21
Aligned memory initialized translationWorker.js:486:21
Aligned vocab memory1 size: 784269 translationWorker.js:343:23
Aligned model memory size: 17140837 translationWorker.js:345:21
Aligned shortlist memory size: 5047568 translationWorker.js:346:21
Translation Model config: 
            beam-size: 1
            normalize: 1.0
            word-penalty: 0
            max-length-break: 128
            mini-batch-words: 1024
            workspace: 128
            max-length-factor: 2.0
            skip-cost: true
            cpu-threads: 0
            quiet: true
            quiet-translation: true
            gemm-precision: int8shiftAlphaAll
            translationWorker.js:347:21
[2022-01-27 13:15:46] [data] Loading SentencePiece vocabulary from buffer bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:46] Missing list of protected prefixes for sentence splitting. Set with --ssplit-prefix-file. bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:46] [memory] Extending reserved space to 128 MB (device cpu0) bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:46] Loaded model config bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:46] Loading scorer of type transformer as feature F0 bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:46] Memory mapping model at 0xa89bf00 bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:47] [memory] Reserving 31 MB, device cpu0 bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:47] [memory] Reserving 8 MB, device cpu0 bergamot-translator-worker.js:1217:12
Model 'dept' successfully constructed. Time taken: 1.273 secs translationWorker.js:201:23
loadLanguageModel function complete translationWorker.js:223:21
Constructing model 'ptde' via pivoting: 'pten' and 'ende' translationWorker.js:252:25
Total Download time for all files of 'ende': 0.144 secs translationWorker.js:321:21
Constructing Aligned memory. Size: 17140498 bytes, Alignment: 256 translationWorker.js:481:21
Aligned memory construction done translationWorker.js:483:21
Aligned memory initialized translationWorker.js:486:21
Constructing Aligned memory. Size: 3062492 bytes, Alignment: 64 translationWorker.js:481:21
Aligned memory construction done translationWorker.js:483:21
Aligned memory initialized translationWorker.js:486:21
Constructing Aligned memory. Size: 797501 bytes, Alignment: 64 translationWorker.js:481:21
Aligned memory construction done translationWorker.js:483:21
Aligned memory initialized translationWorker.js:486:21
Aligned vocab memory1 size: 797501 translationWorker.js:343:23
Aligned model memory size: 17140498 translationWorker.js:345:21
Aligned shortlist memory size: 3062492 translationWorker.js:346:21
Translation Model config: 
            beam-size: 1
            normalize: 1.0
            word-penalty: 0
            max-length-break: 128
            mini-batch-words: 1024
            workspace: 128
            max-length-factor: 2.0
            skip-cost: true
            cpu-threads: 0
            quiet: true
            quiet-translation: true
            gemm-precision: int8shiftAlphaAll
            translationWorker.js:347:21
[2022-01-27 13:15:47] [data] Loading SentencePiece vocabulary from buffer bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:47] Missing list of protected prefixes for sentence splitting. Set with --ssplit-prefix-file. bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:47] [memory] Extending reserved space to 128 MB (device cpu0) bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:48] Loaded model config bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:48] Loading scorer of type transformer as feature F0 bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:48] Memory mapping model at 0xd8f0f00 bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:48] [memory] Reserving 31 MB, device cpu0 bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:48] [memory] Reserving 8 MB, device cpu0 bergamot-translator-worker.js:1217:12
Total Download time for all files of 'pten': 0.454 secs translationWorker.js:321:21
Constructing Aligned memory. Size: 17140836 bytes, Alignment: 256 translationWorker.js:481:21
Aligned memory construction done translationWorker.js:483:21
Aligned memory initialized translationWorker.js:486:21
Constructing Aligned memory. Size: 5001420 bytes, Alignment: 64 translationWorker.js:481:21
Aligned memory construction done translationWorker.js:483:21
Aligned memory initialized translationWorker.js:486:21
Constructing Aligned memory. Size: 812889 bytes, Alignment: 64 translationWorker.js:481:21
Aligned memory construction done translationWorker.js:483:21
Aligned memory initialized translationWorker.js:486:21
Aligned vocab memory1 size: 812889 translationWorker.js:343:23
Aligned model memory size: 17140836 translationWorker.js:345:21
Aligned shortlist memory size: 5001420 translationWorker.js:346:21
Translation Model config: 
            beam-size: 1
            normalize: 1.0
            word-penalty: 0
            max-length-break: 128
            mini-batch-words: 1024
            workspace: 128
            max-length-factor: 2.0
            skip-cost: true
            cpu-threads: 0
            quiet: true
            quiet-translation: true
            gemm-precision: int8shiftAlphaAll
            translationWorker.js:347:21
[2022-01-27 13:15:48] [data] Loading SentencePiece vocabulary from buffer bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:48] Missing list of protected prefixes for sentence splitting. Set with --ssplit-prefix-file. bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:48] [memory] Extending reserved space to 128 MB (device cpu0) bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:48] Loaded model config bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:48] Loading scorer of type transformer as feature F0 bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:48] Memory mapping model at 0x1c560600 bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:48] [memory] Reserving 31 MB, device cpu0 bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:48] [memory] Reserving 8 MB, device cpu0 bergamot-translator-worker.js:1217:12
Outbound Model 'ptde' successfully constructed. Time taken: 0.791 secs translationWorker.js:175:25
[2022-01-27 13:15:54] Error: We did not find an alpha in the model named: F0::Wemb_QuantMultA. bergamot-translator-worker.js:1217:12
[2022-01-27 13:15:54] Error: Aborted from auto marian::cpu::integer::fetchAlphaFromModelNodeOp::forwardOps()::(anonymous class)::operator()() const in /root/checkout/3rd_party/marian-dev/src/tensors/cpu/intgemm_interface.h:583 bergamot-translator-worker.js:1217:12
Callstacks not supported in WASM builds currently bergamot-translator-worker.js:1217:12
undefined bergamot-translator-worker.js:649:9
Translation error:  RuntimeError: abort(undefined). Build with -s ASSERTIONS=1 for more info. translationWorker.js:117:37
RuntimeError: abort(undefined). Build with -s ASSERTIONS=1 for more info.

Review infobar UI and make sure all controls are properly working including Firefox panels

Properly split the content when parsing html to respect opening and closing tags

Error when outbound translation widget lose focus

Firefox stderr: JavaScript error: moz-extension://b44b0730-9e1c-41b1-8f15-5215e602e4ff/view/js/OutboundTranslation.js, line 82: NotFoundError: Node.removeChild: The node to be removed is not a child of this node

Update bergamot-translator module

Update bergamot-translator wasm module (aka engine) in the web extension and apply the pertinent changes to take advantage of the latest implementations and features:

Phase 1:

New pivoting API (Fixed via #111)
Review the entire worker and make sure we are using correct config/options and switching things on/off properly (fixed via #111)

Phase 2:

Support HTML/Non-HTML translation per item in the batch Translation API (Fixed via #111)

Integration tests failing

Investigate intermittent integration tests failures:

https://treeherder.mozilla.org/jobs?repo=try&revision=75a4bf9be34c4c5a33ab073cc42689354f7a3e4c&selectedTaskRun=KyTI4GB5QlyBCv5Fjd6tww.0

https://treeherder.mozilla.org/jobs?repo=try&revision=163dde9f926bc54e083612b477a0dc4c5c3d63f0&selectedTaskRun=NiL7EQ1CTXyjcbgqJd1z0Q.0

Translation bar not appearing on pages when URL is typed / pasted

Use 25503dc with directions in the README.md and an en-US speaking nightly
Paste a Russian URL into the bar (I used Linux middle click) say https://ru.wikipedia.org/wiki/%D0%A1%D0%B0%D0%BC%D1%87%D0%B5%D0%BD%D0%BA%D0%BE,_%D0%93%D0%B5%D0%BE%D1%80%D0%B3%D0%B8%D0%B9_%D0%94%D0%BC%D0%B8%D1%82%D1%80%D0%B8%D0%B5%D0%B2%D0%B8%D1%87
Hit enter.
Page renders but no bar appears.
Go to another tab, type es.wikipedia.org and again no bar appears
Click a link and observe that the extension is active.
Return to that original Russian URL and hit enter in the URL field. The bar appears.

Infobar is displayed for unsupported languages

Go to https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal

Language is detected correctly as French, but the infobar is displayed with an empty drop-down box.

It should not be displayed.

Remove dead code from `translation-notification-fxtranslations.js`

[meta] Implement Basic Quality Estimation

We need to be able to enable the quality estimation functionality by switching a pref. This same pref should also disable the functionality that causes performance penalty in the engine, and not only the UI feature.

List of tasks:

#132
Modify extension to encode plain text and send it as HTML to the engine whenever QE feature is on
- This is required as engine always expects html text to return QE scores (as per this)
- The translation doesn't need to be decoded back as the engine always returns translation as html whenever QE is on and this output can be used directly to show colors
#133
#179

Properly report model downloading errors in the translation bar

Triple check if the Automatic translation enabled is being displayed even when the models fail to download

what is happening here?

From https://github.com/mozilla-extensions/firefox-translations
there is note

This repo has been archived and the work on Firefox Translations will continue here: 
https://github.com/mozilla/firefox-translations

but this repository is empty without any commits, progress or informations.

Would be great if someone clarified what's going on.

Incorporate proper readme and architecture docs

[META] Addon signing

Actionable items:

Remove the legacy in-tree version from Nightly but make sure we keep the pref so the addon could turn on the preferences panel: https://github.com/mozilla/gecko-dev/blob/master/browser/components/preferences/main.js#L538)
Bump the version before freezing
Follow these procedures to prepare the addon for signing: https://github.com/mozilla-extensions/xpi-manifest/tree/master/docs
ask in #addons-pipeline for a new release off revision xxxxx for firefox-translations when we have a final release version
Perform addon/security review from the addons team in order to have it signed
Provide architecture docs: #39
Provide a more detailed explanation and references to the generic data review policy, and follow the data review addons policy as well: https://extensionworkshop.com/documentation/publish/add-on-policies/

	submitTranslation(node, key) {
	if (this.messagesSent.has(key)) {
	// if we already sent this message, we just skip it
	return;
	}
	const text = node.textContent;
	if (text.trim().length) {

	/*
	* send the content back to mediator in order to have the translation
	* requested by it
	*/
	const payload = {
	text,
	type: "inpage",
	attrId: [
	this.processingNodeMap,
	key
	],
	};
	this.notifyMediator("translate", payload);
	this.messagesSent.add(key);
	}
	}

mozilla / firefox-translations Goto Github PK

firefox-translations's Issues

Recommend Projects

Recommend Topics

Recommend Org