Firerox crashing when running on a manually built gecko-dev about firefox-translations

[andrenatal]

After commenting all scriptloader calls in the extension started to get the following crash:

[firefox/index.js][debug] Firefox stderr: Assertion failure: definition (Callback should define the definition of type.), at /Users/anatal/projects/mozilla/gecko/dom/base/CustomElementRegistry.cpp:447
[firefox/index.js][debug] Firefox stderr: #01: mozilla::dom::CustomElementRegistry::RunCustomElementCreationCallback::Run()[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x190bd36]
[firefox/index.js][debug] Firefox stderr: #02: nsContentUtils::AddScriptRunner(already_AddRefed<nsIRunnable>)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x182c3a3]
[firefox/index.js][debug] Firefox stderr: #03: mozilla::dom::CustomElementRegistry::LookupCustomElementDefinition(nsAtom*, int, nsAtom*)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x190cd40]
[firefox/index.js][debug] Firefox stderr: #04: nsContentUtils::LookupCustomElementDefinition(mozilla::dom::Document*, nsAtom*, unsigned int, nsAtom*)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x183d443]
[firefox/index.js][debug] Firefox stderr: #05: nsContentUtils::NewXULOrHTMLElement(mozilla::dom::Element**, mozilla::dom::NodeInfo*, mozilla::dom::FromParser, nsAtom*, mozilla::dom::CustomElementDefinition*)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x183d9c0]
[firefox/index.js][debug] Firefox stderr: #06: NS_NewXULElement(mozilla::dom::Element**, already_AddRefed<mozilla::dom::NodeInfo>&&, mozilla::dom::FromParser, nsAtom*, mozilla::dom::CustomElementDefinition*)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x40b663c]
[firefox/index.js][debug] Firefox stderr: #07: NS_NewElement(mozilla::dom::Element**, already_AddRefed<mozilla::dom::NodeInfo>&&, mozilla::dom::FromParser, nsTSubstring<char16_t> const*)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x1b60b3d]
[firefox/index.js][debug] Firefox stderr: #08: mozilla::dom::Document::CreateElem(nsTSubstring<char16_t> const&, nsAtom*, int, nsTSubstring<char16_t> const*)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x19a06b6]
[firefox/index.js][debug] Firefox stderr: #09: mozilla::dom::Document::CreateXULElement(nsTSubstring<char16_t> const&, mozilla::dom::ElementCreationOptionsOrString const&, mozilla::ErrorResult&)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x19a0b3b]
[firefox/index.js][debug] Firefox stderr: #10: mozilla::dom::Document_Binding::createXULElement(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x2a6babf]
[firefox/index.js][debug] Firefox stderr: #11: bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x2d8c38a]
[firefox/index.js][debug] Firefox stderr: #12: CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x60315db]
[firefox/index.js][debug] Firefox stderr: #13: js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x6030d7e]
[firefox/index.js][debug] Firefox stderr: #14: InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x603210d]
[firefox/index.js][debug] Firefox stderr: #15: Interpret(JSContext*, js::RunState&)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x6027109]
[firefox/index.js][debug] Firefox stderr: #16: js::RunScript(JSContext*, js::RunState&)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x601d8a8]
[firefox/index.js][debug] Firefox stderr: #17: js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x6030cb1]
[firefox/index.js][debug] Firefox stderr: #18: InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x603210d]
[firefox/index.js][debug] Firefox stderr: #19: js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x6032300]
[firefox/index.js][debug] Firefox stderr: #20: js::SpreadCallOperation(JSContext*, JS::Handle<JSScript*>, unsigned char*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::MutableHandle<JS::Value>)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x603c6df]
[firefox/index.js][debug] Firefox stderr: #21: Interpret(JSContext*, js::RunState&)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x6026b91]
[firefox/index.js][debug] Firefox stderr: #22: js::RunScript(JSContext*, js::RunState&)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x601d8a8]
[firefox/index.js][debug] Firefox stderr: #23: js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x6030cb1]
[firefox/index.js][debug] Firefox stderr: #24: InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x603210d]
[firefox/index.js][debug] Firefox stderr: #25: js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x6032300]
[firefox/index.js][debug] Firefox stderr: #26: js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName*>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x63de570]
[firefox/index.js][debug] Firefox stderr: #27: js::jit::InterpretResume(JSContext*, JS::Handle<JSObject*>, JS::Value*, JS::MutableHandle<JS::Value>)[/Users/anatal/projects/mozilla/obj-x86_64-apple-darwin21.2.0/toolkit/library/build/XUL +0x6a75a93]

[andrenatal]

This happens only when running both the extension on debug mode via web-ext using also gecko-dev in debug mode. It does not happen when gecko-dev was built for release.

[rpl]

@andrenatal As we discussed over slack:

• about the assertion failure in #20 (comment):
  • I see that the assertion failure in the issue description is triggered when we are checking the loading principal of the shared worker, it would be interesting to check which one of those condition is not the expected one, there are a bunch there in || and so I'm curious about which one of them is triggering the assertion failure
• about the assertion failure in #20 (comment): it would be interesting to attach a debugger and call DumpJSStack() to get a JS stack to get a picture of the JS code that is triggering it

[andrenatal]

Hi @rpl , we won't pursue the embedded browser integration for now. Thanks for helping out, I'll keep you posted if that changes.