Coder Social home page Coder Social logo

Comments (4)

andrenatal avatar andrenatal commented on July 3, 2024

The team has very little confidence in the current bergamot-translator's embedded HTML translation capabilities due the very well documented issues and long time it took to have it implemented along the constant belittling displayed from your team in regards to the way we were trying to solve this problem while your team was still unable to provide the right tools (again also well documented).

But we decided to give it another try in a couple weeks and submit it to QA, but if we still have issues like page defacing, stripping of tags and etc, we will abandon this altogether and remain with textNodes which will be the approach utilized in the user test we are mandated to run internally.

from firefox-translations.

abhi-agg avatar abhi-agg commented on July 3, 2024

#111 imported the latest API changes in bergamot-translator which will enable the extension to use HTML translation feature.

Now, the extension needs to parse the content to be translated and send a boolean flag to indicate whether the content is html or not per batch item to get the translations.

from firefox-translations.

jelmervdl avatar jelmervdl commented on July 3, 2024

Now, the extension needs to parse the content to be translated

The extension (developer) knows whether it is translating Node.textContent, Node.value or Node.innerHTML if I'm correct. I don't think there is ever a need for parsing the content to determine this flag's value.

from firefox-translations.

andrenatal avatar andrenatal commented on July 3, 2024

Fixed by #127

from firefox-translations.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.