ros2 / urdfdom

URDF parser

Documentation is at https://docs.ros.org

urdfdom's Issues

Using wrong headers

It seems that urdfdom is using the system version of console_bridge.

When enabling warnings in #22, it seems enabling -Wpedantic enabled -Wgnu-zero-variadic-macro-arguments in Clang which raised the following warning (as noted here, #22 (comment)):

[  3%] Building CXX object urdf_parser/CMakeFiles/urdfdom_model.dir/src/pose.cpp.o
In file included from /Users/osrf/jenkins-agent/workspace/ci_osx/ws/src/ros2/urdfdom/urdf_parser/src/pose.cpp:42:
/usr/local/include/console_bridge/console.h:67:88: warning: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Wgnu-zero-variadic-macro-arguments]
  console_bridge::log(__FILE__, __LINE__, console_bridge::CONSOLE_BRIDGE_LOG_ERROR, fmt, ##__VA_ARGS__)

Two things from this warning:

• the console bridge is being included from usr/local, and
• it is an older version of console_bridge (not 1.0.1), because the PR ros/console_bridge#64 hasn't been applied yet.