rapyuta-robotics / zethus Goto Github PK

Is your feature request related to a problem? Please describe.
The visualization_msgs/Marker Message has multiple types (e.g. CUBE, ARROW, LINE_LIST).
See http://wiki.ros.org/rviz/DisplayTypes/Marker for examples
While the SPHERE works for me, the LINE_LIST and TEXT_VIEW_FACING does not work. I suspect that only the simple Markers such as CUBE, and SPHERE work.

Describe the solution you'd like
Make sure Markers work for all Marker.type variations

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Currently the hardcoded default is '' which crashes on the console.

When I try to visualise any topic, after clicking on "Add visualization" I get this error : amphion__WEBPACK_IMPORTED_MODULE_0___default.a.RosTopicDataSource is not a constructor

To Reproduce
Steps to reproduce the behavior:

1. OS: Ubuntu 20.04, Browser : Chrome 106
2. Go to 'Add visualization'
3. Select topic and click on "Proceed"
4. Click on 'Add visualization'
5. See error

No console statements. The UI doesn't crash or freezes. It just stops changing anything

Mouse coordinates, message throttling and ros time

rapyuta-robotics/amphion#19

rapyuta-robotics/amphion#17

Robot model meshes and invalid package links

When trying to build with the current version of Amphion, it fails to add any topic because of missing RosTopicDataSource.
Upping Amphion to the latest makes everything work fine.

If the configuration is currently invalid, the UI crashes.
Need to handle errors in configuration with fallback to nested default configuration

Disable submit on error in json.

Describe the bug
On start, the UI crashes and display the following error :

To Reproduce

1. OS: Ubuntu 18.04, Chromium 76, Node 10.16.3
2. git clone https://github.com/rapyuta-robotics/zethus
3. cd zethus && npm i
4. npm start
5. Open localhost:3000 and see the error

And layout, positioning and dimensions through the configuration

rapyuta-robotics/amphion#45

Our setup:

• We encapsulate our ROS environment in a docker container which runs rosbridge + a camera node which streams from a USB camera. Port 9090 for rosbridge is exposed.
• We then run zethus in another container with docker run -p 8080:8080 zethus, and we put the websocket address as 0.0.0.0:9090.

The issue:
While we can connect and visualize our streamed image topic fine, the latency is massive (1-2 second delay). We don't have the same issue when streaming the video out of web_video_server in the ROS container and accessing it on our docker host through the browser, so the issue must be somewhere between rosbridge, and zethus.

Do you have any idea how we could remove the latency, or what the issue might be?

Enhancements over additions in this PR:
#70

With option to reset localstorage config and refresh.

The assert when setting the color doesn't seem to properly work.

I tried to check to make sure only one threejs version is on the page.

The interactive markers require additional dependent topics for update and feedback. Currently this is implemented by listening to the init topic and then switching the topic to update.

This requires some improvements.

Sometimes topic change doesn't work. Other times it does.
Need to investigate on whether demo backend is publishing both pointcloud and image topics at the same time or one after the other.

To have a better idea of how often the visualizations are updated and messages received from the websocket.

I think a lot of the files in here should be carrying a .jsx suffix since they contain XML. Would make it easier for the TypeScript compiler to figure everything out :)