copygirl / carrycapacity Goto Github PK

View Code? Open in Web Editor NEW

17.0 6.0 7.0 1.61 MB

Vintage Story mod which adds the capability to carry blocks in-hand and on your back

License: The Unlicense

C# 100.00%

vintage-story mod storage equipment

carrycapacity's People

Contributors

Stargazers

Watchers

Forkers

nikkyai skillfi nerdscurvy darkstrumn

carrycapacity's Issues

Attempting to carry protected (trader) crate crash

Hi copygirl,

The below crash happened when attempting to pick up a wooden crate that belonged to a trader (was curious what would happen :D) - was able to carry one fine in a test world that didnt have the claim.

Running on 64 bit Windows with 16 GB RAM 
Version: v1.12.11 (Stable)4/4/2020 3:07:06 PM: Critical error occurred
System.NullReferenceException: Object reference not set to an instance of an object.
   at Vintagestory.Client.NoObf.SystemRenderPlayerEffects.onBeforeRender(Single dt)
   at _ZWyx8V7GBY20FZhd02o5wlkBhTM._3MzjqAt5GiJmvnVzhdiANDAEMCB(EnumRenderStage , Single )
   at _12aioOzLogzcJMHhplAX1ctUKPP._3MzjqAt5GiJmvnVzhdiANDAEMCB(EnumRenderStage , Single )
   at _12aioOzLogzcJMHhplAX1ctUKPP._EwXRd5TjiEjwEnwkgR6SD2VwKOi(Single )
   at _12aioOzLogzcJMHhplAX1ctUKPP._H2qn3yZXJ5qaROCXlgxZgsHhHqt(Single )
   at _N5xEhV0YMy0mMOwBe09dKlcWjwu._DmGyRRAceBU1Y01pLfQvCPqzM3A(Single )
   at _TjqHBJw2IYSAlyXCQYRZyDjXkjs._f3BqvaJbeJjUlO1Vz6UZg7yIMVf(Single )
   at _TjqHBJw2IYSAlyXCQYRZyDjXkjs._cEEYga8RkvUZyLxVZDIQqvmAaRE(Single )
   at Vintagestory.Client.NoObf.ClientPlatformWindows.window_RenderFrame(Object sender, FrameEventArgs e)
   at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   at OpenTK.GameWindow.RaiseRenderFrame(Double elapsed, Double& timestamp)
   at OpenTK.GameWindow.DispatchRenderFrame()
   at OpenTK.GameWindow.Run(Double updates_per_second, Double frames_per_second)
   at _KhgOJjJMqvBmMftdPC9NuNGCr2l._KJdbFdyRyPI3RBGfknJMDw7qv3g(_z0CXJGPbPfszOCyrvlmbpR4Uq8q , String[] )
   at _W7oHr1XmopiBCmRiVK2Gh8gGNEX._KJdbFdyRyPI3RBGfknJMDw7qv3g(ThreadStart )
-------------------------------

Allow to carry clay molds (useful for filled ones)

  {
    "op": "add",
    "path": "/behaviorsByType/*/1",
    "value": {
      "name": "Carryable",
      "properties": {
        "translation": [
          0.0625,
          0,
          0
        ],
        "rotation": [
          0,
          180,
          0
        ],
        "slots": {
          "Hands": {},
          "Back": {}
        }
      }
    },
    "file": "blocktypes/clay/mold/ingotmold.json"
  }


  {
    "op": "add",
    "path": "/behaviorsByType/*/1",
    "value": {
      "name": "Carryable",
      "properties": {
        "translation": [
          0.0625,
          0,
          0
        ],
        "rotation": [
          0,
          180,
          0
        ],
        "slots": {
          "Hands": {},
          "Back": {}
        }
      }
    },
    "file": "blocktypes/clay/mold/toolmold.json"
  }

(Modified) Crash on trying to pick up something like Ground Storage

Running on 64 bit Windows with 16 GB RAM 
Game Version: v1.16.4-rc.2 (Unstable)
Loaded Mods: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
02/21/2022 18:00:24: Critical error occurred
System.NullReferenceException: Object reference not set to an instance of an object.
   at CarryCapacity.CarriedBlockExtensions.IsCarryable(Block block, CarrySlot slot)
   at CarryCapacity.CarriedBlock.PickUp(IWorldAccessor world, BlockPos pos, CarrySlot slot, Boolean checkIsCarryable)
   at CarryCapacity.CarriedBlockExtensions.Carry(Entity entity, BlockPos pos, CarrySlot slot, Boolean checkIsCarryable)
   at CarryCapacity.Common.CarryHandler.OnGameTick(Single deltaTime)
   at Vintagestory.Common.EventManager.TriggerGameTick(Int64 ellapsedMilliseconds, IWorldAccessor world)
   at Vintagestory.Client.NoObf.ClientMain.MainRenderLoop(Single dt)
   at Vintagestory.Client.NoObf.ClientMain.MainGameLoop(Single deltaTime)
   at _25hCbD9BEFkP69yUQhdpPQgkOvd._qqcop0mvH9ZoRMTDJIwGb6fcyPM(Single )
   at _bjnBWlJotnHiR69aw1flHb4F023._U6WbyQ4am861wMSz04lHr6bdWYyA(Single )
   at _bjnBWlJotnHiR69aw1flHb4F023._PeYLgU97COZFmBgbuLznjIwJUOS(Single )
   at Vintagestory.Client.NoObf.ClientPlatformWindows.window_RenderFrame(Object sender, FrameEventArgs e)
   at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   at OpenTK.GameWindow.RaiseRenderFrame(Double elapsed, Double& timestamp) in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\GameWindow.cs:line 476
   at OpenTK.GameWindow.DispatchRenderFrame() in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\GameWindow.cs:line 452
   at OpenTK.GameWindow.Run(Double updates_per_second, Double frames_per_second) in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\GameWindow.cs:line 375
   at _As7FGAmUC8gaKIkRNk2zuk1jlJ._zleiWFUbDyAE8J9zHf00bJUUlQr(_M5s9po0jOCy75F2Bz2DU6XdfcDb , String[] )
   at _f8y3Fmmhb3dxIjBj0LM71AeVhBG._zleiWFUbDyAE8J9zHf00bJUUlQr(ThreadStart )

(Modified) Block entities like shelves don't get the content updated until the next block is picked up

2022-02-20.23-38-29.mp4

Attacking traders and trying to steal.

Threw a flint spear at a trader causing game crash. Very easy to repeat.

CarryCapacity-0.4.10

Version: v1.13.4 (Stable)10/7/2020 10:57:49 AM: Critical error occurred
System.NullReferenceException: Object reference not set to an instance of an object.
at Vintagestory.GameContent.ItemSpear.OnHeldInteractStop(Single secondsUsed, ItemSlot slot, EntityAgent byEntity, BlockSelection blockSel, EntitySelection entitySel)
at Vintagestory.Client.NoObf.SystemMouseInWorldInteractions.HandleHandInteraction(Single dt)
at Vintagestory.Common.EventManager.TriggerGameTick(Int64 ellapsedMilliseconds, IWorldAccessor world)
at Vintagestory.Client.NoObf.ClientMain.MainRenderLoop(Single dt)
at Vintagestory.Client.NoObf.ClientMain.MainGameLoop(Single deltaTime)
at _VtIDI6oYFpyEcQSZBFso9UVxS9aA._ZnYzeuHqveMMiEvOnpahncAMjfg(Single )
at _LSAAgZhw31Rqs2is6nnojfZBbQC._4BykKOCicJqCBHpyWIgTmxWrTrg(Single )
at _LSAAgZhw31Rqs2is6nnojfZBbQC._6XmOxKoTYrFLRCGd58p58XW43nD(Single )
at Vintagestory.Client.NoObf.ClientPlatformWindows.window_RenderFrame(Object sender, FrameEventArgs e)
at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
at OpenTK.GameWindow.RaiseRenderFrame(Double elapsed, Double& timestamp)
at OpenTK.GameWindow.DispatchRenderFrame()
at OpenTK.GameWindow.Run(Double updates_per_second, Double frames_per_second)
at _lYLQLGyldvbDG9rPQyiRVeIqQVp._EEzpApWBQHtHR4iMJabXK2wDvlA(_ex0VSgRAdtsvhANmJHZHaf9ATWt , String[] )
at _IcGByoJhapvESnm6vaOawAHbkeU._EEzpApWBQHtHR4iMJabXK2wDvlA(ThreadStart )

adding "Carryable" to any block

Hi Copygirl, Elwood here

Not an issue but a question

I was looking at how you patched chests and baskets. Can the "Carryable" attribute be added to any block or just containers?

I was thinking I could add the attribute to the carcass block in my animal products mod. Then carry the carcass on my back.

I would need to somehow use the jsonpatch "test" to make sure the CarryCapacity mod is loaded. Then i could use patch to add the Carryable attribute optionally to my carcass block.

It's possible to place carried blocks inside claimed land

I noticed this when messing around with a trader's claim. I could place down my basket, but not pick it up again afterwards. Temporarily solution is to go into creative mode, which overrides claims at the moment, allowing the container to be picked up regardless.

Tracking issue for version 0.4.0

Version 0.4.0 will introduce the ability to pick up blocks into a players' hands on as well as their back. Here's a couple of things that still have to be finished before a new version can be released:

When carrying an item in hands

Render what's being carried when in first person. (7bf7302)
Drop whatever you're carrying when getting damaged. (39f49ac)
Replace and lock hotbar slot so no items can be inserted.
(As well as off-hand slot now that it has been added.) (3ed1dd2)
Prevent switching to a different hotbar slot. (See VS issue #211.) (7bf2cb9)
Prevent attacking / interacting when carrying something in-hand. (See VS issue #208.)
Work-in-progress implemented in 525566b, still waiting for proper events.
Properly implemented in 1.9.4 with ed2228f.
Prevent sprinting when carrying something in-hand. (Mentioned in VS issue #218.) ( ed2228f)

Other features / fixes

Test the old-version-attribute-updating with real worlds that used CarryCapacity.
(Found some issues, fixed with d7dd6ac and 9208dea)
Rework block dropping code so they don't just drop in the exact same x,z vertical column the player died / got hit in, but instead place nearby if it makes sense. (20f4c69)
Implement a Shoulder slot for carrying animals for The Neolithic Mod. Should include an animation where the player is holding the animal with left arm. Also prevent carrying in hands when something is on shoulder. (19c5390)
Display an icon in the center of the interaction circle depending on the current action (pick up, place down, or swap with back).
Fix floating carried blocks at own player's feet when other players are out of render distance.
(Appears to be a game engine bug. See VS issue #216.)
Fix animation not stopping upon dropping held blocks after taking damage. Does the server not have any control over the players' animations? (812204f)

Carried barrels don't show their proper sealed state

I'm using the Github v0.6.4 release. I didn't see that this was fixed in the commits since then.

Barrel:

When picked up:

Allow picking up of own dropped block in claim

When a carried block is dropped on damage or death within a claim, it should be possible for the owner to take back their possessions, instead of being prevented from doing so due to the claim.

Save the "owner" somehow (by name?) when the block is forcibly dropped
Ignore permission check if the same player attempts to pick up their own block again
Do not change any other behavior: Other players can still interact with, pick up, destroy a dropped block (as long as they have permission to do so within a claim)
Intentionally placing carrying blocks does not save the "owner" property - and shouldn't be a problem as you aren't allowed to place them in claims anyway

Not working for older worlds

I've found that it doesn't work for my worlds that were created before updating to 1.16.5 including a 1.16.4 world. It does work if I create a new world just not for any of the older worlds. I also have removed all other mods to make sure they were not causing a conflict.

Hotbar slot doesn't 'unlock' after being damaged while carrying a block

When carrying a block, if one takes damage the block is forcefully dropped. The issue is that the hotbar slot that was being used to carry remains 'locked' and always appears empty. Moving an item into that slot, the slot still appears empty. Issue can be corrected in-game by picking up a carryable block with the affected hotbar slot and setting it down without taking damage.

Crashes when trying to put down basket

using 5.2 but this also happened a few days ago using 5.1

Running on 64 bit Windows with 16 GB RAM 
Version: v1.14.0 (Stable)12/12/2020 8:33:42 PM: Critical error occurred
System.MissingMethodException: Method not found: 'Void Vintagestory.API.Common.BlockEntity.FromTreeAtributes(Vintagestory.API.Datastructures.ITreeAttribute, Vintagestory.API.Common.IWorldAccessor)'.
   at CarryCapacity.CarriedBlock.RestoreBlockEntityData(IWorldAccessor world, BlockPos pos)
   at CarryCapacity.CarriedBlock.PlaceDown(IWorldAccessor world, BlockSelection selection, Entity entity)
   at CarryCapacity.Common.CarryHandler.OnGameTick(Single deltaTime)
   at Vintagestory.Common.EventManager.TriggerGameTick(Int64 ellapsedMilliseconds, IWorldAccessor world)
   at Vintagestory.Client.NoObf.ClientMain.MainRenderLoop(Single dt)
   at Vintagestory.Client.NoObf.ClientMain.MainGameLoop(Single deltaTime)
   at _6HHEy0R7TdcydZEq9IGp6JeHxdi._ogIdn3jhm7KUUuyvw6LDaa2X3PC(Single )
   at _gVBHOlByVD3vztgY4vPBxj2Bdae._ZKkvVIgccAdBc9j9BIZLqcgTrNL(Single )
   at _gVBHOlByVD3vztgY4vPBxj2Bdae._UQuOSpN5p2QIPbIExoPtD2ecXtb(Single )
   at Vintagestory.Client.NoObf.ClientPlatformWindows.window_RenderFrame(Object sender, FrameEventArgs e)
   at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   at OpenTK.GameWindow.RaiseRenderFrame(Double elapsed, Double& timestamp)
   at OpenTK.GameWindow.DispatchRenderFrame()
   at OpenTK.GameWindow.Run(Double updates_per_second, Double frames_per_second)
   at _93RBbYKdbejiH9hVmbTS8c6kZxJ._hbMghNVJIKTGI5zBx3SuxRG1XDI(_Lsm9ms4vr0dfuNPxkLwK9w8a58N , String[] )
   at _eVFDVqwXngafMmcD9boVPO86iWx._hbMghNVJIKTGI5zBx3SuxRG1XDI(ThreadStart )
-------------------------------

Support-dependent block doesn't fall (with Better Crates mod?)

Support-dependent block doesn't fall if support carriable block like Better Crate under that block is carried. I noticed that bug with brass torch holders and planters, but I'm sure that the same happens with the rest of the blocks that need support block

Not able to load world with mod enabled anymore

Game version: 1.16.4-rc.2
Mod version: v0.6.5-rc.1
World: https://we.tl/t-zk2bJm08DR

Description

When I load my world with the mod, it crashes. When I disabled it, the world loads fine.
I played on 1.16.4-rc.2 with v0.6.5-rc.1 version just fine, so I don't know what the problem.
I have storage vessel filled with items on the back.

Logs

Running on 64 bit Windows with 16 GB RAM 
Game Version: v1.16.4-rc.2 (Unstable)
Loaded Mods: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
02/19/2022 17:05:49: Critical error occurred
System.NullReferenceException: Object reference not set to an instance of an object.
   at CarryCapacity.Common.CarryHandler.OnLockSlotsMessage(LockSlotsMessage message)
   at Vintagestory.Client.NoObf.NetworkChannel.<>c__DisplayClass12_0`1.<SetMessageHandler>b__0(_2otdrmfSKfjlCdVIjRYcVy8uo7U p)
   at Vintagestory.Client.NoObf.NetworkAPI.HandleCustomPacket(_yyyo0JT9wi3btNTUXP38bgDMMkY packet)
   at Vintagestory.Client.NoObf.NetworkAPI.HandleChannelsPacket(_yyyo0JT9wi3btNTUXP38bgDMMkY packet)
   at Vintagestory.Client.NoObf.ClientMain.ExecuteMainThreadTasks(Single deltaTime)
   at _fxfI2UE0ayN90kkW3TlPfqCqByE._9cfcId0IFdBkNhMH5h3zKScp7JtA(Single )
   at _bjnBWlJotnHiR69aw1flHb4F023._U6WbyQ4am861wMSz04lHr6bdWYyA(Single )
   at _bjnBWlJotnHiR69aw1flHb4F023._PeYLgU97COZFmBgbuLznjIwJUOS(Single )
   at Vintagestory.Client.NoObf.ClientPlatformWindows.window_RenderFrame(Object sender, FrameEventArgs e)
   at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   at OpenTK.GameWindow.RaiseRenderFrame(Double elapsed, Double& timestamp) in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\GameWindow.cs:line 476
   at OpenTK.GameWindow.DispatchRenderFrame() in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\GameWindow.cs:line 452
   at OpenTK.GameWindow.Run(Double updates_per_second, Double frames_per_second) in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\GameWindow.cs:line 375
   at _As7FGAmUC8gaKIkRNk2zuk1jlJ._zleiWFUbDyAE8J9zHf00bJUUlQr(_M5s9po0jOCy75F2Bz2DU6XdfcDb , String[] )
   at _f8y3Fmmhb3dxIjBj0LM71AeVhBG._zleiWFUbDyAE8J9zHf00bJUUlQr(ThreadStart )

Stopped working from VS 1.15.0-pre.10 upwards

I can't pick up and carry items anymore with the new 1.15 preview versions from pre.10 on. It works fine up until pre.9.
I use CarryCapacity v0.6.1.

Crash when carrying block while backpack slot is selected

Reported by julius van vern, this exception occurs when trying to pick up a block while a backpack slot is selected. He thought that picking up blocks in the backpack slots was the intended way to put blocks on your back.

Running on 64 bit Windows with 32 GB RAM 
Version: v1.12.14 (Stable)13.04.2020 19:37:32: Critical error occurred
System.ArgumentOutOfRangeException: Der Index lag au?erhalb des Bereichs. Er darf nicht negativ und kleiner als die Sammlung sein.
Parametername: index
   bei System.ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument argument, ExceptionResource resource)
   bei System.Collections.Generic.List`1.set_Item(Int32 index, T value)
   bei CarryCapacity.Utility.LockedItemSlot.Lock(ItemSlot slot)
   bei CarryCapacity.CarriedBlock.Set(Entity entity, CarrySlot slot, ItemStack stack, ITreeAttribute blockEntityData)
   bei CarryCapacity.CarriedBlockExtensions.Carry(Entity entity, BlockPos pos, CarrySlot slot, Boolean checkIsCarryable)
   bei CarryCapacity.Common.CarryHandler.OnGameTick(Single deltaTime)
   bei Vintagestory.Common.EventManager.TriggerGameTick(Int64 ellapsedMilliseconds, IWorldAccessor world)
   bei _hLaepLRCOckdCEvZTPp1GxfgrdT._gvVdZYlJjMijmkAmKtFDCvJNXax(Single )
   bei _hLaepLRCOckdCEvZTPp1GxfgrdT._nu0syyqM6QcVDRvU3XOrq03zfUh(Single )
   bei _wbw3WsD1ic8cZIS5Ql2MkIqPWmb._ibkrrJqCs89QNSe99xnFzRxp3sL(Single )
   bei _s54YxMQ8l5DBeihbmw81nJkPTSU._RT1lBvzfhVzcDZ6jmYewDTkUdvx(Single )
   bei _s54YxMQ8l5DBeihbmw81nJkPTSU._EZIJU8BLizIQdIOGgxu5BrkHzpV(Single )
   bei Vintagestory.Client.NoObf.ClientPlatformWindows.window_RenderFrame(Object sender, FrameEventArgs e)
   bei System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   bei OpenTK.GameWindow.RaiseRenderFrame(Double elapsed, Double& timestamp)
   bei OpenTK.GameWindow.DispatchRenderFrame()
   bei OpenTK.GameWindow.Run(Double updates_per_second, Double frames_per_second)
   bei _gilSYm6aSzOct8TKUm64HAM8OHp._tyidesQGCE1oKHv8YEo8HwYCSty(_RxGTCHor7fqeGRNMEH5pZVfBHHK , String[] )
   bei _xmrDk9pogtvR6xvbzmBc2dtFsbu._tyidesQGCE1oKHv8YEo8HwYCSty(ThreadStart )