"Provides [amount] [stockpiled resource] <in [tileFilter] tiles>" not working in non-[Fresh water] tiles about unciv

[yairm210]

There's a "tile checkfilter" command, can you use that to check the filters?

[SpacedOutChicken]

I don't know how to use the console. Is there a guide for doing so?

[yairm210]

https://yairm210.github.io/Unciv/Modders/Scenarios/#console

[SpacedOutChicken]

I've got the console open, but I can't make any sense of what I'm seeing. What should I be putting into the check, and what results should I be expecting?

Sorry if this is a dumb question.

[SomeTroglodyte]

tile checkfilter "non-[Fresh water]" I'd guess (select the tile to test outside the console first), as that is the part declared to be a "tileFilter" in the Uniques dox. Needs quotes and proper casing to be meaningful. I'd bet it's the lowercase 'w' - or otherwise the parser not understanding nested brackets.

Seems to me "Fresh water" vs "Fresh Water" vs "non-[Fresh Water]" vs "non-fresh water" is still not handled well... But how else can we reliably differentiate a water source from "supports a consumer"?

[yairm210]

There was a problem in the checkfilter command, now fixed
That aside, checked, your exact unique is working absolutely fine for me
I confuse

[SpacedOutChicken]

When you build the improvement with the "Provides [1] [Stuff] <in [non-[Fresh water]] tiles>" unique in Fresh water tiles, does it still provide the stockpiled resource? Based on how I'm reading the unique, it shouldn't be doing that, but when I test it on my end, it's still doing exactly that. The "Stuff maker" makes the same stuff in Fresh water as it does in non-[Fresh water] and it's not supposed to be doing that.

[yairm210]

Nope, it's working, and I even have a test to reproduce it

    @Test
    fun CityResourcesFromImprovementWithConditional() {
        // given
        val resource = game.createResource(UniqueType.CityResource.text)
        val resourceImprovement = game.createTileImprovement("Provides [2] [${resource.name}] <in [non-[Fresh water]] tiles>")
        game.getTile(1,1).addTerrainFeature("Oasis")

        // when
        game.getTile(1,1).setImprovement(resourceImprovement.name)

        // then
        val resourceAmountInCapital = city.getAvailableResourceAmount(resource.name)
        assert(resourceAmountInCapital == 0)
    }

[yairm210]

And without the oasis it provides the resources

    @Test
    fun CityResourcesFromImprovementWithConditional() {
        // given
        val resource = game.createResource(UniqueType.CityResource.text)
        val resourceImprovement = game.createTileImprovement("Provides [2] [${resource.name}] <in [non-[Fresh water]] tiles>")

        // when
        game.getTile(1,1).setImprovement(resourceImprovement.name)

        // then
        val resourceAmountInCapital = city.getAvailableResourceAmount(resource.name)
        assert(resourceAmountInCapital == 2)
    }

[SpacedOutChicken]

I don't know what's going on, but I swear that it's not working on my end. I'm using 4.11.19-patch1 and it's still not doing for me what it's doing for you.

Can someone else test this, and see if the problem is just on my machine?

[SpacedOutChicken]

I tried it out on Android, currently running version 4.12.0, to see if the problem exists there as well, and it looks like it is. I converted Stuff to a city-level resource to see if that would change anything, and I built one improvement right next to an oasis with the other next to no Fresh water. The result: still getting two Stuff in the city. You can check my code here: https://github.com/SpacedOutChicken/Lodo-s-testbed

I don't intend to be an annoying asshole, but I've been able to consistently get the bug on my phone and my PC, so let me ask: are you sure it's working on your end? Is there anything about the test you ran that might not catch the behavior we're looking for?

[yairm210]

I'll test this more hermetically
I have no doubt that there is a real problem, I'll see how I can replicate - I think I'll use your mod and game save

[SpacedOutChicken]

Here are a pair of saved games you can use. One with the Stuff Maker next to a river, the other with a Stuff Maker next to a lake.
StuffMakerRiver.json
StuffMakerLakes.json

[SomeTroglodyte]

I don't intend to be an annoying asshole

Thanks! When I read that in my mail, I laughed out - "they seldom do" came to mind immediately. Sorry, it's not you, just the word combinations... Sorry again, won't debug myself unless y'all ask nicely, because I get lost in all that stockpile code, it's unfamiliar and I quickly scratch my scalp into a bloody mess "how is all that supposed to work???" :where's that rips-hair-out-not-that-i-have-any-left emoji: - Yair is the better person for this. By far. With strawberries on top.