Comments (6)
That title change suddenly makes it clear - that was a situation I was doubting but forgot to actually test. I thought in that case there would be more than one "rejection reason", one for the chopchop one for the tech - maybe that's not the case or I thought of == 1 but forgot to code it. Let's see...
from unciv.
I also found this but forgot to report it.
from unciv.
Ah yes exactly: the 'problems list' for the plantation sees no reason to include the tech problem for the chopchop. Hadn't thought of that. Can demo with no research and a Farm too.
save
H4sIAAAAAAAA/+1dWXPbOBL+K1o+zVRFs6YuUn5znEnsqXGsGms2Dyk/QBIkoUKRWh5OPCn/92nwEEmR4GWiydlNpSqJeKH7Q6PR3R8IfleeqO0wy1Quvyumd1hRW7mcvFHWNiUu3Xxi7p6fcek3V7lUJr+oo19U5c3pSvXiYv7yApezJ2awv4gLT3KUy8/f+ZGP5EDhprfEXhGbETjxBh605g+EW46WwdaMOsEvuPwabnVtbx0+gx/9r0cd946YZMcb40dsarAdXJA6uLOMDTWvdtHDdlz4BbWOBuXCHy1mus57y/4IWnzg5z5Qk9rEuLY80/UfoviHB+Fx5XJ0ccHVos4R2oKGUs09sbVr2c9puTxmOqkjLgFN1sS4ug1+029Hw7Lp5g+6C+CGBkA2gzxTe/l85EjdeAdiKm8S2F1Tw03A5v/r/EEdSuz1nm4AaeWBAPLmDi66JgY1N8SG/y4sFxR7hv9d7Wy29gzXs6nyGDzIWVrRI/gDrvij4Fo4a4ExbA3r6wN0jLkGAUaTdE8pzt7yjM39kZoLfvR5wdZfuMbQcfR/shuPtvWNHZj7zB//YJm7PWHQMR8tk/qQH+lgaX0140NXpvuV2sf4wHve7T6a0RFogBkk/n1DDYeZXxLPvbN2ZMOcvRcdyjEo03LZFg7EYy4cpVHnDqzt4HNoCY+DPXEGa+sAYMK4/he0wdbBfcqDS9xb/uPfUb+DKZB1/NwlGM2V/zuywdA8IzN7eXnkxpzXfmSUcgQ4mXyBBOEAkSNANPp4+4/c/l1/oMAthhV0Db/hm3I5VN8oYEMj6DgG41ah28mYzslsqE6oPpyM52RIptvVUCPqVNtuxqPtfMsdbdDMrxtmrjx7t4dDWzB3+Lm7Zk8JD3G0jp4RNeiPRPf5fCgqK48Z7lv4i9/va74gBuHqBg4KfPTpAdEQDb1XNIRC58aMUM2UasHPkf9T5T/h33F0WI0Pxz/H4VVnN484mF8t+wvdLFNNRc+G08y5t0FCExwAOTKXj3fuhUB1yzTpGvp4aYVneP968BCFX6DEHXUdzHLwwBz/rLjW8Xe6dcMODOTVQPkVWL11+IPt9tG54dQ/OZxyb2MQx32g1Lw9gO94ogdq+pf9BBqPfuY9Bj0zWFPfZcHlYJW/gtu9/2rSTa5CHJl4RohcUOGccMfMYEpY7ung055SIz0nmOxAjMGN56yIuclOE/8Hs3PKrQdjSOxp86fuuE9ib/2jV+T1igljGBr6ZJkbCFk5oPfGZvCeQIi69Qw/uCntt8AvcndAF/AQkNPwW1Nubdt3nqBIum+j6fxHz3Y53oT99t6G+XpjPCuJK6BvLM/2A67f6Fdq8AAlPV6D+OtHl/a7S9OdFofaP/rtVf22YdAVB7L2+y1OPb4rlgt54PUJ8NOp0y3Qo6dIakF53PjSqdO+sRweiJ4ZSkLuH3bSlp0kEt2MoSRHZk8tRTi9n5LzH8bSy8ngNMSh/1dxITE00O3WB5lf+I7yG4LM9I4cuRgHclwQG/rZ9Q3KP/DA/vJRCvPqJTP5TTaE79xW1QvIOtmG1zxHY0jNaJDjqdOXVEX0P1HJNCyIDn7yc+oBr4b+DI9zqJ9Taqqu6+PJZDzT9DBn/p05rp/LrohDlxSskvHHfLCJ4xhgO74Z+kffUz4e/MxXuWGGPwAi3N4+86MBynB4Dw+FHgpxtEyXmX7OCcqwOAe9NRe2BbbiwCNNzzCgJc82naWVylMv/KKk5bBs6WKo8tw3JfcdNyn+34xsCZcQRlvngrYi2qmmcCbYwoB/nfpoJqp1j3z4nQLJK8M7MNM7KPHRqwPXXrkc+zn827Ao8BRVQxNHeRUhfUZmj9XtqlBxad3Uagc99gzsb42UAzMDxcAVlJthqmNizcEvoSpZ36KkjPew/jccZaRJutAqvigxtm+fLH/Olo3h6FQBriq6wBndWLZDnRxXNMKbDOqoIXAtMsaiAOLTiBRYagLca4sYAi/ftvABa0rMP03ml4jBRvmIjusTVlgPvj8/EYYvD9R1DcoJv7Vng6W4d6cGRgHPoI792OxgJeLMQ3jRHT1AA2Fx/XwGGfmMSs7h13tyJHNoZggW2URoR744llK5SProj35kL82Kc1xuozgx1+c9QBJzlOHzRDYdgXZu0tHx0KI/cc6n0KC1BgadpJ8yZp3iphoAXjaZnwHPjC+KwM4qhDBIFlhvmP/mmTuDZvXPDWISWNwzkactCHTyoz/Zs159T4ITTdQLPks7ShxeSwe4VZ8XDZA49quczukIyo4DZccZZd9Rh9puQQh75kzcYLmIbIHHEVf/6rk/ZWlINpWVu26ygDOWi+XsWfxfB9Rc539NeOyKYLxqBXCrpAXgE03Z4uYjK5hq8OLoyiLlIRel130KrbPT+e/kC60McTNRDhAYu8R+bhoaE9tmVlFsPHpVaJyT8aXXrdWzAJbUP7XoqZ4pXEuLcUURB4Ip5M9UxcFPBR8VudReDLWs04iAlQBgfQ+FEzMVxOcdBkbjKsF2p7i1UCVFCzAiOJsVpWVAKizCJKLbzGyTOFe9vDhpOOVMAsgm+XPO6WyzwP20AgTBXANRiyXtZ3Y0FoFcJQnF8QJZ2YSkkxC6VlPJBmDh55FZIV/BtlbnwJESzzpOAZt4quWwUCbUuojFrxfk0wYYBadiE+4oLBGWPYrGlogYKEH5HfUnXaQRVU8lUQm5XwyacJlAfm6X1x/SJpFaYWKvUBWmDadJECloqZxVobmHgsAgMbA/7WEkYcDUagiAE0IXWFWHQfKkIS1VhxJGcveTVyXWWEgXy1dgvGhJdILVPs+hE6eqp9CzZin0JJy88xLoiWBirzCikoV72yc8uiCZJqUEaXU31lFhIH4n+PVFjG6Wp50pFOiTVQckcmp46VYNpA1wcfxusaQF1oyxaEtQGqotszA56Aj6sQD6VyzQFvjKP21IHHJLIxjuciStv9JaviUm/MlQONISuHo9V5qaYpWosmKjJUhqBWfTQT2nlqOOsnGE2ljtEXNHbGdfeexP0OpSlQtmWODGw6F/tbwG68IwYROtBusatgY0JyZsVYjjPs4awhIDXlVNVIFpUtvOq3B06iHFGYuEvKTVWDPeVwjBDKcCG5AJVqnlV3/JBR+qrKfpJBOeirxytZezhbi1iFR2KitHKuE9FpTYhqR1Y1NRKFAJvcRWIyhAZkOpLk2uxuqMKqClNgDhbwclt/9ArO8m5Duv7yZOVa/vThsukZoFKM/yl0idzjYrgMXbmmHWYwKhszLLn2P+WThN8XGa/BNxmghwElQ7uqudRxXVYlFxErhuZYhqld1KMRIggZdyqSIYBBwdYiatCsA5ZTLYKxpKgMpJEu6JwxzxuiuEymINp4TxYllcKexjJTYeEAX5c+sSiN7HileDncd/8ZnK72TNz6K/1K/PytXhuGcrZnmOv2irSmB4WoqcFxcK1yk3IU7wi54Fy6iQqpsNi8LYnEocUxTUiZEql5XfDczHq/NlJk03u8DJAnLKY9LTpeLlbtKzREyFK8/TWMN6JuiB+zUlmTChJQza3W8IsxQ7E4xg+Wi1shMWPlRNarHyQGxjgV8HIDapwyZcyXuQVqpttrH8uwNYs8F/NIy7sM3aa0OEjGhXK1C1QBFNaK05Sly5Vp41VKjvtSKzFn9lB9mfZ9tstvNUaVE04Qg+0ANGnD7DB3UqAnXpmRubtIsoTiAuHkbyyvHZNgWpVQQMWtG9oGcTBi7e4Q+p4F48qnFqCsUydFE5GPUBnBH+qFJLR1Wz6lhfljqpuJDmY9kxgSEbgBaqxg9ry3MLasbnW9yKa8ZvlNudCRgPQrsdrC0egVasJJ84KL+SLFoPUUex0tUQDRdDpCUVnewzsSEuaklJDFG4jfPNf1rjNqaIFtlkg/SMpKKTPVyUX/pmzT+TZ9Nbt8XT/kht2WLp3uYN3wROCyo6+VpaC+srGUPR1k8i/jza5o0lnwwJEf+SszvwP1WFx4X19Z0S0Rvh8oJt4brk/FKpCIw2yxEFJXucEkwOxSK9sIVJH6KWmDAzRw2flNPK2N+Ccn3SPdpkJRESVOZNq7neAJXC0AQetkU8hN8LSnx/PPPJoMS56mvW1YZr1rVoFsxds66J5sies1OaICKRb+pViUbJb59oJfScPACqbjeC9yaOJkjn5WMhLiEIsHhEYp31QD69In2LxSUGYomlktdT2TbzewqXVZWKhGhuilU8n5niM9XnpaZfOJhF/VL0LlUWn/pkZYKHK1/iOMPKO1DHwLTZGJBi+FOB+vKZ216oP8FXf1ymfvttjvG1HJVpiTHvjkr0Rpn71XrmLrXMo+IaQj/0RnbvQgq9i7IeMt8dMzviULz6kjq50IjecOwXE17O66gXsoidfOqu6daHZVu9YxT5RdsdyhsOwg+1dOENRJ9ikc5xVF1Tj8FxiGXBCAeE70ZIpznEPJOsdBqXzMFnIFCTRszGdHwyR8e3GB2fn9HrUb6SC7W6fEJGAEDV+UDE2Ulzzzo+kaH3isjQ8YkMXRRQ5hfHUQBAZS/05uyFLP1R1ynooow53wDk6j+cB9LMEREImsRsMcJc3CZiEVbHV18Tqd9BDVrDV3/WI/Vn+OpPG6uPsW5oig/IBN/nTQRaymdeMLUc4/flCF/LEb6WatkQllXYR9OyWD3pjgi5Q/vEkg1FNJnsEdSENLJxtoHGfxdVuCFoXyARbRYqe86svOQPg0zArBQId9XOz1kwyATMSpFwRyC0OSFOHTCLhsJF7dLzQ8wmOyiAD/Hr/KgxIn4JB7X35vgWM8enTOZllIksLVF5kfkreBFZAKCyIPNesSBzfBZk3isWZI7PgsxF8b5sd4bKdczLuA5ZWqIuVpiXve8iI2m/COfDC8yyRdAoapuniR+z0XkHeupCPTugKfQOANBKOxqdpsIFYNbcAvAW8+FCMu1g8E870HPSgZ6TDvQcd6DnuAM9Rx3oOepAT7WLKARZT1wFsbtQSC1Ktxp8zhY3RBe9jyfb01VeWiaXMhBtdiudMBLn1PiEEWZ+P+0TXzZFrykJv3UgPWLHbFK4Z470xAyzSeGbA9Lzb8wmO6A0hvjMDXJA2kU9rJPCH76eqMMx0hOz0bBNVOca6YnZaNgm6lQZ6YnZaNgmKrMV6YnZaNgmKoEV6YnZaNgmKoUV6YnZaNhmJ4QS6uYhFyWFADc4ktxY4Vbad74iBOTVJfj+EjtyoAtiw9+gnMPb3rDtlq09w4UHK+8oc/m22s6R0o3CvwFDzA2x+S4TR4M8+7d8/q6s95ZDzWv2xNM7arjO6fzy+chZgBvvACKDmi8A1hNbc7n5KR/DB38vbAatwm3X0LJnE/5hnnfWgZnExwR+MMgWD/CLX7RkB+pvqBHuy7Hw20o0ztW65QJrm/FmPNM2Q3Wl6sPJeqUPV9uZNlSndDbW9OmFfrGF6w1ISflGIfweVTtBC+ra7hLA43D9DRDHgyaN2gAA
from unciv.
Now how to solve this elegantly (meaning simple and thus reliable and maintainable - the original idea was too simple)...?
- In ImprovementPickerScreen.getProblemReport, after the
Try after pretending to have removed the top terrain layer
comment - check the tech for the removal improvement, and if tech not met - silence the suggestRemoval report entirely or add the "research Mining first" on top? - safeguard the actual queueImprovement (startWorkingOnImprovement wasn't before either) against forbidden stuff, repeating the
canBuildImprovement
test?
See PR for how I meant the first one... relatively elegant, but now the list can be much longer - what's the theoretical maximum?
from unciv.
Old idea: Should we maybe not list improvements at all if they need a tech that is one entire Era away, or more than one if we wanna be less impactful? No Railroads until you are near enough to even imagine them? Edit: OR - have at least one tech researchable or researched IN the era the requiredTech is in... Tradingposts appear once you got Iron Working AND Engineering OR Pfilotzopfy AND Drama Queens but not before...
from unciv.
Oh my
- "Acquire more" would show the Unique.toString() not the resource that's missing
- There's a
IHasUniques.era(ruleset: Ruleset)
that's broken for... Technologies are IHasUniques too - There's a
IHasUniques.requiredTechnologies(ruleset: Ruleset)
broken for TileImprovements - someone forgot to override legacyRequiredTechs
Since I noticed while following that 'don't show what you can't even imagine yet' idea I think I should push these fixes together with that filter... Maybe make the Era diff a ModConstant?
Also, I'll need to redo that PR, I erroneously squashed locally across the "pushed" boundary
from unciv.
Related Issues (20)
- Nation/City State icon before city name in Wonders and Notifications Overview HOT 6
- Auto production on Work Boats
- Movement of Air units goes wrong.
- retracted
- AI: Balancing of accepting "unfavorable" trades (reason in this example related to gifted gold) HOT 11
- Unique stopped working, +1 HOT 2
- AutoEndturn bypassed Disabled Auto Build roads Option HOT 2
- Cannot enter Game in 4.12.12 in Android HOT 3
- Barbarian encampments appearing on map, even without Honor selected HOT 3
- Mod checker objecting to acceptable mapUnitFilter combinations
- Выдает ошибку HOT 1
- Feature request: option to disable animations
- Instant crash after update to 4.12.12 - SOLVED with 4.12.12-patch1 HOT 2
- Cannot buy buildings with other stats
- Feature request: Change Difficulty in Console
- Religion Buildings and Units Not Building HOT 1
- Force calculations getting massively screwed up in Wakanda mod
- Nation portraits are not working
- Crash, message copy/pasted
- crash
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unciv.