xyb3rt / sxiv Goto Github PK

I can't find a problem with your code, the XEvents are picked up fine, the image offsets are applied properly and it's rendered with those offsets. Perhaps it's imlib? I'm using imlib2 1.4.5-2

I tried a git bisect to locate the commit bit I ran into problems:

Some good revs are not ancestor of the bad rev.
git bisect cannot work properly in this case.
Maybe you mistake good and bad revs?

Which is unfortunate.

I'm willing to figure out the bug myself if you can point me in the right direction.
Thanks

With

sxiv -b foo

The status bar if briefly seen during the transition from the windowed state to the fullscreen state.

I'd like to change the background color of the fullscreen mode.

'previous image' is bound to 'p' and 'BackSpace' by default and I'd like to bind it to 'Shift-space'.

Steps to reproduce:
Dowload the following image:
http://cl.ly/AyEW
Then:
sxiv canvas.png
Hit 'f', then 'w' and at last 'j': the image moves down.

It's awesome to find an image viewer that animates GIFs and isn't bloated! To finish off this great app's support, it'd be great to see GIF looping. Maybe shift+R (for 'toggle repeat') would work?

To reproduce: sxiv -Zfr .
Then, hit + a few times (might be optional).
Turn antialias off.
Call an external it_shell_cmd command.
When the command completes, antialiasing is re-enabled.

I noticed that while sxiv loads thumbnails, only the 'Loading... x/y' message is shown in the status bar: I have to toggle to image mode to see the file infos.

I use XMonad and when I have the next window "float" out of tiling, sxiv will pop up in the center of my two (identical) screens if focus is on the left and if focus is on the right, it shows up with the right half off the screen. Not sure what sxiv needs from X to know where to pop up. Most apps tend to just get it right. Maybe sxiv is trying some geometry stuff that gets mixed up with tiling?

In image mode, when the bar is visible, if I switch to fullscreen, I can see an artifact of the bar above itself.

Screencast:
http://ge.tt/15VJnNB/v/51

The address given in the man page is missing the 's' of 'https'.

sxiv Makefile should support DESTDIR
http://www.gnu.org/prep/standards/html_node/DESTDIR.html

Here it is:
http://cl.ly/Bjzz/clipfoo

To get into trouble, just run 'sxiv clipfoo'.

Please, consider to append image numbers to thumbnails grid. With large grid it could help to navigate to specified thumbnail more faster with G count, if destination`s count is visible.

Hi
I use musca as window manager. When I open an image with sxiv, it doesn't get resized right. Let me show you an example:
This is what it looks like http://i53.tinypic.com/favlt1.png
and this is what it should look like http://i54.tinypic.com/2v0h66q.png
When I open more images in a row, e.g. sxiv *.jpg, then the first image is being displayed wrong, but as soon as I switch to another one, that one gets resized correctly. After that every image is being displayed correctly. But as soon as I change the size of the aria sxiv is allowed to take (e.g. switch to fullscreen), it starts all over again.

I hope you understand what I'm saying. I haven't tried other window managers so far, right now I only have musca on my laptop. If it help, I could try out more if you want me to.

Besides that, really great image viewer!

I wanted to flip an image vertically but I only see rotate commands in the manual...

gifview can't play it correctly neither but uzbl-browser can.

http://cl.ly/AsjR/

hey there, love the latest version.

have you thought about a tagging feature?

i'm thinking XK_t invokes dmenu with an existing (already used) tags, and once selecting the tag, it gets embedded in the image itself using exiv2 or something.

From image mode, slideshow does not begin on pressing s.
doing
cat config.h | grep -i xk_s
shows that slideshow is not defined
adding in the line
{ true, XK_s, i_toggle_slideshow, (arg_t) None},
gives the error
main.o:(.rodata+0x1b8): undefined reference to `i_toggle_slideshow'
on make

May I ask for such a feature?

Hi,

suppose you have these two files in the current directory:

• TODO - a text file
• pic.jpg - some picture
  after running sxiv -n 2 TODO pic.jpg sxiv shows [2/2]... in the title. After pressing Enter key sxiv switches to thumbnail mode and shows only one thumbnail like it should, but now title contains [2/1]... and no thumbnail is selected (one needs to use j and h keys until current file number is less than file count).

Hey,

first of all I'd like to thank you (Danke!) for the simple (from a user's pov) but great piece of software!

How about adding a key to copy the (full) file path of the currently opened image in window mode (or the focused/selected image in thumbnail mode)?

I think this would prove very useful if you occasionally want to edit the file or use it anywhere else. In conjunction with the fast thumbnail mode this might even give the little extra.

I am sorry if I violated any rule or missed anything relating the feature request.

Best regards,
qwertzix

Is support for animated images planned? Not sure what bindings would make sense. p for "play once" and P for "loop" with either one pausing/resetting the image if it's already animating?

Running xprop WM_CLASS on sxiv returns:
WM_CLASS(STRING) = "sxiv", "sxiv"

It should be:
WM_CLASS(STRING) = "sxiv", "Sxiv"

instead.

sxiv should have an icon, to identify itself better. For example this is a capture of Gnome shell showing sxiv opened.

http://i.imgur.com/CcTav.png

Looks awful, right?

It would be nice to do "sxiv -D some/dir/with/images" instead of "sxiv some/dir/with/images/*".

http://cl.ly/B1y1

Steps to reproduce:
sxiv -Zfr
(On a directory containing large images.)
Hit 'w', then space: the zoom level is not restored to 100%.

I was wondering what was the default image moving increment as I don't see any relevant argument passed to it_move.
(I would like to be able to move the image by 1 px increments.)

The following GIF doesn't play well:
http://cl.ly/AqTi

I would be nice to have a way to call a user script with multiple images passed as arguments.
At the moment, only the currently viewed image can be acted on.

sxiv doesn't show the full path it received as arguments but just the file names, hence, there's no way of knowing where the files belong.

Please add the SVG support. I'm not actually sure about the proper way of getting this done, as long as imlib2 doesn't support SVG currently...

In a tiling window manager (XMonad here), sxiv sometimes becomes a 1x1 or 1xN window when focus is gained or lost. flipping focus around can get it to be the proper size again.

It would be nice to have the keys "HJKL" scroll all the way to the respective edge.

It could be useful to be able to scroll to the next or previous set of thumbnails filling the current window.

When an image is smaller than the thumbnail, the resulting thumbnail is blurry, it would be convenient not to use smoothing here, or to provide a setting to disable it.

I'd like to have an option to have the status bar hidden when sxiv is started.

I'm wondering if tagging isn't necessary after all.
To indicate a tagged image, an inner border could be drawn on the image/thumbnail.
Then shell command would be run in sequence, by passing each tagged image as argument successively.

I use sxiv to view images and to read comics (a directory with about 40 images).
I discovered it yesterday and I already like it very much.

I have one suggestion.
The default behaviour of space key is perfect to view images but a bit annoying when reading comics.
I would prefer the following behaviour

1. if you are at the bottom of the page go to next image
2. else go to the bottom (or better scroll one page)
   It's the default behaviour of many pdf viewers.

Moreover I don't think it would be annoying when we only look at images (else we could also use another key, pagedown for instance).

What do you think of this suggestion? Do you think it is easy to implement?

Remark 1: I know we can use a combination of space and J but I would prefer one key.
Remark 2: Is it the right place to post suggestion? Or is this section intented for bug report?

Thanks for this great work!

This non-image should be discarded but it isn't:

http://cl.ly/BvTs/jadzia.txt

I would like to have a command to refresh the file list (i.e. to remove non existent files from it).

When compiling main.c, gcc complains about select() and accompanying macros (FD_*), which on OpenBSD are defined in <sys/select.h>. Should this be included in main.c?

It seems sxiv doesn't like that GIF:
http://i.imgur.com/i1fcf.gif

I thought it would be important to be able to sort images on the fly.

I'm proposing the following approach:

Provide a command that would provide a script the current list of images being handled as a list of newline separated absolute paths to the its stdin and read back the modified list on the its stdout.

For example, the following script would eliminate non-existent files:

#! /bin/dash

xargs ls -1d 2> /dev/null

And this script would sort files by size:

#! /bin/dash

xargs ls -1dS

What about a key to fit image to window width ?
I suggest

• key 'w' to fit to width
• key 'z' to fit to window size
  (as xpdf)
  As with the current fit to window size, I would prefer the change to be global (not only for the current image).

I also notice that zooming is local to the image so when we change of image (with space) we return to the default zoom.
It's certainly what we want most of the time. But sometimes, we would prefer to zoom globally (when reading A4 scanned pages for example). Could we have 2 keys, one for local zoom and one for global zoom?

Thanks for your fast answers.

I don't know if this is something you'll want to change upstream, but the BSD version of find doesn't support the -delete option. In the thumbnail caching section in the manpage, for it to work, the appropriate command would look something like find . -type d -empty -print0 | xargs -0 rmdir.

Correction: the above doesn't have the same results. This should do it correctly:
find . -depth -type d -empty ! -name '.' -exec rmdir {} ;

I know its a bit uglier. I have it patched in the openbsd port that way.

Something like feh does: http://feh.finalrewind.org/screenshots/exif.jpg
Feh uses '--info' parameter to display any info (e.g EXIF) in a customizable way, and it would be great to get the same wtih sxiv.