wowlegacycore / hermesproxy Goto Github PK

View Code? Open in Web Editor NEW

297.0 297.0 95.0 6.22 MB

A World of Warcraft connection Proxy for VMaNGOS & CMaNGOS.

License: GNU General Public License v3.0

C# 100.00% Batchfile 0.01%

hermesproxy's People

Contributors

Stargazers

Watchers

Forkers

ratkosrb theghostgroup dude100 kittnz ryancheung lihvar freadblangks waterj jameyboor vermillion-excl kelbren herrtrigger insunaa 0blu drkittens talamortis conan513 qyh214 zmoli775 yangyitzzg ellafoxpaw mako666 fiyingphoenix noisiver kelno theghostdev1 den13501 delowong chad90b wanliqiaoxi fancyjohnnyz jilinge2 dramacydal lyrl 3d-hctech chenmins liming802232 future-yaya fangshun2004 jerrytt bmjoy jonnyzcy aionroy nino171 linecode micnovic fargo315 zelazrgn seveeleve miphalol miphalolx wowdarklym zyfei veserine shmilyzxt yishanyishanliangjingjing iiibbbmmm dekadence sliderbeen lsjtcdxp huahuacn don-jin iprofessorz wibeltran captain-red-beard gmh5225 eegles juggalo187 chyiyang ericssm gutoukuaiken neto-wow pinkuburu xiejin101 wtxpwh mmikosu 171497767 nietzschex dongkui555 pkllong wolone bloodeyedzhang shudza fengxing

hermesproxy's Issues

not showing res button near my corpse after dead

Game ver 1.12 with 1.14 client
not showing res button near my corpse after dead,
relogin can't fix it.
can res at graveyard or login with 1.12 client.

[Vanilla] Multiple item sended by main will cause crash

2 item sended correctly, in two different letter, but 3 causes crash, and the 3rd item wont be sent.

when the character gets new quest items, he will be forced to log off

QUERY_PET_NAME GetEntry() off by one

Somehow QUERY_PET_NAME is off by one in ClassicEra when a pet is just tamed?
Causing pets to be named "Unknown".

It seems that for all other functions GetEntry() is correct.
Did not test it on TBC.

To reproduce:

vMangos
.npc tame

Creating temporary transport object causes Proxy to crash

vMangos
.gob tmp 176080 // Creates deeprun tram
.gob tmp 11899 // Creates thousand needles elevator

Chain of events:

HandleCompressedUpdateObject
HandleUpdateObject
> CreateObject1/2
3.1 new ObjectUpdate(...)
3.1.1 guid.GetObjectType() returns Conversation (because of HighGuidType?) and therefore GameObjectData is not filled
ReadCreateObjectBlock
ReadValuesUpdateBlockOnCreate
StoreObjectUpdate
> updateData.GameObjectData.CreatedBy = GetGuidValue(...)
7.1 updateData.GameObjectData is null and causes exception

Unable to Buff NPC's Using 1.14 Client

Describe the bug
I tested this with just Arcane Intellect but it might be all buffs. I can buff NPC's using the 1.12 client but in 1.14 it just casts it on myself even though I have the friendly NPC selected. In this case I'm in the human starting area trying to cast it on Marshall McBride as a test. I tried it on a few others in the area as well with the same problem.

Game Server
1.12 vmangos

Hermes Proxy Version
Version 2022-06-05 3.0.1+38(6bd29ee)

Can you package the Arctium WoW Launcher as a separate exe

[Vanilla] After reaching the flight point, with flight taxi, cannot move

After the flight, moving is not possbile, hermes proxy throws the following:

Collision height is not recalculated on mount/dismount

On 2.4.3 these calculations were probably done clientside, so there was no need to update collision height for player models.
With 2.5.x the client needs to be told the character's collision height explicitly every time that it changes.

Currently this leads to characters that log in while mounted never fitting through doorframes, even after dismounting, while characters that log in dismounted fitting through any doorframe, even when mounted.

I tend to believe that this is something that requires serverside intervention to get done properly.
CMaNGOS for example already has a GetCollisionHeight() function in Unit.cpp so we can already calculate that value, we just don't seem to be transmitting it yet (because the 2.4.3 client has no such opcode afaik)

We can fake it by hijacking the DISMOUNT and MOUNT CMSG/SMSGs and sending "sensible" default values. This will obviously not be perfect, but it should eliminate some trouble that currently occurs

Dead (Spirit) State makes entering world unrecheable

GameVer: 1.14
Proxy: Latest published (not compiled)
Server: CMANGOS builded from sources dated ATM

Steps to reproduce: Die, logout,, try to enter world
Expected behaviour: The spirit state is shown at the char selection, but its not. You can enter world, but you can''t

Support for Wotlk 3.4

Please add support for the latest version of wotlk classic. I have been logging into this repository almost every day since wotlk classic was released to see if there is any movement, sadly there is not. I would love to support the development but I have no C# skills whatsoever.
Is there any other way to support?

Entering world from WAN\LAN is dropping connection

CMANGOS Ver: Latest compiled from sources
GameVer: 1.14.0 (40618)
Proxy: Last Released (not compiled)

Tryied to connect to dedicated CMANGOS server on VDS (WAN)
Tryied to connect through LAN from one computer to another

Login is working, char creation is working, but after pressing "Enter World" it tries to cennect 5 times and then disconnects, also Hermes is going in loop with

Moreover if I try to connect from server-PC with 127.0.0.1 it works as it should. By dedicated or LAN network by subnet 192.168.x.x - not

Hermes config looks for 192.168.x.x and it works till entering world

21:12:41 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).

Full Log:

21:12:25 | Server  | Server | Hello from Hermes Proxy!
21:12:25 | Server  | Server | Compiled on 05/27/2022 04:57:26.
21:12:25 | Storage | GameData | Loading data files...
21:12:25 | Server  | VersionChecker | Loaded 833 legacy opcodes.
21:12:25 | Server  | VersionChecker | Loaded 1640 modern opcodes.
21:12:25 | Storage | GameData | Finished loading data.
21:12:25 | Server  | Server | Starting REST service...
21:12:25 | Network | NetworkThread | Network Thread Starting
21:12:25 | Server  | Server | Starting Realm manager...
21:12:25 | Server  | RealmManager | Added realm "Sandbox" at 127.0.0.1:8084
21:12:25 | Server  | Server | Starting Login service...
21:12:25 | Server  | Server | BNet Listening on 0.0.0.0:1119...
21:12:25 | Network | NetworkThread | Network Thread Starting
21:12:25 | Server  | Server | World Listening on 0.0.0.0:8084...
21:12:25 | Network | NetworkThread | Network Thread Starting
21:12:29 | Server  | Session | Accepting connection from 127.0.0.1:55152.
21:12:29 | Network | AuthClient | Connecting to auth server...
21:12:30 | Network | AuthClient | Authentication succeeded!
21:12:30 | Network | AuthClient | Received 1 realms.
21:12:30 | Server  | RealmManager | Added realm "Test" at 192.168.88.100:8085
21:12:31 | Network | WorldSocketManager | Instance socket open.
21:12:31 | Server  | WorldSocket | WorldSocket:HandleAuthSession: Client 'testC' authenticated successfully from 127.0.0.1:55163.
21:12:31 | Network | WorldClient | Connecting to world server...
21:12:31 | Network | WorldClient | Connection established!
21:12:31 | Network | WorldClient | Authentication succeeded!
21:12:31 | Warning | WorldSocket | No handler for opcode CMSG_GET_UNDELETE_CHARACTER_COOLDOWN_STATUS (14052)
21:12:31 | Warning | WorldSocket | No handler for opcode CMSG_BATTLE_PAY_GET_PURCHASE_LIST (14018)
21:12:31 | Warning | WorldSocket | No handler for opcode CMSG_BATTLE_PAY_GET_PRODUCT_LIST (14017)
21:12:31 | Warning | WorldSocket | No handler for opcode CMSG_UPDATE_VAS_PURCHASE_STATES (14072)
21:12:31 | Error   | AuthClient | Socket Closed By Server
21:12:31 | Warning | WorldSocket | No handler for opcode CMSG_BATTLENET_REQUEST (14074)
21:12:32 | Warning | WorldSocket | No handler for opcode CMSG_GET_ACCOUNT_CHARACTER_LIST (14012)
21:12:33 | Warning | WorldSocket | No handler for opcode CMSG_BATTLE_PAY_GET_PURCHASE_LIST (14018)
21:12:34 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:34 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:34 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:35 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:35 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:35 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:35 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:35 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:36 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:36 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:36 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:36 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:36 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:37 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:38 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:38 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:38 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:38 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:38 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:38 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:38 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:38 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:38 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:39 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:39 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:39 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:39 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:39 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:40 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:40 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:40 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:40 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:40 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:41 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:41 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:41 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:41 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:41 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:42 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:42 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:42 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:42 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:43 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:43 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:43 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:43 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:43 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:44 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:44 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:44 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:44 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:44 | Error   | WorldSocket | Failed to connect 5 times to world socket, aborting login
21:12:44 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:44 | Warning | WorldSocket | No handler for opcode CMSG_GET_UNDELETE_CHARACTER_COOLDOWN_STATUS (14052)
21:12:44 | Warning | WorldSocket | No handler for opcode CMSG_BATTLE_PAY_GET_PURCHASE_LIST (14018)
21:12:44 | Warning | WorldSocket | No handler for opcode CMSG_BATTLE_PAY_GET_PRODUCT_LIST (14017)
21:12:44 | Warning | WorldSocket | No handler for opcode CMSG_UPDATE_VAS_PURCHASE_STATES (14072)
21:12:45 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:45 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:45 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:45 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:45 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:46 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:46 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:46 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:46 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:46 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:47 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:47 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:47 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:47 | Server  | WorldSocket | Client disconnected with reason 14.
21:12:47 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:47 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:48 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:48 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:48 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:48 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:48 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:49 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:49 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:49 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:49 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:49 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:50 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:50 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:50 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:50 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).
21:12:50 | Network | WorldClient | Waiting to send SMSG_LOGIN_VERIFY_WORLD (9626).

And another try:

Becoming cc'd while changing warr stances

Had a bug where I changed from battle to berserker stance and got cc'd right as I did, but I was in berserker stance but still had my battle stance bar with all of my battle stance abilities instead of my berserker rage abilities.

I don't know if it is because of my relatively high ping (150+ from na).

please take a look at the github link below-thank you

Describe the bug
xod-wow/LiteButtonAuras#9

Game Server
Everlook

Hermes Proxy Version
HermesProxy Windows 23-06-2022

Sending more gold via mail than on player works (but gold is set to 0)

Describe the bug

Go to mail box
Your own character just has 1 gold or so
Send 999 gold to another player
Red message pops up that you don't have enough money but the mail is still sent
Only 30 copper were removed

The classic clients seems to send the message with 0 gold(?).

HermesProxy/HermesProxy/World/Server/PacketHandlers/MailHandler.cs

Line 119 in 0666a04

packet.WriteUInt32((uint)mail.SendMoney);

Game Server
vmangos 7e881d27cd8574603d33fef74ce55ccc5550a508

Hermes Proxy Version
2022-06-04 3.0.1+36

is TBC playable?

You can login, create character, start walking. And that's all. Can't talk to npcs, cast spells on mobs and etc.

Deeprun Tram wrong direction on vMangos

Is this related to vMangos or Hermes Proxy?
https://www.youtube.com/watch?v=uflKw2aZkME

TBC is still buggy

Stealth and Levitate animation does not display when idling.

Some movement flags or opcodes don't seem to be translated or transmitted correctly. I haven't been able to find the cause of this issue yet, so I'm opening this github issue in the meantime.

To test this: Cast Levitate on yourself, notice that instead of the floating idle animation you are just further up in the air using the ground-standing idle animation.
Create a rogue and use Stealth and notice that you remain in the regular idle animation, not the sneaking idle animation. Movement sneak works as expected, idle does not.

Tested on CMaNGOS with 2.5.2 Client

New packet debug log format?

Can I implement a new debug log format?

The current debug format is a bit hard to read and requires a little bit of thinking

16:35:57 | Debug   | WorldClient | Received opcode SMSG_UPDATE_OBJECT (169).
16:35:57 | Debug   | WorldSocket | Sending opcode SMSG_UPDATE_OBJECT (10178).
17:35:58 | Debug   | WorldSocket | Received opcode CMSG_TALK_TO_GOSSIP (13458).
17:35:58 | Debug   | WorldClient | Sending opcode CMSG_TALK_TO_GOSSIP (379) with size 12.
17:35:58 | Debug   | WorldClient | Received opcode SMSG_GOSSIP_MESSAGE (381).
17:35:58 | Debug   | WorldSocket | Sending opcode SMSG_GOSSIP_MESSAGE (10904).

the new format would look like this:

16:35:57 | Debug   | C P<S | Received opcode SMSG_UPDATE_OBJECT (169).
16:35:57 | Debug   | C<P S | Sending opcode SMSG_UPDATE_OBJECT (10178).
17:35:58 | Debug   | C>P S | Received opcode CMSG_TALK_TO_GOSSIP (13458).
17:35:58 | Debug   | C P>S | Sending opcode CMSG_TALK_TO_GOSSIP (379) with size 12.
17:35:58 | Debug   | C P<S | Received opcode SMSG_GOSSIP_MESSAGE (381).
17:35:58 | Debug   | C<P S | Sending opcode SMSG_GOSSIP_MESSAGE (10904).

C = Client, P = HermesProxy, S = Server

The old class can stay in the log if you want.

16:35:57 | Debug   | WorldClient | C P<S | Received opcode SMSG_UPDATE_OBJECT (169).

Can't compile the source code

I have tried to compile the source code and i haven't touched anything and I'm getting this error.

InventoryResults do not match

The InventoryResults enum has an Element (29) in HermesProxy / New Client that does not exist in the old clients/servers
This causes inventory results >= 29 to be off by one

The solution should be to increment every InventoryResult by 1, if the InventoryResult we get from the server is 29 or higher.

Game Server
CMaNGOS TBC (But I checked the VMaNGOS source, and the enum does not contain this result either)

Hermes Proxy Version
2022-06-05 3.0.1+41(5a6263e) dirty

ClassicTBC WOW51900319 error

After use Tawny Windrider i get (WOW51900319) error. Possible to fix, please?
Server: Sunstrider "logon.sunstrider.gg"
Realm: Shadowmoon

TOTP doesn't work (2FA support)

Trying to log in with TOTP enabled always yields "Wrong Username or Password" or unknown account in console output.

Game Server
CMaNGOS TBC

Hermes Proxy Version
3.0.1+41(5a6263e) dirty

Looting objects

Dunno if this happens with other objects, but was doing the quest that requires u to collect 10 incendia agave in thousand needles.

And it sometimes it required quite a bit of clicking to get it to properly loot the object on classic client.

Freewind post elevator

Logged in with 2 accs, one on classic and other on 1.12

Noticed that when on 1.12 the elevator is up its down on classic and vice versa.

Abilities not always showing up

Abilites not always showing up on login and have to relog to fix.

theyr not showing up anywhere in spellbook or action bars.

How to download the （ versions 1.14.0 and 2.5.2） client

thank you very much for your efforts.

How to download the （ versions 1.14.0 and 2.5.2） client ， if I try to connect from server-PC with 127.0.0.1 how to using Hermes config

Looting something causes an Error from time to time: WorldClient | Packet Read Error: Nullable object must have a value.

First of all, great project!

I get this error from time to time when I am looting something. I'm using auto loot from the client and faster auto loot from LeatrixPlus.
WorldClient | Packet Read Error: Nullable object must have a value.
17:28:37 | Error | WorldClient | Packet Read Error: Nullable object must have a value. at HermesProxy.World.Client.WorldClient.HandleItemPushResult(WorldPacket packet) in C:\Users\<>\Source\Repos\HermesProxy2\HermesProxy\World\Client\PacketHandlers\ItemHandler.cs:line 34 at HermesProxy.World.Client.WorldClient.HandlePacket(WorldPacket packet) in C:\Users\<>\Source\Repos\HermesProxy2\HermesProxy\World\Client\WorldClient.cs:line 387 at HermesProxy.World.Client.WorldClient.ReceiveCallback(IAsyncResult AR) in C:\Users\<>\Source\Repos\HermesProxy2\HermesProxy\World\Client\WorldClient.cs:line 189

Modern Client Functionality / Opcode Support

Is there a possibility that HermesProxy will eventually support custom opcodes?

I personally am in favor of custom opcodes, to make better use of the functionality of the newer clients. The new clients support many things, such as the Threat API, the Quest Completion API, more detailed information about some types of data, etc.

IMO such an addition should not interfere at all with servers that do not support the custom opcodes.
We've partially talked about this in my Threat API pull request draft. (#44)

It should be very possible to build a system that can query a server which supports custom (but well defined) opcodes about which custom opcodes it implements and which ones HermesProxy implements, so that a consensus between Hermes and the Server is reached which opcodes Hermes or the Server can process, so that only these opcodes are actually sent.

This would of course require a small protocol to be developed and standards to be set such that those custom opcodes don't get out of hand.

Telredor elevator

Hey Telredor elevator not working properly with TBC classic. - The horizontal movement happens in the wrong direction.

No handler for opcode CMSG_WRAP_ITEM (14740)

Describe the bug

.additem 5042 (Wrapping Paper)
.additem 873 (Some random useless item)
Use Wrapping Paper on Item
Does not wrap item <.<

Game Server
vmangos 7e881d27cd8574603d33fef74ce55ccc5550a508

Hermes Proxy Version
2022-06-04 3.0.1+37

Custom Items don't show info, stats or name

Describe the bug
Custom items don't show their name, icon, stats, anything except the ID basically, it only says "Retrieving item information" forever.

Game Server
CMaNGOS-TBC

Hermes Proxy Version
6d61a9b

Edit: I believe this should be handled by SMSG_ITEM_QUERY_SINGLE_RESPONSE, which you do implement, but for some reason this isn't working

Login failed. Reason: WRONG_BUILD_NUMBER

Hello Guys,
Sorry to trouble your time, but I really can not found how I can solve this error.
I tried HermesProxy for vmangos repack V20, port 3724 for realmlist, 8085 for mangosd, client 1.14.0 40618 to connection will have below error. may I get your help to known what happened? how can I solve that?

HermesProxy: HermesProxy.Windows.27-05-2022
Arctium WoW Launcher: [Launcher Signed (2022/08/19)] [Windows.x86_64.zip]
Core: VMangos Repack V20

config file setup with:
add key="ClientBuild" value="40618"
add key="ClientSeed" value="179D3DC3235629D07113A9B3867F97A7"
add key="ServerBuild" value="5875"

================Realmd Error=================
Accepting connection from ''
[AuthChallenge] Account 'ADMIN' using IP '' is using 'zhCN' locale (4)
[AuthChallenge] Account ADMIN tried to login with modified client!

the recently updated Arctium, can link to HermesProxy, but cannot log in to the account normally.

I don't know why, I compiled the latest Arctium code, the recently updated Arctium, can link to HermesProxy, but cannot log in to the account normally. I do not know why.
The link file package provided on YouTube, Arctium has nearly 200 files, it is very messy, I downloaded the new standalone Arctium and can't log in to the account.

Authentication failed for account

I followed the instructions step by step, and finally the authentication failed when logging in to the server. Can you help me solve this problem?

No connection could be made because the target machine actively refused it

Hello!
Used WoW 1.14.0 (40618)
Downloaded release from here, changed the client.WTF portal to 127.0.0.1
The server refuses to login me

Tried to pull sources and change some strings, etc. for 1.14.3 and used the most updated official client, the same problem.. :(
Checked firewall, network configurations, port is open, applications (both client and server) are trusted

Domain name in Realmlist

(Feature Request) Add MacOs support pls

I love to play vanilla and future wotlk servers. There is no way to play on m1 chips now.

Can we log in using a different client, such as 1.14.3 or 2.5.4?

1.14 classic

need to handle latest Classic client V44403

HermesProxy do not handle client 44403

I tried with no success (LogonChallenge fail leading to answer user do not exist) by adding enum for version 44403

probably the seed is not valid for client 44403 or I missed something

portion of code in authClient.cs line 412:
AuthResult error = (AuthResult)packet.ReadUInt8();
if (error != AuthResult.SUCCESS)
{
Log.Print(LogType.Error, $"Login failed. Reason: {error}");
SetAuthResponse(error);
return;
}

Random logout through the error in Proxy

WoW Ver: 1.14.0 (40618)
ProxyVersion: The most fresh version from GitHub

I was in party with bot, so ranndomly the game logged out with the output of proxy below

[Vanilla] Can only choose neighbour flight points

When trying to flight further, hermes proxy throws the following error, and flying is not possible:
Trying to find from Western Plaugelands / Chillwind Camp to Arathi, Refugee pointe:

[Vanilla] ships and zeppelins not appearing.

Following errors are thrown, and the zeppelins and transport ships not appear in the game, using the classic client.

ort/0 R0/S0 Map: 2560 Low: 5
14:31:47 | Error   | UpdateHandler | Broken create1 without position for Full: 0x18000140000000000000000000000000 Transport/0 R0/S0 Map: 2560 Low: 5
14:31:57 | Error   | UpdateHandler | Broken create1 without position for Full: 0x18000040000000000000000000000000 Transport/0 R0/S0 Map: 512 Low: 1
14:32:34 | Error   | UpdateHandler | Broken create1 without position for Full: 0x18000080000000000000000000000000 Transport/0 R0/S0 Map: 1024 Low: 2

Sharpening Stones are missing visual effect which applies to weapons

Describe the bug
When using the 2.4.3 client, Sharpening Stones will add a light effect to weapons, but in the 2.5.2 client with proxy the effect gone.

Game Server
2.4.3

Hermes Proxy Version
all versions

Mobs of quest "Ferocitas the Dream Eater" are not shown as killed and the quest not marked as completed

Describe the bug
Mobs of quest "Ferocitas the Dream Eater" are not shown as killed and the quest not marked as completed

Using 1.12.1: The mobs are shown as killed and marked 7/7 in the quest log and the quest is completed:

Using 1.14.0: The mobs are not shown and marked 0/7 in the quest log and the quest is not completed:

(This screenshot has been taken after the 1.12.1 screenshot!)

Game Server
I am running my vmangos 0aa048d (newest commit, build at 2022.07.15)

Hermes Proxy Version
(compiled manually)
Version 2022-06-12 3.0.1+50(6d61a9b)

Here is the Hermes Proxy output. During the session i logged in using the 1.12.1 client to create the above screenshot

21:35:44 | Server | Server 21:35:44 | Server | Server 21:35:44 | Storage | GameData 21:35:44 | Server | VersionChecker 21:35:44 | Server | VersionChecker 21:35:44 | Storage | GameData 21:35:44 | Server | Server 21:35:44 | Network | NetworkThread 21:35:44 | Server | Server 21:35:44 | Server | Server 21:35:44 | Network | NetworkThread 21:35:44 | Server | Server 21:35:44 | Network | NetworkThread 21:35:54 | Server | BnetTcpSession 21:35:54 | Network | AuthClient 21:35:54 | Network | AuthClient 21:35:54 | Network | AuthClient 21:35:54 | Server | RealmManager 21:35:54 | Network | WorldSocketManager 21:35:54 | Server | WorldSocket 21:35:54 | Network | WorldClient 21:35:54 | Network | WorldClient 21:35:55 | Network | WorldClient 21:35:55 | Warning | WorldSocket 21:35:55 | Warning | WorldSocket 21:35:55 | Warning | WorldSocket 21:35:55 | Warning | WorldSocket 21:35:55 | Error | AuthClient 21:35:55 | Warning | BnetServices 21:35:56 | Warning | WorldSocket 21:35:57 | Network | WorldSocketManager 21:35:57 | Server | WorldSocket 21:35:57 | Warning | WorldSocket 21:35:57 | Warning | WorldSocket 21:35:57 | Warning | WorldClient 21:35:57 | Warning | WorldSocket 21:35:57 | Warning | WorldSocket 21:35:57 | Warning | WorldSocket 21:35:57 | Warning | WorldSocket 21:35:57 | Warning | WorldSocket 21:35:57 | Warning | WorldSocket 21:35:57 | Warning | WorldSocket 21:35:57 | Warning | WorldSocket 21:35:57 | Warning | WorldSocket 21:35:58 | Warning | WorldSocket 21:36:08 | Warning | WorldSocket 21:36:08 | Warning | WorldSocket 21:45:57 | Warning | WorldSocket 21:51:47 | Error | WorldClient 21:52:22 | Server | BnetTcpSession 21:52:23 | Network | AuthClient 21:52:23 | Network | AuthClient 21:52:23 | Network | AuthClient 21:52:23 | Server | RealmManager 21:52:23 | Network | WorldSocketManager 21:52:23 | Server | WorldSocket 21:52:23 | Network | WorldClient 21:52:23 | Network | WorldClient 21:52:23 | Network | WorldClient 21:52:23 | Warning | WorldSocket 21:52:23 | Warning | WorldSocket 21:52:23 | Warning | WorldSocket 21:52:23 | Warning | WorldSocket 21:52:23 | Error | AuthClient 21:52:23 | Warning | BnetServices 21:52:25 | Warning | WorldSocket 21:52:25 | Network | WorldSocketManager 21:52:25 | Server | WorldSocket 21:52:25 | Warning | WorldSocket 21:52:25 | Warning | WorldSocket 21:52:26 | Warning | WorldClient 21:52:26 | Warning | WorldSocket 21:52:26 | Warning | WorldSocket 21:52:26 | Warning | WorldSocket 21:52:26 | Warning | WorldSocket 21:52:26 | Warning | WorldSocket 21:52:26 | Warning | WorldSocket 21:52:26 | Warning | WorldSocket 21:52:26 | Warning | WorldSocket 21:52:26 | Warning | WorldSocket 21:52:26 | Warning | WorldSocket 21:52:27 | Warning | WorldSocket 21:58:06 | Warning | BnetServices 22:02:26 | Warning | WorldSocket 22:06:53 | Warning | WorldClient | Starting Hermes Proxy...
| Version 2022-06-12 3.0.1+50(6d61a9b)
| Loading data files...
| Loaded 833 legacy opcodes.
| Loaded 1639 modern opcodes.
| Finished loading data.
| Starting REST service...
| Network Thread Starting
| Starting Login service...
| BNet Listening on 0.0.0.0:1119...
| Network Thread Starting
| World Listening on 0.0.0.0:8084...
| Network Thread Starting
| Accepting connection from 127.0.0.1:51997.
| C P>S | Connecting to auth server...
| Authentication succeeded!
| Received 1 realms.
| Added realm "vmangos" at 127.0.0.1:8085
| Instance socket open.
| WorldSocket:HandleAuthSession: Client 'THORSTEN' authenticated successfully from 127.0.0.1:52001.
| Connecting to world server...
| Connection established!
| Authentication succeeded!
| No handler for opcode CMSG_GET_UNDELETE_CHARACTER_COOLDOWN_STATUS (14052)
| No handler for opcode CMSG_BATTLE_PAY_GET_PURCHASE_LIST (14018)
| No handler for opcode CMSG_BATTLE_PAY_GET_PRODUCT_LIST (14017)
| No handler for opcode CMSG_UPDATE_VAS_PURCHASE_STATES (14072)
| C P<S | Socket Closed By Server
| [WorldSocket][127.0.0.1:52001, Account: THORSTEN, Game account: THORSTEN] Client requested service ResourcesService/m:1 but this service is not implemented?
| No handler for opcode CMSG_BATTLE_PAY_GET_PURCHASE_LIST (14018)
| Instance socket open.
| Client has connected to the instance server.
| No handler for opcode CMSG_VIOLENCE_LEVEL (12680)
| No handler for opcode CMSG_QUEUED_MESSAGES_END (14188)
| No handler for opcode SMSG_SET_REST_START (542)
| No handler for opcode CMSG_REQUEST_CATEGORY_COOLDOWNS (12673)
| No handler for opcode CMSG_QUERY_QUEST_COMPLETION_NPCS (12664)
| No handler for opcode CMSG_REQUEST_FORCED_REACTIONS (12807)
| No handler for opcode CMSG_QUERY_COUNTDOWN_TIMER (12715)
| No handler for opcode CMSG_LFG_LIST_GET_STATUS (13836)
| No handler for opcode CMSG_CALENDAR_GET_NUM_PENDING (13948)
| No handler for opcode CMSG_BATTLE_PET_REQUEST_JOURNAL (13861)
| No handler for opcode CMSG_GUILD_SET_ACHIEVEMENT_TRACKING (12399)
| No handler for opcode CMSG_GM_TICKET_GET_CASE_STATUS (13967)
| No handler for opcode CMSG_REQUEST_CEMETERY_LIST (12665)
| No handler for opcode CMSG_QUERY_QUEST_COMPLETION_NPCS (12664)
| No handler for opcode CMSG_QUERY_QUEST_COMPLETION_NPCS (12664)
| No handler for opcode CMSG_GM_TICKET_GET_CASE_STATUS (13967)
| C P<S | Socket Closed By Server
| Accepting connection from 127.0.0.1:52210.
| C P>S | Connecting to auth server...
| Authentication succeeded!
| Received 1 realms.
| Added realm "vmangos" at 127.0.0.1:8085
| Instance socket open.
| WorldSocket:HandleAuthSession: Client 'THORSTEN' authenticated successfully from 127.0.0.1:52214.
| Connecting to world server...
| Connection established!
| Authentication succeeded!
| No handler for opcode CMSG_GET_UNDELETE_CHARACTER_COOLDOWN_STATUS (14052)
| No handler for opcode CMSG_BATTLE_PAY_GET_PURCHASE_LIST (14018)
| No handler for opcode CMSG_BATTLE_PAY_GET_PRODUCT_LIST (14017)
| No handler for opcode CMSG_UPDATE_VAS_PURCHASE_STATES (14072)
| C P<S | Socket Closed By Server
| [WorldSocket][127.0.0.1:52214, Account: THORSTEN, Game account: THORSTEN] Client requested service ResourcesService/m:1 but this service is not implemented?
| No handler for opcode CMSG_BATTLE_PAY_GET_PURCHASE_LIST (14018)
| Instance socket open.
| Client has connected to the instance server.
| No handler for opcode CMSG_VIOLENCE_LEVEL (12680)
| No handler for opcode CMSG_QUEUED_MESSAGES_END (14188)
| No handler for opcode SMSG_SET_REST_START (542)
| No handler for opcode CMSG_REQUEST_CATEGORY_COOLDOWNS (12673)
| No handler for opcode CMSG_QUERY_QUEST_COMPLETION_NPCS (12664)
| No handler for opcode CMSG_REQUEST_FORCED_REACTIONS (12807)
| No handler for opcode CMSG_QUERY_COUNTDOWN_TIMER (12715)
| No handler for opcode CMSG_LFG_LIST_GET_STATUS (13836)
| No handler for opcode CMSG_CALENDAR_GET_NUM_PENDING (13948)
| No handler for opcode CMSG_BATTLE_PET_REQUEST_JOURNAL (13861)
| No handler for opcode CMSG_GUILD_SET_ACHIEVEMENT_TRACKING (12399)
| No handler for opcode CMSG_GM_TICKET_GET_CASE_STATUS (13967)
| No handler for opcode CMSG_REQUEST_FORCED_REACTIONS (12807)
| No handler for opcode CMSG_REQUEST_CEMETERY_LIST (12665)
| [WorldSocket][127.0.0.1:52214, Account: THORSTEN, Game account: THORSTEN] Client requested service PresenceService/m:3 but this service is not implemented?
| No handler for opcode CMSG_GM_TICKET_GET_CASE_STATUS (13967)
| No handler for opcode SMSG_SPELL_EXECUTE_LOG (588)

Some spells do not display red error text when failing

Trying to fish without a water source in line of sight will fail the fishing spell.
In vanilla this will display a red message at the top.
In the modern client it will not.

SMSG_SPELL_GO will sets CurrentClientNormalCast to null and thus

HermesProxy/HermesProxy/World/Client/PacketHandlers/SpellHandler.cs

Lines 163 to 164 in 77edf93

    
           else if (GetSession().GameState.CurrentClientNormalCast != null && 
        
                   GetSession().GameState.CurrentClientNormalCast.SpellId == spellId)

will fail.

grom'gol>UC zeppelin bugged = trying to step unto zepp in gromgol destination UC causes character to logout and respawn back on platform instead on zepp. repeated disconnect after multiple attempts

Undercity-Grom'Gol zeppelin bugged = trying to step unto zepp causes character to logout and respawn back on platform instead on zepp. repeated disconnect after multiple attempts= happens in both UC and gromgol

Game Server
everlook private server

Hermes Proxy Version
HermesProxy Windows 23-06-2022

Randomize character name results in crash

Describe the bug
When pressing the "Randomize" on character creation screen, the proxy crashes with the following trace:

22:01:44 | Error   | AuthClient | C P<S | Socket Closed By Server
Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.
   at HermesProxy.World.Server.Packets.GenerateRandomCharacterNameResult.Write() in E:\Dev\pvp\HermesProxy\HermesProxy\World\Server\Packets\CharacterPackets.cs:line 1044
   at HermesProxy.World.ServerPacket.WritePacketData() in E:\Dev\pvp\HermesProxy\HermesProxy\World\Packet.cs:line 127
   at HermesProxy.World.Server.WorldSocket.SendPacket(ServerPacket packet) in E:\Dev\pvp\HermesProxy\HermesProxy\World\Server\WorldSocket.cs:line 335
   at HermesProxy.World.Server.WorldSocket.HandleGenerateRandomCharacterNameRequest(GenerateRandomCharacterNameRequest randomCharacterName) in E:\Dev\pvp\HermesProxy\HermesProxy\World\Server\PacketHandlers\CharacterHandler.cs:line 221
   at HermesProxy.World.Server.WorldSocket.PacketHandler.<>c__DisplayClass2_0`1.<CreateDelegate>b__0(WorldSocket target, ClientPacket p) in E:\Dev\pvp\HermesProxy\HermesProxy\World\Server\WorldSocket.cs:line 1106
   at HermesProxy.World.Server.WorldSocket.PacketHandler.Invoke(WorldSocket session, WorldPacket packet) in E:\Dev\pvp\HermesProxy\HermesProxy\World\Server\WorldSocket.cs:line 1096
   at HermesProxy.World.Server.WorldSocket.HandlePacket(WorldPacket packet) in E:\Dev\pvp\HermesProxy\HermesProxy\World\Server\WorldSocket.cs:line 315
   at HermesProxy.World.Server.WorldSocket.ReadData() in E:\Dev\pvp\HermesProxy\HermesProxy\World\Server\WorldSocket.cs:line 304
   at HermesProxy.World.Server.WorldSocket.ReadHandler(SocketAsyncEventArgs args) in E:\Dev\pvp\HermesProxy\HermesProxy\World\Server\WorldSocket.cs:line 208
   at Framework.Networking.SocketBase.ProcessReadAsync(SocketAsyncEventArgs args) in E:\Dev\pvp\HermesProxy\Framework\Networking\SocketBase.cs:line 108
   at Framework.Networking.SocketBase.<.ctor>b__5_0(Object sender, SocketAsyncEventArgs args) in E:\Dev\pvp\HermesProxy\Framework\Networking\SocketBase.cs:line 53
   at System.Net.Sockets.SocketAsyncEventArgs.OnCompleted(SocketAsyncEventArgs e)
   at System.Net.Sockets.SocketAsyncEventArgs.ExecutionCallback(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading._IOCompletionCallback.PerformIOCompletionCallback(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* pNativeOverlapped)

Game Server
vmangos

Hermes Proxy Version

Version 2022-06-06 3.0.1+47(8842ac3)

	else if (GetSession().GameState.CurrentClientNormalCast != null &&
	GetSession().GameState.CurrentClientNormalCast.SpellId == spellId)