Comments (17)
Highly unlikely, I don't see a reason to do this. If you want custom opcodes you would have the knowledge of using TC, patching the client, etc.
from hermesproxy.
@MaxtorCoder
Custom opcodes == Modern client opcodes like thread api, warden3, get-early-off-taxi-button.
Mangos could forward support these opcodes.
from hermesproxy.
I don't see a reason for them to do that honestly, as it is the plan of CMangos to support Legacy clients
from hermesproxy.
Well someone has to lay the groundwork at one end of things, I guess. I can try bothering killerwife and Cyberium until they relent and let me put opcode handlers for some modern client features in, as long as they don't interfere with legacy clients.
They're probably not particularly enthused about it tho, because for some modern opcodes to be in CMaNGOS, there needs to also be Client/HermesProxy support. So, kind of a chicken & egg situation
from hermesproxy.
We should not implement such things unless they are made an official part of cmangos and other emulation projects. Having handlers for opcodes in the main hermes repo that only exist in your own personal fork of the core makes no sense. If it becomes official in cmangos, then we can make it official in hermes. But i can say as the vmangos maintainer, I wouldn't want such things in the core, as the project's goal is to emulate 1.12 vanilla not 1.14 classic.
from hermesproxy.
Exactly, so I don't see this happening, not now and maybe not even in the future.
from hermesproxy.
It can't happen unless one side does the first step, that's true.
The critical point for me imo: Would it hurt HermesProxy in any way to have optional handlers/forwarders for new opcodes?
from hermesproxy.
Of course not, but it's more that the original server would have to support the optional handlers/forwarders for new opcodes.
from hermesproxy.
Well they don't have to. New Opcode support should be optional on all sides and only enabled when agreed upon by both parties.
from hermesproxy.
@insunaa I am pretty sure it will not get accepted in cmangos, I know I would be against it if i was part of cmangos. So we will end up with support for functionality that only exists in insunaa/mangos-classic fork 😆
And in that case the hermes side support should remain in insunaa/HermesProxy as well.
from hermesproxy.
And when I talk with Cyberium and Killerwife about it they'll send me this screenshot and tell me that's why they're not going to support it
from hermesproxy.
I have no say what happens in cmangos. If they decide to add it in cmangos, we can add it to hermes as i said, but otherwise it makes no sense for us to have such custom stuff.
from hermesproxy.
I'll talk to them about it. 👍
from hermesproxy.
I have no idea how modern warden works, but if we don't support WARDEN3
opcodes there will never be a popular vanilla server that supports Hermes. (looking at "Everlook")
from hermesproxy.
I don't think Warden 3 has been reverse engineered and implemented in any public core, but I bet @MaxtorCoder knows for sure.
from hermesproxy.
Warden indeed has not been reverse engineered for modern clients, 4.3.4 is the max reversed client for it
from hermesproxy.
CMaNGOS says no, so I'm closing the issue tentatively.
I'll start a fork of Hermes and CMaNGOS TBC and work on this issue separately.
I need a few weeks to months to get settled into my new job, then I can dedicate some proper time to this.
from hermesproxy.
Related Issues (20)
- winterspringlauncher.exe HOT 1
- How can i play tbc on my macbook m1 ? HOT 1
- Masterlooting Bug - 1.14.0 Client - 1.12 Server HOT 10
- Is it OK to set spelldelay to 0ms? HOT 2
- MacOS can't running.... HOT 1
- about spell and itemset HOT 4
- Relentless strike talent 1 point slice and dice duration without any combo points on the target
- WOW vanilla | incorrect move speed after being slow by opposite faction player HOT 1
- C'thun, Temple of Ahn'Qiraji - Dark glare movement
- Incorrect NPC IDs being sent from server to client in AQ40 HOT 5
- Nefarian fight bug!!
- HERMES PROXY HAS CLOSED! Status: 1
- Arena targeting issue.
- Selling multiple items unintended
- Error | WorldClient | C P<S | Socket Closed By GameWorldServer (payload) HOT 1
- Compiling result in: Login failed. Reason: FAIL_VERSION_INVALID HOT 11
- kicked out from server HOT 2
- Discount with a large number of people.
- 1.14.2 bug regarding relentless strikes (again)
- Who can make a tool to convert DBC to CSV, so that it can be used for some DIY settings? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hermesproxy.