vcvrack / fundamental Goto Github PK

OS (if applicable): OSX 10.11.6
Version (or "dev" if compiling from source): 0.4.0

The highpass output of the standard VCF module does not give a typical highpass response--instead it seems to slightly attenuate the stopband kind of like a shelf EQ, but does not filter it out per se. This becomes even more aberrant with resonance turned up.

Most plugins fail to build with error messages like the following:

src/SEQ3.cpp:109:7: error: ‘void SEQ3::onReset()’ marked ‘override’, but does not override
void onReset() override {
^~~~~~~
src/SEQ3.cpp:115:7: error: ‘void SEQ3::onRandomize()’ marked ‘override’, but does not override
void onRandomize() override {
^~~~~~~~~~~

I'm having a hard time dialing in my desired sequences due to the giant range on the sequencer. I'm wondering if it'd be difficult to add a range limitation, either via a knob or the context menu. This could help make more musical sequences much faster. Even just 1v, 2v, 5v, 8v would be good options I think. I understand patching in an attenuator would help with this, but it can be hard to dial in.

Rack 0.5.1 on Arch Linux.
The graphics stick out over the right edge:

Hi there! Please bear with me, as I am an utter n00b. I just compiled Rack on my KDE Neon 5.11/kxStudio box, and it seems to run.

So I followed the readme instructions for populating the plugins folder, and make fails with this error:

g++ -fPIC -I../../include -I../../dep/include -DVERSION=0.5.1 -MMD -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -Wsuggest-override -std=c++11 -c -o build/src/Mutes.cpp.o src/Mutes.cpp
src/Mutes.cpp:34:7: error: ‘void Mutes::onReset()’ marked ‘override’, but does not override
void onReset() override {
^
src/Mutes.cpp:39:7: error: ‘void Mutes::onRandomize()’ marked ‘override’, but does not override
void onRandomize() override {
^
../../compile.mk:53: recipe for target 'build/src/Mutes.cpp.o' failed
make: *** [build/src/Mutes.cpp.o] Error 1

I don't know enough about C++ or Linux compiling for this to be useful info to me, but it might help somebody. Thanks VCV boffins for your efforts!

I didn't find grayscale under the directories here , so I post this under Fundamental .
Issue
Sometimes the first step is ommitted , this happens with all sequencers in vcv rack
-Route a gate from 'midi 1' out to state in of grayscale , no looping mode or press start with the mouse
-square lfo as clock .
-enable step 1/3/5 of grayscale , and assign pattern out to a sound source .

I even went further and send a gate from 'midi 1' to reset in of the square lfo .
It's a bit hit and miss ..but it happens with a lot of sequencer s in vcv rack .
This could be lfo related , where a high pulse is missed from the start .
If so , vcv could benefit from an accurate master clock

I try to load Fundamental plugin in Rack 0.6.2b and the lpugin refuses to load.
In the conseol, I've got the following message:

src_delete symbol not found.

Could there be a small mistake here in ADSR.cpp at line 44:

float attack = clamp(params[ATTACK_INPUT].value + inputs[ATTACK_INPUT].value / 10.0f, 0.0f, 1.0f);

The first ATTACK_INPUT should be ATTACK_PARAM?

Route gate to input of sequential switch 1
Route same gate also to clock input of seq.sw.
Set button of Seq.sw.. to top postition , so it alternates bewteen two gates.
Route the two outputs to 2 different destinations , make sure these destinations sound different ..so it's easier to spot the bug
The bug is that sometimes the previous gate is still outputted when it shouldn't , resulting in a slight trigger of the destiantion ( when it shouldn't ).

Just creating this so others can find it/as tracking issue.
As requested in https://github.com/VCVRack/Rack/#45

Linux Fedora 23 GCC 5.3.1
VCV Rack dev version

SEQ3: Inner (green) light is not centered.
ADSR: Panel graphics wrong size.

I'm not sure if I can post images here, so I've placed one here:

http://linux-sound.org/images/fundamentalerrors.png

Btw, please advise if reports like this are welcome. I realize that the dev stuff is under constant change, I don't want to post irrelevant reports.

Scope has an empty space, fit for an output. Then it could act as a passthrough without the need for multipliers. I propose to output the sum of X and Y signal.

ADD 2 input for the Seq3: START with trig (or gate) and STOP with trig (or gate)
just adding the 2 we could extend easily sequences to 16 24 32 and so on
ADD 1 TRIG out for last step (the one decided by the selector) in this case we can have variable length seq

@AndrewBelt What do you think about a switch to make the ADSR be able to generate long envelopes?

Would it be possible to add a V/oct input in Fundamental's SEQ3 module, so that when we right click one of the 24 knobs, it would set that knob to the current V/oct input? When no cable is connected to that input, it would revert to the current default behavior of simply resetting the knob to zero.

This would be a very useful addition, since as it is now, I find it takes a fair amount of time and adjustments to setup a sequence of notes in SEQ3 (I try not to use quantizers in SEQ3's output).

The use case I'm assuming here is when we want to enter sequences of notes using a midi keyboard, the Autodafe keyboard or anything else that generates pitch-correct CVs. This would make it such that we can sequence notes in a more real-time manner, without the need for using loopers.

If this does not adhere to the design principles of the Fundamental modules, please let me know and I'll remove the issue. Thanks!

P.S. The new sequential switches are a great addition btw!

Hi,

I recently built Rack and Fundamental from their current master branches, and afterwards I noticed I didn't seem to get any delay output from the delay module, just dry.

I'm curious about whether this is just some error of mine while building, or if it's an actual code problem.

After a bit of experimentation, I found that the following diff at least restored some wet output, but the code is largely mysterious to me, so no claims as to the correctness of it!

diff --git a/src/Delay.cpp b/src/Delay.cpp
index a89c7d6..0978168 100644
--- a/src/Delay.cpp
+++ b/src/Delay.cpp
@@ -75,7 +75,7 @@ void Delay::step() {
                int inFrames = mini(historyBuffer.size(), 16);
                int outFrames = outBuffer.capacity();
                // printf(">\t%d\t%d\n", inFrames, outFrames);
-               src.setRates(ratio * engineGetSampleRate(), engineGetSampleRate());
+               src.setRates(engineGetSampleRate()/ratio, engineGetSampleRate());
                src.process((const Frame<1>*)historyBuffer.startData(), &inFrames, (Frame<1>*)outBuffer.endData(), &outFrames);
                historyBuffer.startIncr(inFrames);
                outBuffer.endIncr(outFrames);

what the tittle say... Thanks!

The scope seems to have a bug. It's finest resolution is 2 audio samples per scope buffer entry, it could be as low as 1 audio sample per buffer entry. Suggested patch:

diff --git a/src/Scope.cpp b/src/Scope.cpp
index 3bbfb05..0e83726 100644
--- a/src/Scope.cpp
+++ b/src/Scope.cpp
@@ -92,7 +92,7 @@ void Scope::step() {

        // Add frame to buffer
        if (bufferIndex < BUFFER_SIZE) {
-               if (++frameIndex > frameCount) {
+               if (++frameIndex >= frameCount) {
                        frameIndex = 0;
                        bufferX[bufferIndex] = inputs[X_INPUT].value;
                        bufferY[bufferIndex] = inputs[Y_INPUT].value;

I hesitate to raise this as I probably missed something important in the docs again, so sorry if that is the case.

Seems to be a problem with the clone submodules step in Win 10 under mingw64:

Iain@BIGPC8 MINGW64 ~/Rack/plugins
$ git clone https://github.com/VCVRack/Fundamental.git
Cloning into 'Fundamental'...
remote: Counting objects: 709, done.
remote: Compressing objects: 100% (40/40), done.
remote: Total 709 (delta 46), reused 66 (delta 38), pack-reused 631
Receiving objects: 100% (709/709), 699.36 KiB | 1.14 MiB/s, done.
Resolving deltas: 100% (477/477), done.

Iain@BIGPC8 MINGW64 ~/Rack/plugins
$ cd Fundamental/

Iain@BIGPC8 MINGW64 ~/Rack/plugins/Fundamental
$ git submodule update --init --recursive
': not a valid identifierline 88: export: `dashless

If you are running an interface with more than 8 outputs and wish to use one of the outputs that is >8, you are currently unable to do so. It would be great to be able to selectively route outputs to preferred interface outputs or have the application dynamically create all available input/outputs per the selected device.

Here is what I'm seeing:

➜  Fundamental git:(master) make
g++ -fPIC -I../../include -I../../dep/include -DVERSION=0.5.1 -MMD -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -Wsuggest-override -std=c++11 -c -o build/src/VCMixer.cpp.o src/VCMixer.cpp
g++ -fPIC -I../../include -I../../dep/include -DVERSION=0.5.1 -MMD -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -Wsuggest-override -std=c++11 -c -o build/src/VCA.cpp.o src/VCA.cpp
g++ -fPIC -I../../include -I../../dep/include -DVERSION=0.5.1 -MMD -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -Wsuggest-override -std=c++11 -c -o build/src/VCO.cpp.o src/VCO.cpp
g++ -fPIC -I../../include -I../../dep/include -DVERSION=0.5.1 -MMD -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -Wsuggest-override -std=c++11 -c -o build/src/SequentialSwitch.cpp.o src/SequentialSwitch.cpp
g++ -fPIC -I../../include -I../../dep/include -DVERSION=0.5.1 -MMD -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -Wsuggest-override -std=c++11 -c -o build/src/Mutes.cpp.o src/Mutes.cpp
src/Mutes.cpp:34:7: error: ‘void Mutes::onReset()’ marked ‘override’, but does not override
  void onReset() override {
       ^~~~~~~
src/Mutes.cpp:39:7: error: ‘void Mutes::onRandomize()’ marked ‘override’, but does not override
  void onRandomize() override {
       ^~~~~~~~~~~
make: *** [../../compile.mk:54: build/src/Mutes.cpp.o] Error 1

I'm on arch linux:

➜  Fundamental git:(master) ✗ uname -a
Linux sorahan-desktop 4.14.4-1-ARCH #1 SMP PREEMPT Tue Dec 26 19:10:06 UTC 2017 x86_64 GNU/Linux

Rack version: v0.6 @ 0ba244e98f05ab36c46636c6c718f84af531d75e
OS: Mac

Trying to manipulate the "time" knob on the Scope only allows me to select the right most position. If I right click the knob, the 3 o'clock position may be selected. Randomize will select other values.

Any interest in adding more modules to Fundamental, simple straightforward things such as clock dividers and logical (AND, OR, XNOR, etc.) modules? I'm looking to make some things along these lines and wondering if they would find a home here.

small typo in the json part:

lines 46 and 57
for (int i = 0; i < 8; i++) {
should be
for (int i = 0; i < 10; i++) {

When displaying very low frequency signals, the external trigger doesn't work because of the fixed 0.1s hold time, see this example:
scope-test.vcv.zip
It works, if I set the hold time to 2s in the source code. On my Agilent scope I can adjust the hold time and I really like the accelerated feature of the knob, but this might be difficult, both to implement and to use with a mouse. Maybe a knob with fixed positions would be useful, like 10s, 5s, 2s, 1s, 100ms, 10ms, 1ms, 100us.

AudibleInstruments ignores

build/
plugin.dll

in it's .gitignore.

Fundamental, Befaco, and ESeries should do the same.

Good Day,

Just attempted to compile plugins on Windows platform and will not compile :(

src/Delay.cpp:78:7: error: 'struct rack::SampleRateConverter<1>' has no member named 'setRates'; did you mean 'setRatio'?
src.setRates(ratio * engineGetSampleRate(), engineGetSampleRate());

It appears to me that your alteration made 18 days ago is the problem.

I've carried a few more checks and it appears that your onReset() Overide doesn't work either.

Andy W

Hi, i love to work with your software, (i also got the paid VCV Plugins to support this project)
my only wish is to add an WAV recorder to the default/fundamental plugins of VCV Rack,
i imagine it to be simple to add.

Such a module would greatly improve my workflow and the sound quality of my audio files.

thanks~ Lue

Compilation from a fresh checkout fails when using parallelized build with the -j argument.

Maybe the problem is, that the dependencies are build in parallel with the code files and some code files may need the dependencies, but they are not build yet?

Running just make works fine, running make -j 4 does not.

@AScustomWorks has the same problem as he is using the same Makefile recipe to build his dependencies.

minor issue typo in manifest.
https://github.com/VCVRack/Fundamental/blob/v1/plugin.json#L95

Sequential Switch 2 will show as "Sequential Switch 1" in the modules context menu.

Hello,

I've just installed Rack 0.60 under Winbdows 10/64 bits and when selecting a MIDI input the program crashes. It happens with all the core MIDI modules : MIDI-1, MIDI-4, MIDI-CC, MIDI-TRIG. Currently it seems to happen with most devices (QuNexus, my driverless USB MIDI interface, but not LoopBe1).

The Fine knob appears to have no effect in the VCF.cpp code. FINE_PARAM is declared and used in the knob, but nowhere else.

Perhaps it should have an effect in the step() function, in line 132:

float cutoffExp = params[FREQ_PARAM].value + params[FREQ_CV_PARAM].value * inputs[FREQ_INPUT].value / 5.0f;

which could become something like:

float cutoffExp = params[FREQ_PARAM].value + params[FINE_PARAM].value / 5.0f + params[FREQ_CV_PARAM].value * inputs[FREQ_INPUT].value / 5.0f;

Hi, just found out that Fundamental Delay module has an issue:
There's no delayed signal coming out of it, color and mix knobs work ok, but the delay part does nothing.
Note: (as a couple of AS modules are based on Fundamental Delay, both suffer the same issue).

Thanks!

$ make
g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.1 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_WIN -D_USE_MATH_DEFINES -c -o build/src/Fundamental.cpp.o src/Fundamental.cpp
g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.1 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_WIN -D_USE_MATH_DEFINES -c -o build/src/Delay.cpp.o src/Delay.cpp
g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.1 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_WIN -D_USE_MATH_DEFINES -c -o build/src/VCF.cpp.o src/VCF.cpp
src/VCF.cpp: In member function 'void LadderFilter::process(float, float)':
src/VCF.cpp:35:3: error: 'stepRK4' was not declared in this scope
stepRK4(0.f, dt, state, 4, [&](float t, const float y[], float dydt[]) {
^~~~~~~
src/VCF.cpp:35:3: note: suggested alternative:
In file included from src/VCF.cpp:4:0:
../../include/dsp/ode.hpp:58:6: note: 'rack::ode::stepRK4'
void stepRK4(float t, float dt, float x[], int len, F f) {
^~~~~~~
make: *** [../../compile.mk:65: build/src/VCF.cpp.o] Error 1

v1.dev.4741892

Rack runs okay but cloning Fundamental-1, Befaco-1, Template-1 repo's or manually adding and make does not work. Worked okay on an earlier version of Rack-1. This is a clean clone btw.

Just get the message
make: jq: Command not found make: jq: Command not found ../../plugin.mk:9: *** SLUG could not be found in manifest. Stop.

same issue with make dep with fundamental-1
I checked all v1 manifests, all have the "slug":. It's probably something I overlooked to which I apologies in advanced!

Win 7

Trying to compile Fundamental with current Rack master branch doesn't work. I'm getting the following errors:

src/SequentialSwitch.cpp:15:8: error: expected '= constant-expression' or end of
      enumerator definition
                ENUMS(IN_INPUT, TYPE == 1 ? 1 : 4),
                     ^
src/SequentialSwitch.cpp:19:3: error: redefinition of enumerator 'ENUMS'
                ENUMS(OUT_OUTPUT, TYPE == 1 ? 4 : 1),
                ^
src/SequentialSwitch.cpp:15:3: note: previous definition is here
                ENUMS(IN_INPUT, TYPE == 1 ? 1 : 4),
                ^
src/SequentialSwitch.cpp:19:8: error: expected '= constant-expression' or end of
      enumerator definition
                ENUMS(OUT_OUTPUT, TYPE == 1 ? 4 : 1),
                     ^
src/SequentialSwitch.cpp:23:3: error: redefinition of enumerator 'ENUMS'
                ENUMS(CHANNEL_LIGHT, 4),
                ^
src/SequentialSwitch.cpp:15:3: note: previous definition is here
                ENUMS(IN_INPUT, TYPE == 1 ? 1 : 4),
                ^
src/SequentialSwitch.cpp:23:8: error: expected '= constant-expression' or end of
      enumerator definition
                ENUMS(CHANNEL_LIGHT, 4),
                     ^
src/SequentialSwitch.cpp:59:23: error: use of undeclared identifier 'IN_INPUT'
                        float out = inputs[IN_INPUT + 0].value;
                                           ^
src/SequentialSwitch.cpp:61:13: error: use of undeclared identifier 'OUT_OUTPUT'; did
      you mean 'NUM_OUTPUTS'?
                                outputs[OUT_OUTPUT + i].value = channelFilter[i]...
                                        ^~~~~~~~~~
                                        NUM_OUTPUTS
src/SequentialSwitch.cpp:20:3: note: 'NUM_OUTPUTS' declared here
                NUM_OUTPUTS
                ^
src/SequentialSwitch.cpp:67:42: error: use of undeclared identifier 'IN_INPUT'
                                out += channelFilter[i].out * inputs[IN_INPUT + ...
                                                                     ^
src/SequentialSwitch.cpp:69:12: error: use of undeclared identifier 'OUT_OUTPUT'; did
      you mean 'NUM_OUTPUTS'?
                        outputs[OUT_OUTPUT + 0].value = out;
                                ^~~~~~~~~~
                                NUM_OUTPUTS
src/SequentialSwitch.cpp:20:3: note: 'NUM_OUTPUTS' declared here
                NUM_OUTPUTS
                ^
src/SequentialSwitch.cpp:74:11: error: use of undeclared identifier 'CHANNEL_LIGHT'
                        lights[CHANNEL_LIGHT + i].setBrightness(channelFilter[i].out);
                               ^
src/SequentialSwitch.cpp:89:23: error: use of undeclared identifier 'CKSSThree'
        addParam(createParam<CKSSThree>(mm2px(Vec(5.24619, 46.9153)), module, TS...
                             ^
src/SequentialSwitch.cpp:93:92: error: no member named 'IN_INPUT' in
      'SequentialSwitch<1>'
  ...62.8096)), module, TSequentialSwitch::IN_INPUT + 0));
                        ~~~~~~~~~~~~~~~~~~~^
src/SequentialSwitch.cpp:95:94: error: no member named 'OUT_OUTPUT' in
      'SequentialSwitch<1>'; did you mean 'NUM_OUTPUTS'?
  ...77.8095)), module, TSequentialSwitch::OUT_OUTPUT + 0));
                        ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
                                           NUM_OUTPUTS
src/SequentialSwitch.cpp:20:3: note: 'NUM_OUTPUTS' declared here
                NUM_OUTPUTS
                ^
src/SequentialSwitch.cpp:96:94: error: no member named 'OUT_OUTPUT' in
      'SequentialSwitch<1>'; did you mean 'NUM_OUTPUTS'?
  ...87.8113)), module, TSequentialSwitch::OUT_OUTPUT + 1));
                        ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
                                           NUM_OUTPUTS
src/SequentialSwitch.cpp:20:3: note: 'NUM_OUTPUTS' declared here
                NUM_OUTPUTS
                ^
src/SequentialSwitch.cpp:97:93: error: no member named 'OUT_OUTPUT' in
      'SequentialSwitch<1>'; did you mean 'NUM_OUTPUTS'?
  ...97.809)), module, TSequentialSwitch::OUT_OUTPUT + 2));
                       ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
                                          NUM_OUTPUTS
src/SequentialSwitch.cpp:20:3: note: 'NUM_OUTPUTS' declared here
                NUM_OUTPUTS
                ^
src/SequentialSwitch.cpp:98:94: error: no member named 'OUT_OUTPUT' in
      'SequentialSwitch<1>'; did you mean 'NUM_OUTPUTS'?
  ...107.809)), module, TSequentialSwitch::OUT_OUTPUT + 3));
                        ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
                                           NUM_OUTPUTS
src/SequentialSwitch.cpp:20:3: note: 'NUM_OUTPUTS' declared here
                NUM_OUTPUTS
                ^
src/SequentialSwitch.cpp:100:103: error: no member named 'CHANNEL_LIGHT' in
      'SequentialSwitch<1>'
  ...77.7158)), module, TSequentialSwitch::CHANNEL_LIGHT + 0));
                        ~~~~~~~~~~~~~~~~~~~^
src/SequentialSwitch.cpp:101:103: error: no member named 'CHANNEL_LIGHT' in
      'SequentialSwitch<1>'
  ...87.7163)), module, TSequentialSwitch::CHANNEL_LIGHT + 1));
                        ~~~~~~~~~~~~~~~~~~~^
src/SequentialSwitch.cpp:102:103: error: no member named 'CHANNEL_LIGHT' in
      'SequentialSwitch<1>'
  ...97.7167)), module, TSequentialSwitch::CHANNEL_LIGHT + 2));
                        ~~~~~~~~~~~~~~~~~~~^
fatal error: too many errors emitted, stopping now [-ferror-limit=]

(Note: Everything compiles fine with the v0.5 branch)

There is something weird going on with the seq-3 module. When you activate all gates no gate is being outputted on the Gates output of the module, also when two gates next to each other(for example 1 and 2) only the first gate is outputted. Sometimes I also get ghost notes, set a gate on step 1 then another gate event is send out which is not set anywhere. Actually when you set to gates next to each other 1 and 2 then first gate is send but then on position another one is send but the event is not there...

I'm unable to build Fundamental on my Mac. Looking at the Makefile and build output, it seems that $(WGET) and $(UNTAR) are not defined at the time they're referenced in the makefile. Should a different makefile with definitions for these be included?

Build fails currently (baa041b) with:

rack_plugins_1 | g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.1 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/VCF.cpp.o src/VCF.cpp
rack_plugins_1 | src/VCF.cpp: In member function 'void LadderFilter::process(float, float)':
rack_plugins_1 | src/VCF.cpp:35:3: error: 'ode' has not been declared
rack_plugins_1 | ode::stepRK4(0.f, dt, state, 4, [&](float t, const float x[], float dxdt[]) {
rack_plugins_1 | ^
rack_plugins_1 | ../../compile.mk:64: recipe for target 'build/src/VCF.cpp.o' failed
rack_plugins_1 | make: *** [build/src/VCF.cpp.o] Error 1

Should it be rack::ode::stepRK4?

with git HEAD of today for core and the plugins I get:

src/Delay.cpp: In member function ‘virtual void Delay::step()’:
src/Delay.cpp:78:7: error: ‘struct rack::SampleRateConverter<1>’ has no member named ‘setRates’; did you mean ‘setRatio’?
   src.setRates(ratio * engineGetSampleRate(), engineGetSampleRate());
       ^~~~~~~~

Will require either sample rate conversion, or interpolation (sinc?) on the graphics thread.

When building the Fundamentals module pack I get an error regarding the Delay module.
More specifically:
src/Delay.cpp:78:7: error: no member named 'setRates' in 'rack::SampleRateConverter<1>' src.setRates(ratio * engineGetSampleRate(), engineGetSam... ~~~ ^ 1 error generated. make: *** [build/src/Delay.cpp.o] Error 1

Any fixes?

I'm not sure if this is an intended behavior or not, but for absolutely massive/tiny values, Scope will do this:

Of course, the real bug is in my module, but it seems like scope should limit all drawing to within the display area.

Hitting reset will currently automatically evaluates the first step (nextStep->true SEQ3.cpp:L154) . This is probably not problematic if no external clock is controlling SEQ3 but will lead to an offset if the "reset" pulse does not come in parallel with the first clock tick from an external clock.

To be more precise: The midi clock start message is not bound to a clock tick. The first tick might therefore come after the start message. If SEQ3 is resetted by the start midi message SEQ3 "assumes" this is also the first tick. However, if the first tick actually comes after the reset message, SEQ3 will be running one step ahead of a synced midi sequencer.

It looks to me like SEQ-3 is having problems driving the ADSR, at least on the windows version. I think the gate isn't long enough. Sadly the SEQ3 gate out into the trigger in also doesn't do anything. I've included a screenshot showing 2 duplicated ADSRs operating via gates from SEQ3 and the MIDI interface.

Oh I chopped off the top of the window the screenshot is from the 0.4.0 windows binary package.

Compiling Fundamental gives me this error:

src/Delay.cpp:76:20: error: invalid conversion from ‘const float*’ to ‘float*’ [-fpermissive]
srcData.data_in = (const float*) historyBuffer.startData();
^

I avoid tampering with the -f compile flags as I don't want to alter the compilation of other modules. For now I can quickly fix by removing the const attribute but a better solution is required.

My compiler:
g++ (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609
Maybe in later versions the policy with -fpermissive has changed.
Linux Mint, Rack v1.dev.df0c8cf

Linux Fedora 23
Rack master (git pull 13 March)

g++ -Wsuggest-override -std=c++11 -fPIC -I../../include -I../../dep/include -DSLUG=Fundamental -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/VCMixer.cpp.o src/VCMixer.cpp
src/VCMixer.cpp: In constructor ‘VCMixerWidget::VCMixerWidget(VCMixer*)’:
src/VCMixer.cpp:50:32: error: ‘LEDSliderGreen’ was not declared in this scope
addParam(ParamWidget::create(mm2px(Vec(5.8993969, 44.33149).plus(Vec(-2, 0))), module, VCMixer::LVL_PARAM + 0, 0.0, 1.0, 1.0));
^
src/VCMixer.cpp:50:143: error: no matching function for call to ‘rack::Parameter::create(rack::Vec, VCMixer*&, int, double, double, double)’
addParam(ParamWidget::create(mm2px(Vec(5.8993969, 44.33149).plus(Vec(-2, 0))), module, VCMixer::LVL_PARAM + 0, 0.0, 1.0, 1.0));
^
In file included from ../../include/rack.hpp:9:0,
from src/Fundamental.hpp:1,
from src/VCMixer.cpp:1:
../../include/app.hpp:244:12: note: candidate: template static T* rack::Parameter::create(rack::Vec, rack::Module*, int, float, float, float)
static T create(Vec pos, Module module, int paramId, float minValue, float maxValue, float defaultValue) {
^
../../include/app.hpp:244:12: note: template argument deduction/substitution failed:
src/VCMixer.cpp:50:143: error: template argument 1 is invalid
addParam(ParamWidget::create(mm2px(Vec(5.8993969, 44.33149).plus(Vec(-2, 0))), module, VCMixer::LVL_PARAM + 0, 0.0, 1.0, 1.0));
^
src/VCMixer.cpp:51:32: error: the value of ‘LEDSliderGreen’ is not usable in a constant expression
addParam(ParamWidget::create(mm2px(Vec(17.899343, 44.331486).plus(Vec(-2, 0))), module, VCMixer::LVL_PARAM + 1, 0.0, 1.0, 1.0));
^
src/VCMixer.cpp:50:32: note: ‘LEDSliderGreen’ was not declared ‘constexpr’
addParam(ParamWidget::create(mm2px(Vec(5.8993969, 44.33149).plus(Vec(-2, 0))), module, VCMixer::LVL_PARAM + 0, 0.0, 1.0, 1.0));
^
src/VCMixer.cpp:51:144: error: no matching function for call to ‘rack::Parameter::create(rack::Vec, VCMixer&, int, double, double, double)’
addParam(ParamWidget::create(mm2px(Vec(17.899343, 44.331486).plus(Vec(-2, 0))), module, VCMixer::LVL_PARAM + 1, 0.0, 1.0, 1.0));
^
In file included from ../../include/rack.hpp:9:0,
from src/Fundamental.hpp:1,
from src/VCMixer.cpp:1:
../../include/app.hpp:244:12: note: candidate: template static T rack::Parameter::create(rack::Vec, rack::Module*, int, float, float, float)
static T create(Vec pos, Module module, int paramId, float minValue, float maxValue, float defaultValue) {
^
../../include/app.hpp:244:12: note: template argument deduction/substitution failed:
src/VCMixer.cpp:52:32: error: the value of ‘LEDSliderGreen’ is not usable in a constant expression
addParam(ParamWidget::create(mm2px(Vec(29.899292, 44.331486).plus(Vec(-2, 0))), module, VCMixer::LVL_PARAM + 2, 0.0, 1.0, 1.0));
^
src/VCMixer.cpp:50:32: note: ‘LEDSliderGreen’ was not declared ‘constexpr’
addParam(ParamWidget::create(mm2px(Vec(5.8993969, 44.33149).plus(Vec(-2, 0))), module, VCMixer::LVL_PARAM + 0, 0.0, 1.0, 1.0));
^
src/VCMixer.cpp:52:144: error: no matching function for call to ‘rack::Parameter::create(rack::Vec, VCMixer&, int, double, double, double)’
addParam(ParamWidget::create(mm2px(Vec(29.899292, 44.331486).plus(Vec(-2, 0))), module, VCMixer::LVL_PARAM + 2, 0.0, 1.0, 1.0));
^
In file included from ../../include/rack.hpp:9:0,
from src/Fundamental.hpp:1,
from src/VCMixer.cpp:1:
../../include/app.hpp:244:12: note: candidate: template static T rack::Parameter::create(rack::Vec, rack::Module*, int, float, float, float)
static T create(Vec pos, Module module, int paramId, float minValue, float maxValue, float defaultValue) {
^
../../include/app.hpp:244:12: note: template argument deduction/substitution failed:
src/VCMixer.cpp:53:32: error: the value of ‘LEDSliderGreen’ is not usable in a constant expression
addParam(ParamWidget::create(mm2px(Vec(41.90065, 44.331486).plus(Vec(-2, 0))), module, VCMixer::LVL_PARAM + 3, 0.0, 1.0, 1.0));
^
src/VCMixer.cpp:50:32: note: ‘LEDSliderGreen’ was not declared ‘constexpr’
addParam(ParamWidget::create(mm2px(Vec(5.8993969, 44.33149).plus(Vec(-2, 0))), module, VCMixer::LVL_PARAM + 0, 0.0, 1.0, 1.0));
^
src/VCMixer.cpp:53:143: error: no matching function for call to ‘rack::Parameter::create(rack::Vec, VCMixer&, int, double, double, double)’
addParam(ParamWidget::create(mm2px(Vec(41.90065, 44.331486).plus(Vec(-2, 0))), module, VCMixer::LVL_PARAM + 3, 0.0, 1.0, 1.0));
^
In file included from ../../include/rack.hpp:9:0,
from src/Fundamental.hpp:1,
from src/VCMixer.cpp:1:
../../include/app.hpp:244:12: note: candidate: template static T rack::Parameter::create(rack::Vec, rack::Module*, int, float, float, float)
static T *create(Vec pos, Module *module, int paramId, float minValue, float maxValue, float defaultValue) {
^
../../include/app.hpp:244:12: note: template argument deduction/substitution failed:
../../compile.mk:57: recipe for target 'build/src/VCMixer.cpp.o' failed
make: *** [build/src/VCMixer.cpp.o] Error 1

Get this on any file declaring either of

void reset() override
void randomize() override

Rack revision: VCVRack/Rack@2c17b65
Fundamental revision: b54abba

This goes away if I roll back Rack to this revision:
VCVRack/Rack@e601177
Which is the commits before Remove Module::reset(), Module::initialize(), and Module::randomize(), add onRandomize(), onReset(), onCreate(), and onDelete()
VCVRack/Rack@36cd050

Building on OSX

rack_plugins_1 | ++ popd
rack_plugins_1 | ++ buildp https://github.com/VCVRack/Fundamental.git v0.6 --recursive
rack_plugins_1 | /build/Rack/plugins /build/Rack
rack_plugins_1 | +++ basename https://github.com/VCVRack/Fundamental
rack_plugins_1 | ++ ls /build/Rack/plugins/Fundamental
rack_plugins_1 | ++ git clone https://github.com/VCVRack/Fundamental.git
rack_plugins_1 | Cloning into 'Fundamental'...
rack_plugins_1 | +++ basename https://github.com/VCVRack/Fundamental
rack_plugins_1 | ++ pushd ./Fundamental
rack_plugins_1 | ++ shift
rack_plugins_1 | ++ git remote prune origin
rack_plugins_1 | /build/Rack/plugins/Fundamental /build/Rack/plugins /build/Rack
rack_plugins_1 | ++ git fetch
rack_plugins_1 | ++ git checkout v0.6
rack_plugins_1 | Already on 'v0.6'
rack_plugins_1 | Your branch is up-to-date with 'origin/v0.6'.
rack_plugins_1 | ++ shift
rack_plugins_1 | ++ [[ -n 1 ]]
rack_plugins_1 | ++ git submodule update --init --recursive
rack_plugins_1 | ++ shift
rack_plugins_1 | ++ [[ -n 0 ]]
rack_plugins_1 | ++ make
rack_plugins_1 | g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/VCMixer.cpp.o src/VCMixer.cpp
rack_plugins_1 | g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/VCA.cpp.o src/VCA.cpp
rack_plugins_1 | g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/VCO.cpp.o src/VCO.cpp
rack_plugins_1 | g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/SequentialSwitch.cpp.o src/SequentialSwitch.cpp
rack_plugins_1 | g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/Mutes.cpp.o src/Mutes.cpp
rack_plugins_1 | g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/Unity.cpp.o src/Unity.cpp
rack_plugins_1 | g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/Scope.cpp.o src/Scope.cpp
rack_plugins_1 | g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/LFO.cpp.o src/LFO.cpp
rack_plugins_1 | g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/ADSR.cpp.o src/ADSR.cpp
rack_plugins_1 | g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/8vert.cpp.o src/8vert.cpp
rack_plugins_1 | g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/SEQ3.cpp.o src/SEQ3.cpp
rack_plugins_1 | g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/VCF.cpp.o src/VCF.cpp
rack_plugins_1 | g++ -Wsuggest-override -std=c++11 -Idep/include -DSLUG=Fundamental -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/Delay.cpp.o src/Delay.cpp
rack_plugins_1 | src/Delay.cpp:5:24: fatal error: samplerate.h: No such file or directory
rack_plugins_1 | compilation terminated.
rack_plugins_1 | ../../compile.mk:64: recipe for target 'build/src/Delay.cpp.o' failed
rack_plugins_1 | make: *** [build/src/Delay.cpp.o] Error 1
vcvrackdocker_rack_plugins_1 exited with code 2