Coder Social home page Coder Social logo

Comments (12)

isucan avatar isucan commented on August 19, 2024

+1 for separate repo

from urdfdom.

jacquelinekay avatar jacquelinekay commented on August 19, 2024

should I move it to robot_model or make a new repo entirely for urdf_parser_py?

from urdfdom.

isucan avatar isucan commented on August 19, 2024

I would move it to a new urdf_parser_py

from urdfdom.

traversaro avatar traversaro commented on August 19, 2024

Distributing urdf_parser_py only as a ROS (Catkin) package would make much more difficult to use urdf_parser_py in Windows.
To clarify our use case: mechanical people use Windows (because most CAD modeling software is available on Windows), and then they export their CAD model to URDF using https://github.com/robotology/simmechanics-to-urdf (that clearly does not use from_parameter_server).
Unfortunately it appears that the from_parameter_server method is quite used, so moving urdf_parser_py to a ROS package is the right thing to do.
I would probably need to maintain a fork of urdf_parser_py that does not use Catkin, and keep it in synch with the urdf_parser_py ROS package.
cc @fiorisi

from urdfdom.

jacquelinekay avatar jacquelinekay commented on August 19, 2024

@traversaro I'll keep cross-platform compatibility in mind when I do this.

from urdfdom.

traversaro avatar traversaro commented on August 19, 2024

@jacquelinekay I noticed that catkin is also distributed through pip, so perhaps it is not so traumatic to install it on Windows.

from urdfdom.

jacquelinekay avatar jacquelinekay commented on August 19, 2024

Windows development is usually traumatic for me :P

from urdfdom.

jacquelinekay avatar jacquelinekay commented on August 19, 2024

With regards to your concerns, Silvio, my vision is for urdf_parser_py to be cross-platform and ROS-free, and to have a separate catkin package in the robot_model repo to wrap the module with ROS-specific utilities, like communicating with the parameter server. I'm going to start by just separating it out into a different repo (and possibly doing a release).

I confirmed with Ioan that urdf_parser_py is only released as a ROS package right now, but it sounds like your team does your own packaging to use it on Windows, is that correct?

from urdfdom.

traversaro avatar traversaro commented on August 19, 2024

Yes, we use it by installing through the (pure, non-catkin) CMake code in this repo.

Thanks, what you just proposed is ideal.

from urdfdom.

traversaro avatar traversaro commented on August 19, 2024

For the sake of precision: I actually noticed that we install the urdf_parser_py script using the classical python setup.py install, see https://github.com/robotology/simmechanics-to-urdf#install-dependencies-2 .

from urdfdom.

jacquelinekay avatar jacquelinekay commented on August 19, 2024

#80
https://github.com/ros/urdf_parser_py
ros/urdf_parser_py#1

todo:

  • Set up Travis for new repo
  • properly set up ROS Wiki pages for respective packages

from urdfdom.

jacquelinekay avatar jacquelinekay commented on August 19, 2024

As a side note, why is the ROS deb called urdfdom-py while the package is called urdf_parser_py in github and in the setup.py? I prefer the name urdf_parser_py myself, but I guess it's more important not to disrupt the configuration of many users by change the name of the debian.

from urdfdom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.