Wrong hip_pitch to hip motor coupling in coupling matrices matrixM2J and matrixM2J about robots-configuration

[valegagge]

Gearbox_M2J is the "total" reduction between motor to joint, not only harmonic drive.

There is a decument (written by to mechanicals guys) that specifies each stage of reduction. It would be nice that these documenatation is sharebale.

[nunoguedelha]

Yes exactly. And along with that the friction estimation results.

[traversaro]

A nice reason to modify the coupling matrix instead of the Gearbox_M2J is that so we can keep the consistency between the Gearbox_M2J parameter and the reduction ratio of the harmonic drive.

[DanielePucci]

If I am not wrong, this issue has an impact directly on the torque control because these matrices are used in the low level joint torque control. In this case, it may also justify some of the difficulties we had while performing torque control walking

CC
@S-Dafarra @gabrielenava @GiuliaP @hu-yue

[ale-git]

The reduction ratio was correctly 50/75 when the joint configuration was fixed in the source code in Controller.c (this part is now under #if 0):

    case eomc_ctrlboard_UPPERLEG:                //= 2,    //2FOC
    {
        Jjm = o->Jjm;
        Sjm = o->Sjm;
    
        Sjm[0][0] = 50.0f/75.0f;
        Jjm[0][0] = Sjm[0][0];

Evidently the 50/75 value has been omitted in the configuration files of the new version, erroneusly assuming that no coupling always implies identity matrix. Another way to correct the issue is leaving the identity matrix unchanged and change the Gearbox_M2J parameter from 100.0 to 150.0 in the same file.

[ale-git]

The ratio doesn't affect the torque control, since the "motor" software entity under control is the "motor+gearbox" physical object seen as a single entity. It could have affected the robot if the iCub hip pitch motors were low level speed controlled like in R1, but they aren't. The only effect of the wrong gearbox ratio is in the joint velocity computed from the motor velocity, which isn't used in the controller (the derivative of the error in the PIDs is computed by locally differentiating the position error).

[valegagge]

I prefer to update the gearbox ratio instead of the coupling matrix, because this is a reduction factor and not a couplig ratio. I know that the result is equal, but I think we should update the right parameter in order to mantain a clear information about the robot.

The gearbox parameters is the reduction factor from motor to joint, while the coupled matrix is used only when motors are coupled.

So please, could you update the Gearbox_M2J parameter to 150?

After you'll check that new value is fine, we need to fix all robots with the same legs.
Could you advise me if the change is ok, so I'll update others robots?
thanks!

[nunoguedelha]

I actually don't agree with that for the following reasons:

• the coupling is supposed to define the transfer function (matrix) between a vector of [motor+physical gearbox] velocities and a vector of joint velocities,
• potencially any coupling system can have a "total" reduction (between sum of motor velocities and sum of joint velocities) ≠ 1,

so I don't think it's a good idea to consider that all the reduction factor in the "gearbox" ratio, it adds complexity and is error prone. For instance let's suppose some day we get to implement a low level control that models the elasticity of the cables, and depends on the reduction due to that cable (on the hip), we would have to do a workaround for retrieving the reduction factor from the "gearbox" ratio.

[nunoguedelha]

Btw, currently all joints, coupled or not, are mapped to a coupling matrix, and it's more robust and simple to keep it that way. The less "exceptions" we use the better.

[traversaro]

There is a decument (written by to mechanicals guys) that specifies each stage of reduction. It would be nice that these documenatation is sharebale.

Definitely, at least internally in IIT!

[pattacini]

Any reason why we should keep this still open?

cc @nunoguedelha @traversaro