Coder Social home page Coder Social logo

Comments (8)

pdonahue-ventana avatar pdonahue-ventana commented on August 12, 2024

Supporting execute triggers with timing=after is a bad idea.

If you have an execute trigger with timing=after and an illegal instruction then the illegal instruction is the highest priority according to table 13. You take the trap, update mepc, and go to mtvec. Then the "mcontrol/mcontrol6 after (on previous instruction)" would be the highest priority on the first instruction of the handler. Because MIE=0, this trigger would not fire and the trigger is completely lost (since there is no pending bit).

If you had timing=before then "mcontrol/mcontrol6 execute address before" would have higher priority than illegal instruction and mepc would point to the current instruction (which has not yet executed and gone to the illegal instruction handler). This is obviously much more desirable.

from riscv-debug-spec.

Wei-VV1995 avatar Wei-VV1995 commented on August 12, 2024

Thanks for your explanation.

I don't quite understand the phrase "Because MIE=0, this trigger would not fire and the trigger is completely lost (since there is no pending bit)" in your answer. What is the relationship between MIE and trigger?

Any help would be greatly appreciated!

from riscv-debug-spec.

Wei-VV1995 avatar Wei-VV1995 commented on August 12, 2024

Thanks for your explanation.

I don't quite understand the phrase "Because MIE=0, this trigger would not fire and the trigger is completely lost (since there is no pending bit)" in your answer. What is the relationship between MIE and trigger?

Any help would be greatly appreciated!

from riscv-debug-spec.

pdonahue-ventana avatar pdonahue-ventana commented on August 12, 2024

I don't quite understand the phrase "Because MIE=0, this trigger would not fire and the trigger is completely lost (since there is no pending bit)" in your answer. What is the relationship between MIE and trigger?

See section 5.4 ("Native Triggers") in the spec. I was assuming that you'd implement this MIE option but if you implement the mte option then I would have said the exact same thing except using "mte=0" instead of "MIE=0".

from riscv-debug-spec.

Wei-VV1995 avatar Wei-VV1995 commented on August 12, 2024

Thank you very much for your answer !

from riscv-debug-spec.

Wei-VV1995 avatar Wei-VV1995 commented on August 12, 2024

Thanks for your explanation.
In general, mstatus.mie is a switch used to determine whether to respond to interrupts. In the debug spec, MIE is also used to control whether to respond to trigger exceptions. What is the significance of controlling trigger exception response through MIE?

from riscv-debug-spec.

pdonahue-ventana avatar pdonahue-ventana commented on August 12, 2024

What is the significance of controlling trigger exception response through MIE?

MIE generally indicates whether a handler is reentrant or not. If a handler has MIE=1 then it definitely can tolerate a trap happening. If a handler has MIE=0 then it probably cannot (though maybe it can). MIE is the only thing that acts like this and, although it may be overly conservative, it will guarantee that triggers don't cause traps that do not allow us to eventually get back to normal execution.

Alternatively, we could have done something like Smdbltrp/Ssdbltrp did by adding MDT and SDT bits to mstatus. But that involved changing a CSR that's generally outside the scope of the debug TG. Option 2 of using mte is similar to MDT but it has limitations and it requires context switch code to deal with another CSR.

from riscv-debug-spec.

Wei-VV1995 avatar Wei-VV1995 commented on August 12, 2024

Thank you very much for your answer !

from riscv-debug-spec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.