[Feature request] Optionally allow migration NOT to run in a transaction. about goose

[dkoston]

Here's a diff that will allow this to happen for SQL migrations. It'll take a little more work if you're using go migrations. Use migrations w/o transaction at your own risk:

https://gist.github.com/dkoston/9b28b092424b46ad841d3a41c56c7c83

[VojtechVitek]

@dkoston nice, can you submit a PR?

[dkoston]

@VojtechVitek sorry, we forked directly off https://bitbucket.org/liamstask/goose/src. Looks like you've made some modifications after those commits that aren't part of our internal fork. I fixed up the diff to use your directory structure but you have some code changes that will require modifications to use git apply

[iosdev-republicofapps]

Hi,

Any progress on this? In Postgres, you also cannot modify enums inside a transaction as per https://www.postgresql.org/docs/current/static/sql-altertype.html

ALTER TYPE ... ADD VALUE (the form that adds a new value to an enum type) cannot be executed inside a transaction block.

We will be doing some of these but it seems like goose can't handle these?

Can I take over this fix and create a PR to handle this case?

Thanks

[VojtechVitek]

@iosdev-republicofapps PR would be greatly appreciated!

For SQL migrations, we need a flag like:

-- +goose Up transaction=false
-- +goose StatementBegin
ALTER TYPE ...; -- no transaction
-- +goose StatementEnd

-- +goose Down
-- +goose StatementBegin
ALTER TYPE ...; -- within a transaction
-- +goose StatementEnd

For Go migrations, we can support two function signatures:

func alterTypeUp(db *sql.DB) error {} // no transaction
func alterTypeDown(tx *sql.Tx) error {} // within a transaction

Thoughts?