ENVSUB is not working about goose

[mfridman]

Shouldn't it be the below, note the -- +goose ENVSUB ON annotation towards the top (not sure if you had a copy/paste error).

-- +goose ENVSUB ON

-- +goose Up
-- +goose StatementBegin
CREATE TABLE ${GOD}.test (id int);
-- +goose StatementEnd

-- +goose Down
-- +goose StatementBegin
DROP TABLE ${GOD}.test ;
-- +goose StatementEnd

[vigneshnvxi]

@mfridman thanks for your response . I tried as you mentioned still I get the same error

❯ cat 20240130095049_test_1.sql
-- +goose ENVSUB ON
-- +goose Up
-- +goose StatementBegin
CREATE TABLE ${GOD}.test (id int);
-- +goose StatementEnd

-- +goose Down
-- +goose StatementBegin
DROP TABLE ${GOD}.test ;
-- +goose StatementEnd

output 

❯ ./goose -v up
2024/01/30 18:35:57 -- +goose ENVSUB ON
2024/01/30 18:35:57 StateMachine: ignore comment
2024/01/30 18:35:57 -- +goose Up
2024/01/30 18:35:57 StateMachine: set 0 => 1
2024/01/30 18:35:57 -- +goose StatementBegin
2024/01/30 18:35:57 StateMachine: set 1 => 2
2024/01/30 18:35:57 CREATE TABLE ${GOD}.test (id int);
2024/01/30 18:35:57 -- +goose StatementEnd
2024/01/30 18:35:57 StateMachine: set 2 => 3
2024/01/30 18:35:57 StateMachine: store Up statement
2024/01/30 18:35:57 StateMachine: set 3 => 1
2024/01/30 18:35:57
2024/01/30 18:35:57 StateMachine: ignore comment
2024/01/30 18:35:57 -- +goose Down
2024/01/30 18:35:57 StateMachine: set 1 => 4
2024/01/30 18:35:57 -- +goose StatementBegin
2024/01/30 18:35:57 StateMachine: set 4 => 5
2024/01/30 18:35:57 DROP TABLE ${GOD}.test ;
2024/01/30 18:35:57 StateMachine: ignore up
2024/01/30 18:35:57 -- +goose StatementEnd
2024/01/30 18:35:57 StateMachine: set 5 => 6
2024/01/30 18:35:57 StateMachine: ignore comment
2024/01/30 18:35:57 Begin transaction
2024/01/30 18:35:57 Executing statement: CREATE TABLE ${GOD}.test (id int);

2024/01/30 18:35:57 Rollback transaction
2024/01/30 18:35:57 goose run: ERROR 20240130095049_test_1.sql: failed to run SQL migration: failed to execute SQL query "CREATE TABLE ${GOD}.test (id int);": ERROR: syntax error at or near "$" (SQLSTATE 42601)

[mfridman]

Ah, my bad. The feature got merged after https://github.com/pressly/goose/releases/tag/v3.17.0 was released, which means it was merged bu is still "unreleased" on main.

[vigneshnvxi]

@mfridman thanks for your response. since I saw this feature present in Readme.md I was belief that it was part of release. When will be the next release @mfridman a tentative data will be good.

[mfridman]

I'll cut a release in the next few days.

[mfridman]

@vigneshnvxi I've tagged a new v3.18.0 release, so pull the latest goose binary and give it a try. If any issues let us know!

goose --version
goose version: v3.18.0

[mfridman]

Going to close this issue, as I think it should be resolved with the latest release (see previous comment).

But if you continue to run into issues let us know.