Coder Social home page Coder Social logo

ocean_bgc's Issues

missing parenthesis in Nitrogen burial fraction

Hello,

We were looking into Nitrogen burial in COBALT and were puzzled by line 7810:

cobalt%frac_burial(i,j) = 0.013 + 0.53*fpoc_btm**2.0/((7.0+fpoc_btm)**2.0) * & cobalt%zt(i,j,k) / (cobalt%z_burial + cobalt%zt(i,j,k))

Is the a missing set of parenthesis in the numerator?

Best,
Sam and Fan

How to account for surface salt restoring fluxes?

Hi. We've recently ported our ocean BGC model WOMBAT (Whole Ocean Model or Biogeochemistry And Tropic dynamics) to the generic_tracers framework so that we can use it with both MOM5 and MOM6.

That model includes virtual flux adjustments to a few tracers when surface salt restoring is applied via a salt flux in the ocean model. Basically I need to adjust the stf array for a few tracers according to:

stf = stf + salt_restore * tracer_global / salt_global

where salt_restore is the restoring salt flux applied by the ocean model, and tracer_global and salt_global are constant parameters.

Obviously I need to modify/extend the generic_tracers API to allow passing the restoring salt flux from the ocean model, but there's no clear clean way to do this. For example, on face value it looks as though the virtual flux adjustments could be done in a generic_WOMBAT_update_from_coupler routine inside generic_tracer_coupler_get, but:

  • generic_tracer_coupler_get is called before the restoring fluxes are calculated in MOM5
  • generic_tracer_coupler_get is not called at all in MOM6

I'm a little surprised I'm the first to want to do this. Are COBALT, BLING etc never run with ocean salt restoring? Does anyone out there have suggestions for where/how the virtual flux adjustments could be included?

documentation wanted

Users are asking for the code documentation, preferably embeded in the code with doxygen.

We can also think about adding a wiki-like guide.

Coupling sea-ice BGC tracers?

Hi. I'm curious whether anyone out there has thought about or tried coupling sea-ice BGC tracers to a generic tracer package? The FMS coupler types only support:

  • air_sea_gas_flux_generic
  • air_sea_gas_flux
  • air_sea_deposition
  • land_sea_runoff

flux types, and none of those are appropriate for sea-ice tracer coupling.

Error in building mocsy: multiple definition of "MAIN__"

Hi
I am trying to build MOM6 with ocean_BGC(I want to use COBALT). I have cloned this repository in "src/MOM6/config_src/external/GFDL_ocean_BGC". While building i am facing the following issue:

test_mocsy.o: In function `MAIN__':
/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_mocsy.f90:3: multiple definition of `MAIN__'
test_phizero.o:/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_phizero.f90:3: first defined here
test_vars.o: In function `MAIN__':
/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_vars.f90:3: multiple definition of `MAIN__'
test_phizero.o:/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_phizero.f90:3: first defined here
MOM_driver.o: In function `MAIN__':
/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/drivers/solo_driver/MOM_driver.F90:1: multiple definition of `MAIN__'
test_phizero.o:/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_phizero.f90:3: first defined here
test_mocsy_buffesm.o: In function `MAIN__':
/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_mocsy_buffesm.f90:3: multiple definition of `MAIN__'
test_phizero.o:/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_phizero.f90:3: first defined here
test_errors.o: In function `MAIN__':
/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_errors.f90:3: multiple definition of `MAIN__'
test_phizero.o:/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_phizero.f90:3: first defined here
test_kprime.o: In function `MAIN__':
/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_kprime.f90:3: multiple definition of `MAIN__'
test_phizero.o:/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_phizero.f90:3: first defined here
test_kzero.o: In function `MAIN__':
/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_kzero.f90:3: multiple definition of `MAIN__'
test_phizero.o:/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_phizero.f90:3: first defined here
test_derivnum.o: In function `MAIN__':
/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_derivnum.f90:3: multiple definition of `MAIN__'
test_phizero.o:/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_phizero.f90:3: first defined here
test_buffesm.o: In function `MAIN__':
/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_buffesm.f90:3: multiple definition of `MAIN__'
test_phizero.o:/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_phizero.f90:3: first defined here
test_derivauto.o: In function `MAIN__':
/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_derivauto.f90:3: multiple definition of `MAIN__'
test_phizero.o:/scratch/ds2/km7623/MOM6_BGC/MOM6-examples/build/gnu/ocean_only/repro/../../../../src/MOM6/config_src/external//GFDL_ocean_BGC/examples/test_phizero.f90:3: first defined here
make: *** [Makefile:1402: MOM6] Error 1

The test cases in "mocsy/example" are creating a problem.

Can you help me here?
(using mpiifort,mpiicc)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.