Comments (1)
Hi Sam and Fan,
Thanks for raising this issue.
Looking at the code, I can see that it is definitely ambiguous. It is also not helped by line 7809, which reflects an older bug that was fixed a while ago. We definitely need to remove line 7809 to avoid future confusion.
For this line (lines 7810-7811), it is doing what it is supposed to as it is currently written -- the baseline is 1.3% burial and then burial increases with flux of POC to the bottom (following Dunne et al. 2007), which ramps up as depth increases. Though we agree that the lack of explicit parentheses makes it ambiguous.
Regarding an alternative, both @charliestock and I are open to an alternative formulation if after scientific evaluation, you guys (Resplandy lab) think that the 1.3% should also be subject to the depth-based ramp. In reality, the number of grid cells where the depth is very shallow and flux of POC to the bottom is zero is likely to be minimal, but if changing the parentheses improves the model representation of burial in shallow coastal areas, then let us know and we can discuss.
thanks,
Jessica
from ocean_bgc.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ocean_bgc.