leandrobarone / python-ascii_magic Goto Github PK

When trying to use ascii_magic.Modes.HTML, this is generated instead.

Code:
import ascii_magic
output = ascii_magic.from_image_file("dogedemo.png", mode=ascii_magic.Modes.HTML)
ascii_magic.to_terminal(output)

Result:

Since there is black/transparent area, the brightness, saturation and etc will look different (e.g. darker) from the original image. Any idea on the correction?

Traceback (most recent call last):
File "convert.py", line 1, in
import ascii_magic
File "/home/gustavo/.local/lib/python3.8/site-packages/ascii_magic/init.py", line 2, in
from PIL import Image, ImageGrab
File "/usr/lib/python3/dist-packages/PIL/ImageGrab.py", line 26, in
raise ImportError("ImageGrab is macOS and Windows only")
ImportError: ImageGrab is macOS and Windows only

hi,
I think the api adress you were using for craiyon is no more working:
When i tried to use your example I had a "JSONDecodeError: Expecting value: line 1 column 1 (char 0)" visibly because the request you use had no answer.
I take a look and the "https://api.craiyon.com/draw" you used is no more existing.
I tried to replace in your code by the old version of Craiyon (https://backend.craiyon.com/generate) and by the new one (https://api.craiyon.com/v3) without success.
But that does not change that i appreciate a lot your library :)

I want my ascii art to be in under 2000 words

but it gave me error

how to fix this?

The current behaviour of the optional char argument is to wrap the passed string in a list.

I don't why, but this actually limits the usefulness.

Simply removing the list, allows users to pass a string with the set of chars they wish to use.

Simply change
chars = [char] if char else CHARS_BY_DENSITY

To
chars = char if char else CHARS_BY_DENSITY

Strings are already iterable in python. This is also the current behaviour if char is None (CHARS_BY_DENSITY is just a string with all characters to be used).

Empty strings ('') evaluate to False, while strings with contents evaluate to True:

>>> test1 = ''
>>> test2 = '1'
>>> if test1: print(test1)
...
>>> if test2: print(test2)
...
1
>>>

It would be very helpful if you could tag releases as well. This would enable distributions who want to run your tests to fetch the package from GitHub instead of PyPI, where the tests are excluded.

Thanks