Coder Social home page Coder Social logo

iguana_acs_fix's Introduction

Iguana's Overhaul, fixes

A mod, consisting of fixes for Amazing Cultivation Simulator, tries to avoid content/functional changes.

Currently implemented fixes

  • Daemonia Wonder Fix - Changes the System_LearnGreateBuilding MapStory, making the Daemonia Wonder grant the previously unattainable Formation Manual
  • Altar of Death Fix - Changes the Building_WanGuXieFaTan Building, making it usable as a Cultivation Seat
  • Qi Barrier Attachment Fix - A dirty fix, making Qi Barrier Attachments functional
  • Unorthodox Manual Fix - Changes the descriptions for Unorthodox Manuals. Also changes Spell Cooldown Property to a MinValue of -0.5
  • Ancient Formations Condition fix - Implements the faulty conditions for Ancient Formation Nodes. Law Elements, and in some cases, Item requirements.
  • Yaoguai Fragment Skill Level fix - Fixes Yaoguai Rebirthing related Skill issue, where Skill Levels aren't what they are supposed to be (not to be mixed up with the rerolling of Skills in general, which is a feature)
  • Fix Max Qi Story - Correct Story_2 and Story_Cold's reversed comparison, which prevents the extra Base Max Qi % outcomes to be triggered during a playthrough.
  • Various text issues, full details here
  • Fix Event A Different Time - The current event "A Different Time" is corrected to have its designed effect in-game:
    • lasts for 6 days (not 6 seconds as is the case in the base game)
    • attacks of savage men are more likely for its duration (same as the base game)
    • attacks of bandits are more likely (not Unearthing Artifact as is the case in the base game due to a off-by-one error)
  • Fix Craftsman trait Alchemy bonuses - They weren't working as intended.
  • Add Food tag to Ginkgo - allows it to be chosen by your outer disciples as a somewhat last resort food automatically.
  • Fix Female Fei Constitution - for some base age range the Female Fei has a weirdly high baser values.
  • Fix Treasure Hunt for Red Ginseng using Mining Skill instead of Farming
  • Fix Qin Muxue's (Fox pet) Core bonus at the Learning growth stage
  • Fix Rabbit Yaoguai's adventure fly speed bonus - wasn't working as intended. A basic change, not a full rework.
  • Fix the Max Qi value of Miao (turtle pet), Xianxian and Xiuxiu (panda pets) for people not playing with the "Loose Core" Immortal Tribulation.
  • Greedy Personality Heart Unlockable - Changes the gifting related threshold from 70 to 60, meaning attainable before Heart Guard has been unlocked.
  • Fix the Artifact Power Bonus for Xianxian and Xiuxiu (panda pets)
  • Fix State 3 Equilibrium : The game may sometimes mistakenly displays your disciples has having food equilibrium despite them still having unsustained food needs
  • Fix Refinement success chance estimation - Properly evaluates the specter, tao and spiritual refinement success chances.
  • Potential Value rework (Curious) - A workaround for Curious (Cat Yaoguai Trait), making it work as originally intended. Turns existing Potential boosts from AddV To BAddV, making the AddP value from the trait actually functional.
  • Fix Qi Recovery during Golden Core - property shows the disabled Qi Recovery during Golden Core breakthroughs (and others situations where Qi recovery is disabled)
  • Correct Rock Yield - Rock yield is lower than it should be unless you are playing with a map reveal mod, this corrects the issue for everyone
  • Add Resources in World Map (Optional) - add spirit stones and influence numbers and icons on the top right of the screen in the world map. Works on Xbox Gamepass version.
  • Correct Caged Animal's Perception (Optional) - remove the 10 Perception from caged animals.

Install instructions

Download the latest release, extract the iguana_acs_fix into the Mods folder. If the release is behind the Main version and you want to update to the preview version, download the repository directly, and extract the contents of the archive into the iguana_acs_fix folder, located in the Mods folder. (Due to the inclusion of Harmony Patches, it's best to stick with the Release.)

Activate the Mod in Mod Manager, make sure to load it after any of the prerequisite Mods.

For ensuring that Patches are loaded, restart the game.

Configuration

Some of the changes are configurable on a per-save basis. To do so, in the menu item System's dropdown select "MLL设置".

screenshot of the system menu dropdown with the cursor on the "MLL设置" option

You can then disable the changes you might not want to apply to your save. Some of these changes require you to save and relaunch the game then load to apply.

screenshot of the MLL Configuration menu

In case the mod modifies XML files, to disable it entirely you'll need to remove the XML files related to the mod from its subfolders.

Compatibility with other mods

The full list of changed entities can be seen at the bottom. This mod does not guarantee compatibility with any of the mods that also change those entities.

Suggested Load Order

List of changed entities

Below is a list of changed entities. To revert a particular change from the mod, either comment out the relevant lines and entities, or delete the files in question. Changed files in the Language\OfficialEnglish directory are related to translation and can be reverted by removing them.

For example, removing the Ancient Formation Condition fix requires the removal of iguana_acs_fix\Settings\Zhen\Node\ZhenNode_Suit.xml, as well as the corresponding file under Language\OfficialEnglish.

Items

  • Item_Ginkgo - Add Food tag to Ginkgo

MapStories

  • (MapStory_System) SystemLearnGreateBuilding - For Daemonia Wonder Fix
  • (MapStory_FillingLv1) Story_2 and Story_Cold - "Fix Max Qi Story" related

Buildings

  • Building_WanGuXieFaTan - For Altar of Death Fix

Properties

  • NpcFight_SpellCoolDownAddP - For Unorthodox Manual Fix (Spell Cooldown)
  • LsPandaLingMaxValue (LsProperty_LsPanda) - DLC Pets Max Qi fix
  • LsPandaFabaoPowerAddP (LsProperty_LsPanda) - DLC Panda pets Artifact Power Bonus fix
  • LsXuanWuLingMaxValue (LsProperty_DLC_WuDang) - DLC Pets Max Qi fix

Modifiers

  • Lingzhi_Esoterica_JinSha - Potential Value rework (Curious)
  • Gong4_LvUpEsoterica_1, Gong5_LvUpEsoterica_2, Gong5_LvUpEsoterica_3, Gong5_LvUpEsoterica_4, Gong5_LvUpEsoterica_5, Gong6_LvUpEsoterica_4, Gong7_LvUpEsoterica_4 - Potential Value rework (Curious)
  • Gong9_Esoterica_10 - Potential Value rework (Curious)
  • Gong13_Esoterica_3 - Potential Value rework (Curious)

Elixirs (Dan)

  • Modifier_Item_XianShiChongSheng, Modifier_ItemXieShiChongSheng - Potential Value rework (Curious)

Relics

  • Potential Bonus (FSZhenWu_41), Yin Vessel (SP_FSZhenWu_4) - Potential Value rework (Curious)

Spirit Roots

  • (All Elemental) Fiend/Spirit sympathy - Potential Value rework (Curious)

LingShou (Pets)

  • property GrowPercent - Fix Qin Muxue's Core stat

Features

  • Craftsman - Fix Craftsman trait Alchemy bonuses
  • Rabbit_Fast - Fix Rabbit's Adventure Fly Speed bonus
  • Intellectual (Reader), Warrior (Warrior), Talent (DeepPotential) - Potential Value rework (Curious)

Npc

  • Fei - Fix Female Fei Constitution

Yaoguai Shards

  • Skygazing (SeeTheSky), Ringing (LickSelf) - Potential Value rework (Curious)

Talisman

  • Latent Talisman (Spell_TongTian3) - Potential Value rework (Curious)

Other files

  • Settings\Practice\FabaoHelian\FabaoHelian.txt - For Qi Barrier Attachment Fix, utilizes ID's 72,73,74
  • Settings\Esoterica\EsotericaLables.txt - For Unorthodox Manual Fix, uses the entire OfficialEnglish file
  • Settings\Zhen\Node\ZhenNode_Suit.xml - For Ancient Formations Condition fix, nearly all entities changed
  • Scripts\main.lua - main LUA mod loading utility
  • Scripts\fix-event-a-different-time.lua - Related to "Fix Event A Different Time" change
  • Scripts\MapStory\MapStory.lua - Fix Treasure Hunt for Red Ginseng using Mining Skill instead of Farming
  • Scripts\fix-state-3-equilibrium.lua - Fix State 3 Equilibrium
  • Scripts\correct-rock-yield.lua - Correct Rock Yield
  • Scripts\correct-caged-animals-perception.lua - Correct Caged Animal's Perception

Game Constants

  • GameDefine.BeautyValueDesc - Beautiful Rooms mistakenly rated Common
  • Panel_ThingInfo.FoodF2 - Fix State 3 Equilibrium

Functions

  • XiaWorld.HumanoidEvolutionMgr.ModifyNpcByFrag - For Yaoguai Fragment Skill Level fix, a Postfix, compatible with other Postfixes to the same function
  • Wnd_JianghuTalk.GiveGift2Target - For Greedy Personality Heart Unlockable, a Transpiler changing the ldc.r4:70 to ldc.r4:60
  • UILogicMode_IndividualCommand.CheckThing - Fix Refinement success chance estimation
  • Wnd_World.OnShowUpdate, Wnd_SchoolTrade.__selectyes, Wnd_ZhaoLanWindow.OnInit, Wnd_OpenOutsWindow.UpLevelSideBuild,Wnd_World.OpenRegion - Add Resources in World Map
  • ThingFlag.BuildActionDict - Golden Core Qi Recovery
  • Panel_NpcPractice.OnUpdate_Nei - text issues

How to Contribute

Any Issues/Pull Requests are welcome. To ensure a similar level of quality between all parts of the mod, here's a few guidelines.

When changing vanilla aspects, keep in line with the original naming logic.

  • If the original was MapStory_Item.xml, the PR should use the same filename with MapStory_Item.xml.

If the fixes exist as a standalone mod, include a link to it.

Credits/Contributions

  • ucddj - Fix Max Qi Story, text issues, Fix Event A Different Time, Craftsman trait, Fei attributes, Pets stats, State 3 Equilibrium, Golden Core Qi Recovery, Rock Yield, Caged Animal's Perception, Add Resources in World Map

iguana_acs_fix's People

Contributors

ucddj avatar iguanacore avatar

Stargazers

Amr avatar avatar Antonio Carrillo avatar What avatar

Watchers

avatar

Forkers

ucddj

iguana_acs_fix's Issues

Reword Dying (no timer), Flopped Dying and Unconscious Dying for clarity

Suggestions made:

  • Dying -> Mortally wounded
  • Unconscious Dying -> Bleeding out

I don't know if both need to be reworded, at least Unconscious Dying, Flopped Dying and Dying (without timer) should be switched out to something else to clarify that it is not the same.

May check the GPL/Google translations for suggestions.

Text issue: bedrooms moodlets aren't precise enough

The moodlets:

  • BedroomExpect7: Resplendent Room
  • BedroomExpect6: Exquisite Room.
  • BedroomExpect5: Better-than-average Room
  • BedroomExpect4: A Typical Room
  • BedroomExpect3: Horrid Housing
  • BedroomExpect2: Frightening Housing
  • BedroomExpect1: Atrocious Housing
  • BedroomFengShuiExpect1: Deficient Feng Shui
  • BedroomFengShuiExpect2: Unlucky Domicile
  • BedroomFengShuiExpect3: Unlivable Domicile
  • BedroomFengShuiExpect4: Good Feng Shui
  • BedroomFengShuiExpect5: Auspicious
  • FengShui1: Good Feng Shui
  • FengShui2: Favorable Feng Shui
  • FengShui3: Not the Best Feng Shui
  • FengShui4: Bad Feng Shui
  • FengShui5: Poor Feng Shui

and their descriptions don't correctly convey that they're only related to the bedrooms and should be worded lightly differently to avoid confusions.

While the imprecisions could be argued to be deliberate - which is hard to assess, in any case the damage this imprecision creates trumps whatever the initial intent may be and this ought to be changed.

Implement iguana_Cat_Pot_Rework

Implement an existing mod (iguana_Cat_Pot_Rework).

A fix due to the original effect (Cats having increases Potential) doesn't work in vanilla.

While the way it's designed can be debated, the current version can be added as is.

Dialogue : Traces is shared only if NPC interested in, so sometimes "known" NPCs have no info

This is related to the "pity info" when the game generates one piece of information about a NPC to share with the player when they're not actually interested in them.

In case the randomly chosen info is Traces, the npc will have nothing to tell you about them.

This makes the "rules" of the social minigame less predictable and harder to understand for players, so something ought to be done, although a number of options are possible to address it.

Finish and implement Tribute Rework

Finish and implement an existing mod (iguana_TributeRework).

Wudang has a bugged tribute related event. The entire tribute system needs a rework, as there's some overlap with possible event IDs. Such a rework would also make it possible for any custom Sects to properly give tributes, not just Wudang.

Few issues with pets

There are several issues with pets I personally have encountered in gameplay. Not sure how many of them can be handled by mod.

  1. All pets - when they first hesitate about any action, encouraging them even to maximum does not immediately trigger this action. Discouraging, however, always immediately does, unless it is to minimum level (forbid). So the usual flow for every time pet hesitates is "up, up, up, down, up" to make pet waste no time and do it right now. Would be better: changing it always triggers action, upward - do it now, downward - deny this time.
  2. Dog only (maybe other compatible) - this particular action is always set to middle in global list (above), even if actual value is different (bottom). Seems to be only visual bug
    image
  3. Encountered with panda, but may be true for other too. When pet is allowed to feed laxative pill, he continuously chose exactly same target time after time. This led to this target have pill and weakened debuff statuses to be active at the same time. For outer disciple it prevents ability to move - character walks somewhere, but in fact stays in one place until weakened debuff ends. This can often lead to death from starvation/thirst if current action (go to do something) is not manually interrupted to allow to pull food from mini universe. Would be better: when choosing target to feed pill, exclude characters with active weakened status.

Exploration counter issue

"if you explore place until one spot left, then read book that explores last place for you, exploration% does not increase"

Dupe stuff with possession / hunt

Maybe hard, need to replicate in-game to check

When a possessed Animal is killed they can still use Greater Posession to possess another animal. However if that animal's corpse is revived somehow (Puppet mastery) and they were able to awaken intelligence then you can still trigger the awakening on that puppet. So the second animal now has the stats of the dead animal and the dead animal can now awaken and inherit the cultivators stats. This can be repeated infinitely
Possess Animal 1 > Kill Animal 1 > Possess Animal # 2 > Soul Mastery Animal #1's Corpse > Awaken Animal 1
then animal 2 can also awaken with same law manual and everything else (Greater Possession of course)
or repeat the process

https://discord.com/channels/608499065071861761/608499065071861764/1031253690641817683

Add Zombies again

There's a number of bugs within the implementation code.

As zombies are somewhat powerful - not particularly as opponents, but as a source of soul gems that doesn't require soul chanting or hell gate -, this will affect the balance of the game and thus may need a toggle of sort or at the very least further balance considerations.

Search bar improvement

"improve some search bars. Search bar in the mentor menu, make search non- case sensitive. Have a search bar for the buildings menu."

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.