haystack / nb Goto Github PK

to reproduce error:

• clear cookies but remain on the main dashboard.
• create a class after your cookies were cleared.
• the class will be added to the DB with "null" as the "creator" value.
• class will not be loaded to the UI.

this is a problem also for people who leave their tabs open but have their session cleared, we shouldn't allow requests without any authentication which is also a problem with other parts in the system that needs to be handled.

• email notification?

i tried pages that are from right to left and the comments experience was off. buttons slightly changed location on the screen. Also there is a problem when a link is added that contains more characters of that right-to-left language.

Show error message on NB client when a student tried to log in on a source that is not part of their classes.

Description: If a user tries to sign up for nb with an invalid email address, the system detects it and does not allow the user to sign up but doesn't report anything to the user.

Reproduction Steps:

1. Navigate to the account creation page
2. Fill in all the fields but do not include an ending tag for the email (e.g. don't include @mit.edu)
3. Click sign up

Expected Behavior:
An error message appears such as: "Invalid email address. Try again!"

Actual Behavior:
The sign up button remains selected but no action occurs

session doesn't keep track of users' info

It might be nice to have one spot for the function to add new folders and files. In a window in other applications, you can click File for a new tab or new folder, but either way, those are both found in one spot. In that same way, it might be good to keep the current options where they are but also add one button at the top that says "New," with a dropdown for file and folder that functions the same way as the other buttons.

Allow instructors to add students to sections.

accessing nb on http will show bad gateway (Nginx)

This is just my personal opinion but the icons in the top right corner (the three blue ones, including bookmark function) seem a bit too "hidden" -- I feel like if we want students to actually use those features, we should display it more prominently and make it as easy for them to use as possible!

As shown bellow the URL is pointing to the local host, even though the request came from a deployed instance (e.g. https://jumana-nb.csail.mit.edu). URL should be dynamic.

related to merged PR #52

The comment box should be taller. Or at least should grow to make room for longer comments.

Through the CSV instructors assign section.

On the user page for a course, allow an instructor to swap student/instructor statuses for users who aren't the user logged in.

related to issue #18

I like that you can sort comments by most recent; maybe it would be good to show timestamps as well?

if the same URL is added to another class, the annotations from all classes that this URL is part of will be displayed.

to help differentiate between two ppl with the same name.

handle update user profile

right now username is case sensitive. (i.e. Username != username)

It would be great to be able to set an exact time (e.g., 23:59) to an assignment's due date, in addition to the general date.

when you log in to a source on safari, you will get an error.
This could be solved at the browser level by asking users to allow cross-site tracking as shown in the screenshot. This is not convenient and needs to be addressed from the backend.

Solution: --> use JWT instead of cookies.

Currently in NB class is unique to the system. Also, a source is unique to a class and so on. As a result, you can only name one class a specific name in the system (e.g. one class named art in NB!). The same is for sources on classes level.

https://en.gravatar.com/

Instead of separating out "enrolled as student" and "enrolled as instructor", have a single list. Most people will add an icon or other indicator whether you are an instructor for a class.

issue #14 depends on this

It would be wonderful to be able to move files/folders within directories, either by clicking through options or by dragging and dropping.

Expire links from #52 after a certain period of time

link students to set their name, username, etc. (similar to pw reset functionality)

There should be a distinct URL associated with each course in NB---e.g., nb2.csail.mit.edu/course/{some id}. at present, clicking on a course takes you to the course page but you are still at the same (root) url. Instead you should get a course specific url. This does not require fetching a new page from the server: history.pushState can update the url without a reload.

Personally speaking, I tend to forget my usernames for different things -- it might be a good idea to let people sign in with their emails in addition to or instead of username.

for example Assignment Due and Last Updated are both "invalid date"

to reproduce error:

• Go to main page where files are add
• try to set date for assignment due
• "Invalid date is show" -> it should show a valid date

Having a "forgot my password" + reset function is necessary for students who forget their passwords!

It would be wonderful to have options to change file/folder names, as well as options to delete them.

to reduce error

As we reimagine the codebase for NB one property of NB has been problematic and at odds with how we'd like to use and develop OER content in LibreText: the hard link between comments and a specific HTML document and its exact content.

One URL:one content:one set of comments

Why is this problematic? Several issues have come up.

1. If an instructor has assembled a set of readings that they are happy with (a set of URLs that work for them) at the moment they can not reuse those same pages for a second instance of the course without displaying comments from a previous quarter/semester. Comments just pile up. This means that the instructor either (a) needs to create entirely new pages each quarter (if they want to preserve previous content and associated comments) or change URLs. Neither of these is particularly intuitive or convenient for the instructor and drives the LibreText maintainer nutty.

2. If content on pages changes between terms, NB naturally doesn't know how to deal with that. This is problematic if we want to create readings by transcluding together pages from a "master" set that is iteratively modified/improved or to use transclusion to create different instructor-specific variants of readings that will be reused but all benefit from changes happening to the "master" modules. What happens now is that before each term, edits are made to master modules and then new course readings are complied by cutting and pasting into new HTML documents. This isn't too terrible for those of us with grants who are invested in doing experiments with NB but a rather mysterious and large barrier for those who just want to be "regular" users and who might still want an ability to review previous quarter/semester data while still updating or changing reading order etc.

For a quarter/semester or two it's fine but this is also starting to create a mess in LibreTexts repositories.

I have been wondering if it's possible for NB to take "snapshots" of readings that would allow (a) a single URL to be used by instructors for readings and (b) allow changes between terms. I feel like technically, this should be feasible (though require more storage space somewhere). Various other options - like clearing comments of previous terms for those who don't want to conduct studies - might be lighter weight solutions for many instructors. Other ideas?

we have 2 use cases (each has two “perspectives”: student and instructor)

Use case 1: getting comments. 
- Students —> get comments that belong to their section + global.
- Instructors —> get all comments in class (all sections + global).

Use case 2: posting comments. 
- Student —> post to their own section only. 
- Instructor —> post on global? 

From Marc (UC Davis):

Allow instructor more control over the due date, particularly the time. Allow setting the due time to the minute. For example: 11:59PM. At the moment it’s limited to 15 minute increments.
Use the assignment due date to determine whether comments were submitted on time. At the moment there is a second menu in the grading interface that seems to “override” the due date.

Each user should have a unique email associated with the account i.e. a single email should not be associated with more than one user

Need to create a migration to make this column unique.

right now, class name is unique across the whole DB. Make class name not unique.