Coder Social home page Coder Social logo

Comments (2)

karger avatar karger commented on August 11, 2024

Unclear what you mean here. If the student is not logged in, then we don't know who they are and therefore we can't know which classes they are in. If the student is logged in, then we know that they do not have this source in their class but it isn't clear that's an error. I might visit all sorts of random pages that use NB for classes I'm not in. It isn't an error for me to visit those pages. We might want to provide some kind of brief informational popup saying this page is in an NB course in which you are not enrolled, but I think it should fade away pretty fast.

from nb.

JumanaFM avatar JumanaFM commented on August 11, 2024

That’s correct, David. The way NB works is that sources are part of classes. The current logic is that annotations are stored if they are on a source that is part of a class. When a user tries to use NB when it’s not part of the system, the client plug-in looks like it’s working, however it sends a CORS error and doesn’t store any information. The other case is when an NB user tries to access a source that is added to NB, but is not part of their classes, the plug-in will allow them to annotate without storing their session nor prompting them to do anything. If we want to allow a user to annotate on a source that is not part of a class then we have to change the logic of nb and add a use case for personal use (personal class maybe?) for the MVP and to avoid confusing students and have their annotations lost when they access a wrong URL, we provide a message to alert them. Does that clarify the issue?

image

from nb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.