habrador / unity-advanced-shaders-tutorial

Implementation of advanced shaders in Unity like raytracing, interior mapping, parallax mapping

Hi!

Welcome to the #6135 most starred GitHub account in the world (Source) and the #126 most followed account in Sweden (Source)!

The one who's running the show is me, Erik Nordeus. I'm an imagineer (creative engineer) who's interested in the intersection between art and engineering. I design mostly Unity and Blender projects. After finishing my mandatory military service, defending King and country, I got a master's degree in Mechanical Engineering from the Royal Institute of Technology (KTH) in Stockholm, Sweden, where I also live. The rest is history...

My goal with my open source projects is that the code should by as easy as possible for you to understand, so I love to comment it! I once wrote a book about a guy called Elon Musk, and I read somewhere that authors are the best at commenting code because they know how to explain complicated topics in a simple way. Thus I hope I will fulfill my promises!

Connect With Me

• 🌳Linktree
• 🐦X
• 📺YouTube
• 🎨Artstation

Experiences

Languages: C# • Python • JavaScript • HTML • CSS • MATLAB • PHP • MySQL

Tools: Visual Studio • Blender • Unity • Krita

FAQ

• Are you related to the company Nordeus? No, my surname Nordeus is a family name. If you googled Nordeus before the Nordeus company was founded you could only find people with that name in Sweden, so I'm not sure how they got the name. But they follow me on Twitter! Kinda funny that both of us are into Unity.

THANK YOU...

...everyone who has used and contributed to my open source projects!

If you use the code for something cool then you can @ me on twitter.com/eriknordeus and I promise to retweet!

unity-advanced-shaders-tutorial's Issues

Parallax shader visual depth changes depending on view angle

Thank you for this great tutorial. I am new to shaders and it is really a huge help.
I played with the parallax shaders and discovered that their visual depth is changing depending on the view position. The sharper the view angle, the less deep they look.
My guess is that stepDistance should depend on view direction, actually we should travel along the ray the longer the sharper the view angle to reach imaginary intersection with next layer.
I added following modifications which seem to fix the issue:

  struct Input 
  {
	  //What Unity can give you
	  float2 uv_NoiseTex;
  
	  //What you have to calculate yourself
	  //The camera direction in tangent space
	  float3 tangentViewDir;
	  // cos of view direction to surface normal
	  float cos;
  };

in vert:
o.cos = -dot(normalize(worldViewDir), normalize(worldNormal));
and in surf:
float stepDistance = 0.01/ IN.cos;

I am not sure this is an optimal solution, so please review. Thank you again