Coder Social home page Coder Social logo

Comments (6)

getify avatar getify commented on August 10, 2024

I don't think there's a spec for Promise.resolve(..), so I don't know what it's supposed to do. It doesn't surprise me, but it bothers me, that Chrome and FF don't agree.

@domenic @briancavalier do you have any insight into this?

Promise.resolve(2) would obviously be sync, so I'm not sure why the above should be forced to be async if you are handed a synchronous thenable.

from native-promise-only.

getify avatar getify commented on August 10, 2024

A potentially relevant portion of the spec:

http://promisesaplus.com/#point-49:
"If x is a promise, adopt its state [3.4]: "

It's unclear to me if "adopt" must be sync, or must be async, or can be either as you see fit.

[Update] The latest ES6 spec draft says this about Promise.resolve(..). Still unclear to me the answer to your test case. Should be nailed down though one way or the other. Having them not agree is intolerable. :)

from native-promise-only.

domenic avatar domenic commented on August 10, 2024

Oh dear. I think you found a hole in the ES6 spec. Following the spec, it should be 1; it executes the then synchronously. But, I believe it's been established in previous discussions that the result should be 0; you should never call untrusted user code (like a then method) unless the stack is clear. It is to avoid these exact scenarios where untrusted thenables can interfere with the invariants of the surrounding code, that this is included.

Opening an issue on domenic/promises-unwrapping right now. Will hopefully have a patch soon.

from native-promise-only.

briancavalier avatar briancavalier commented on August 10, 2024

Yes, indeed. It absolutely should be 0. Nice find, guys.

from native-promise-only.

briancavalier avatar briancavalier commented on August 10, 2024

It's unclear to me if "adopt" must be sync, or must be async, or can be either as you see fit.

Specifically to answer this: "as you see fit" Yes. Basically, you can do whatever wizardry you want as long as the stack-clearing invariant holds.

from native-promise-only.

getify avatar getify commented on August 10, 2024

Thanks for the clarifications and for the great bug catch! Fix incoming for this lib.

from native-promise-only.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.