Missing tag for version 0.7.8-a used by jQuery about native-promise-only

[getify]

Shipping minified code is not in violation of "OSS rules" as far as I'm aware. It's pretty common. I believe they should be shipping it with the copyright notice/license included, though.

I've been unable yet to find this "jquery 1.12.4" distribution that you say includes native-promise-only. Can you link me to where to see it?

[mirabilos]

Sure, look at https://github.com/jquery/jquery/tree/1.12.4/external/npo

I’ll answer on the source code issue in jquery/jquery#4445

[mirabilos]

The correct commit to tag is probably commit f3cc8e8 but I cannot get the exact binary they have in the jQuery repo, probably due to a version difference in the minifier (Debian has 3.6.0-3 while your package.json mentions 2.4.8 with a tilde(?)), which makes this kinda tricky (and is another good reason for why people ought to always include source code).

[mirabilos]

Yes, that is the correct commit. I was able to reproduce it by taking a throwaway system with npm, installing [email protected] via npm, then running (uglifyjs -m -c --comments '/^!/' lib/npo.src.js; echo) >npo.js on the command line. The result is bytewise identical.

[getify]

I don't see any particular reason you're concerned here though? Why should I go back and add an old tag to some old release simply because jQuery chose to use that version (from npm)?

You can see the code here on github, so that's the concern you had, right?

[mirabilos]

I can see “some” code, but not the exact correct code. I had to invest a lot of time to figure that out, and others are not as skilled in software archæology.

[getify]

It's easy to get the exact code:

npm install native-promise-only@0.7.8-a

Inside, you'll find the original source code as well as the minified code (not binary) and even the script that did the minification, if you want to recreate it.

I recognize you had some difficulty researching to figure this out, but it seems clear to me everything is resolved now.