Coder Social home page Coder Social logo

Support IE8 about native-promise-only HOT 5 CLOSED

getify avatar getify commented on August 10, 2024
Support IE8

from native-promise-only.

Comments (5)

getify avatar getify commented on August 10, 2024

Can you test this (I don't have an IE8 to test on) to see if it suffices?

try {
   Object.defineProperty({},"a",{value:2});
   builtInProp = function builtInProp(obj,name,val,config) {
        return Object.defineProperty(obj,name,{
            value: val,
            writable: true,
            configurable: config !== false
        });
    };
}
catch (err) {
    builtInProp = function builtInProp(obj,name,val) {
        obj[name] = val;
        return obj;
    };
}

from native-promise-only.

getify avatar getify commented on August 10, 2024

It probably will work. Had forgotten, just found this in asynquence:

https://github.com/getify/asynquence/blob/master/legacy.js#L8-L18

from native-promise-only.

Octane avatar Octane commented on August 10, 2024

Yes, it works.

from native-promise-only.

getify avatar getify commented on August 10, 2024

OK, thanks. Will patch.

from native-promise-only.

smikes avatar smikes commented on August 10, 2024

Re: browser testing I have set up the Travis side but not yet the sauce labs free account. Will work on that tomorrow.

On Mon, Aug 11, 2014 at 7:42 AM, Kyle Simpson [email protected]
wrote:

Closed #33 via 42080e6.

Reply to this email directly or view it on GitHub:
#33 (comment)

from native-promise-only.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.