Coder Social home page Coder Social logo

Comments (5)

zloirock avatar zloirock commented on September 14, 2024

https://babeljs.io/docs/faq/#why-is-this-being-remapped-to-undefined-

@getify use correct way detection global object.

from native-promise-only.

getify avatar getify commented on September 14, 2024
  1. Polyfills shouldn't be run through a transpiler. That doesn't make sense. In fact, you shouldn't run any third-party code through a transpiler, IMO. Exclude such file(s) from transpilation runs.
  2. I disagree with babel that such assumptions about this are either spec compliant or appropriate for polyfills.

Sounds like you should either not run NPO through babel, or you should blacklist the strict transformer, as @zloirock suggests.


use correct way detection global object.

I disagree that the much more convoluted code linked to is "correct". It may work, but it's far from what we ought to be doing. See points above.

from native-promise-only.

zloirock avatar zloirock commented on September 14, 2024

@getify see this table. It not contains this because of strict mode, but w/o strict mode in many case it shouldn't work too. It's simples correct for most case way, "convoluted", for example, in LoDash.

from native-promise-only.

alexreardon avatar alexreardon commented on September 14, 2024

I agree with your first point @getify. I makes little sense to run a library through babel. I now exclude it. Thanks!

from native-promise-only.

getify avatar getify commented on September 14, 2024

Cheers!

from native-promise-only.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.