Comments (5)
https://babeljs.io/docs/faq/#why-is-this-being-remapped-to-undefined-
@getify use correct way detection global object.
from native-promise-only.
- Polyfills shouldn't be run through a transpiler. That doesn't make sense. In fact, you shouldn't run any third-party code through a transpiler, IMO. Exclude such file(s) from transpilation runs.
- I disagree with babel that such assumptions about
this
are either spec compliant or appropriate for polyfills.
Sounds like you should either not run NPO through babel, or you should blacklist the strict
transformer, as @zloirock suggests.
use correct way detection global object.
I disagree that the much more convoluted code linked to is "correct". It may work, but it's far from what we ought to be doing. See points above.
from native-promise-only.
@getify see this table. It not contains this
because of strict mode, but w/o strict mode in many case it shouldn't work too. It's simples correct for most case way, "convoluted", for example, in LoDash.
from native-promise-only.
I agree with your first point @getify. I makes little sense to run a library through babel. I now exclude it. Thanks!
from native-promise-only.
Cheers!
from native-promise-only.
Related Issues (20)
- browsers support information HOT 7
- Cross-Browser Support & Tests HOT 3
- Support IE8 HOT 5
- What is correct execution sequence when attach multiple handlers to the same promise. HOT 8
- Better native support detection? HOT 3
- Create tag for v0.7.6-a HOT 1
- Android 4.0 issue HOT 17
- AMD? HOT 19
- handling uncaught exceptions HOT 5
- Promise.resolve(1) throws on Android 4.0 HOT 1
- `resolve(..)` should call a thenable's `then(..)` async, not sync. HOT 5
- Unhandled rejection detection HOT 9
- Suggestion: make Promise.prototype aliases of `then` and `catch` HOT 5
- Module with unminified code should be exported by default
- on nodejs, exceptions are not shown. HOT 4
- Microtasks? HOT 1
- Ponyfill support? HOT 1
- Missing tag for version 0.7.8-a used by jQuery HOT 7
- Promise finally not supported HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from native-promise-only.