Comments (2)
it a hole in the promises-aplus-tests, or even a hole in the specification?
Neither of those, per se. I think it's actually something that proper testing of the Promise(..)
constructor should catch. Note: the A+ spec isn't testing the semantics of Promise(..)
so it wouldn't catch stuff like this.
IIRC, that check is there for a case like:
var p = new Promise(function(resolve,reject){
resolve(..);
// later
resolve(); // this second call should silently fail per A+ spec, but not
// tested in A+ spec tests
// same goes for calling `reject(..)` twice.
});
In other words, the check is, if you've already called resolve(..)
, then state
is no longer 0
and you need to silently fail.
However, later on, I added two other guards, lines 274-277 and lines 282-285, respectively, which I believe have the same effect (but for a slightly different reason).
Boiling it all down, I believe this is indeed probably a case of provably unreachable, given my implementation check on def.triggered
already guarding against the only place where this could happen.
I certainly don't advocate removing the guard yet
We definitely should leave it in for now, until we get a full test suite against Promise(..)
, even tests that try the above stuff. Then we can remove the check and see if any of the tests fail. I highly doubt they will, but doubting and knowing are two different things at this point.
So let's make sure to revisit this later. This check is on the hot path so removing it would tweak the perf up a little bit (perhaps a lot in aggregate?), so I definitely want to once we have tests proving it's not needed. :)
from native-promise-only.
Agreed, this code is no longer present, therefore not uncovered.
from native-promise-only.
Related Issues (20)
- browsers support information HOT 7
- Cross-Browser Support & Tests HOT 3
- Support IE8 HOT 5
- What is correct execution sequence when attach multiple handlers to the same promise. HOT 8
- Better native support detection? HOT 3
- Create tag for v0.7.6-a HOT 1
- Android 4.0 issue HOT 17
- AMD? HOT 19
- handling uncaught exceptions HOT 5
- Promise.resolve(1) throws on Android 4.0 HOT 1
- `resolve(..)` should call a thenable's `then(..)` async, not sync. HOT 5
- Unhandled rejection detection HOT 9
- Suggestion: make Promise.prototype aliases of `then` and `catch` HOT 5
- Error when running through babel compiler HOT 5
- Module with unminified code should be exported by default
- on nodejs, exceptions are not shown. HOT 4
- Microtasks? HOT 1
- Ponyfill support? HOT 1
- Missing tag for version 0.7.8-a used by jQuery HOT 7
- Promise finally not supported HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from native-promise-only.