dzenbot / dznphotopickercontroller Goto Github PK

Hi,

It seems that your code calls some methods from UIKit and put on a background thread?

The problem is that with iOS7 you get a black screen when using the camera function if something is in a background thread from UIKit. If I use the search photo function and later use the take photo it will come with a black screen and it takes at least 30 seconds when the camera preview comes back.

See simular problem here: http://stackoverflow.com/questions/16746839/idevice-camera-shows-black-instead-of-preview

Is there a way to remove these from the background thread?

Thanks!

I try edit picture created by camera in portrait orientation. Picture has proportion 3x4. And as result I see misshapen picture. I try it on iPhone 5s and simulator IOS 7.1

Are there any plans to upgrade to SDWebImage 3.6? The podspec requires 3.5.4 however I would like to use 3.6 in my project as it includes many fixes / improvements. I can't right now because DZNPhotoPickerController creates a version conflict by requiring an older version as a dependency.

Thanks!

Apple reserves the UI and NS prefixes, among others. Please resubmit to Cocoa Controls after. thanks!

How to implement it without cocoa pods??

Pulled down the latest version (1.4.3) and it does not compile because of a method not found.

[self.collectionView reloadDataSetIfNeeded];

No visible @interface for 'UICollectionView' declares the selector 'reloadDataSetIfNeeded'

/Pods/DZNPhotoPickerController/Source/Classes/DZNPhotoDisplayViewController.m [Line 582]

Any ideas?

If I set the crop size I get a bunch of errors like:

CGContextSetFillColorWithColor: invalid context 0x0.

My code:

if (self.editingMode == DZNPhotoEditViewControllerCropModeSquare)
 {
        DZNPhotoEditViewController *editViewController = [[DZNPhotoEditViewController alloc] initWithImage:[info objectForKey:UIImagePickerControllerOriginalImage]
                                                                                                  cropMode:self.editingMode];
        [editViewController setCropSize:CGSizeMake(640, 380)];

        [self pushViewController:editViewController animated:YES];
}

It only works without setting the crop size.

The idea will be:

• store locally the 10-20 latest search strings (beware of duplicate items).
• display the search strings as soon as the search bar becomes first responder.
• display a button to clean search history.
• by tapping in any of the history search strings, a new search will be perform (like the tag search).

Any thoughts?

Assign an array of licence constants to be supported when searching on any photo search service like Flickr, 500px, and more.

Hi, I was just looking at this awesome component, and ran the sample application. I noticed that in the updateImageWithPayload: method, the edited image is returned as still being a square. Is this the expected behavior?

If so, I guess there would be a step in there to crop to the circle given the scale factor etc.

Or have I missed something?

Thanks.

on 3.5-inch, when search source is Instagram, the "Load More" button not show,
but on 4- inch, it is ok.

i found this in my project, and I run the sample, the same happen.

also, in 4-inch, even the "load more" is show, but it will get same picture as last time(search source is Instagram)

When there is already a string inside of the UISearch bar from a previous search, and opening the UISearchDisplayController again, its mask shows on top on the tableview making it impossible to select cells.

Hi,

I get a 403 error when using Google Images. I tried to get a API key somewhere but cannot find this.

After picking an image and dimissing the picker control, I sometimes get a whole list of invalid context errors. I did not use the "edit" functionality and I'm using as image picker only (no crop, no edit). Just a fraction of the errors I get:
CGContextSetFillColorWithColor: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Sep 30 22:13:38 Praneeths-Mac.local NotAlone2[4693] : CGContextSetStrokeColorWithColor: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Sep 30 22:13:38 Praneeths-Mac.local NotAlone2[4693] : CGContextSaveGState: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
] : CGContextSetFlatness: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
] : CGContextAddPath: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
] : CGContextDrawPath: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
] : CGContextRestoreGState: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
3] : CGContextSaveGState: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
... etc
and so on... Thoughts on what might be going on? My app does not do any drawing so this is some residual thread from DZNPhotoPickerController.

Hi,

You can select any image in searched results. Then cancel to go back to search result. If you try to open the same image again, you will see no image, just blank screen.

Hi, do you know why if I try to update pod it doesn't recognize version 1.4.2? It stays in 1.4 and I really need to update.

Thanks

pod install fails with message:

Pull is not possible because you have unmerged files.

Please, fix them up in the work tree, and then use 'git add/rm '

as appropriate to mark resolution, or use 'git commit -a'.

Since search APIs like Google's, Bing's and Yahoo's are paid, and offer Free editions with very limited query options, this will allow different UI behaviour based on which editions the developer might have (Free or Paid).

@sjapps This will then allow a fix for the 400 response from Google API when requesting for more results per page than 10. So the UI can still deliver 4 columns of thumbs, with normal size of 75 pts.

Enhancement: More than 4 tabs of image search engine by using logo can have multiple of them or having scrolling tab.

Hey use only the DZNPhotoEditorViewController and when I press on Choose I get the following error. Also is the userInfo[UIImagePickerControllerEditedImage] nil

<Error>: CGContextTranslateCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextSaveGState: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextClipToRect: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextSaveGState: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextSaveGState: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextGetBaseCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextConcatCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextSetBaseCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextSaveGState: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextSaveGState: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextConcatCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextConcatCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextClipToRect: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextDrawImage: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextRestoreGState: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextRestoreGState: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextSetBaseCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextRestoreGState: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextRestoreGState: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextRestoreGState: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextSaveGState: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextSetBlendMode: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextSetAlpha: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextTranslateCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextScaleCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextDrawImage: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Feb 24 17:24:29 Eike-Bartelss-iPad Efficient Sea[448] <Error>: CGContextRestoreGState: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.

Basic feature: enable the option to select photo without download it first or skip it for later downloading. Reason: I want to allow multiple photos select. Or if no plan for multiple photo select at least expose delegate didPickPhoto without downloading it first or option to skip downloading..
or run SDWebImage in background thread so not blocking main thread which disable selecting multiple photos after selecting 3 photos and be able to select photo again after main thread free.

also : adding break point to didPickPhoto. It did not response as smooth if tapping multiple images with editing option disable. Probably the first three tap on photo will response to didPickPhoto then when the image downloaded in progress it did not response./skip it

Mapping tests are not enough, and still, they're very fragile.
To make this library more robust and stable, tests are mandatory. Maybe using Kiwi?

Hi,

When searching the internet for 'California Sun' using Instagram the sample will crash. It works with a singular search term but not search terms that include spaces.

Thanks.

I was using AFNetworking 2.5 but DZNPhotoPickerController required 2.4.1. Now I have to downgrade to 2.5.

Can you mark version 2.4.1 as a minimal version requirement instead of exact version requirement?

Thanks.

I downloaded latest code and run the app.
After zooming & moving the selecting image in the circular space, I tapped "Choose".
In the main view, its not showing circular image. Don't know what went wrong.

Right now, for consuming 500px and Flickr content, the project is using different Objective-C API wrappers installed with pods. This was really useful at the beginning, so I could focus mainly in UI development.

I realise that this libraries are very complete (specially Flickr with around 100 classes, for a total of 2MBs) and do lots of things that DZNPhotoPickerController doesn't really need.
A way for reducing the amount of dependencies, is to build its own limited APIs wrapper. This will allow more scalability for supporting additional third party APIs that doesn't necessarily have an Objective-C wrappers.

When using "Choose Photo" in the Sample app built for 64-bit arch the component fails to show the round mask when editing the image. The issue is present in the device and simulator.

How can i integrate this in a project that is already using AFNetworking 2.0 , one of your classes is using AFHTTPClient which is no longer available in 2.0 ?

It would be great if details about the dependancies like AFNetworking and SDWebImage are added to the readme page.

It would help people who are compiling the sources manually as well as for people who are Integrating "DZNPhotoPickerController" to their old projects.

Somehow, scrolling in the tags results tableview doesn't work, and automatically dismisses the search display.

-[__NSArrayM objectAtIndex:]: index 11 beyond bounds for empty array'
DZNPhotoTag *tag = [_photoTags objectAtIndex:indexPath.row];
the _photoTags is "0 objects"

when will it be updated for Xcode 6?

The control was first built for iPhone. Since my biggest need right now is to fix the iPhone support as much as possible and add more features, I haven't had the time to really work on iPad just yet. There is some minimum support, but really incomplete.

tap on one of image with DZNPhotoPickerController option allowsEdition:NO. didFinishPickingPhotoWithInfo called several times. possible problem in using SDWebImageDownloader callback and nsnotificationCenter

(- (void)photoPickerController:(DZNPhotoPickerController *)picker didFinishPickingPhotoWithInfo:(NSDictionary *)info)

Your podspec maps headers to the files: 'Source/Classes/*.h' which includes DZNPhotoPickerControllerConstants.h. DZNPhotoPickerController also includes DZNPhotoService as a dependency, which explicitly includes DZNPhotoPickerControllerConstants.h as well. This causes Xcode 6 to generate a warning.

There's a few different ways to fix your podspec, let me know if you would like me to suggest a fix.