Coder Social home page Coder Social logo

Comments (10)

dzenbot avatar dzenbot commented on May 27, 2024

I've been thinking about this myself. @ryanfitz already sent a great pull request integrating AFNetworking to 2.0. But some projects still use AFNetworking 1.3.0, and particularly, for those using RestKit (like me), it hasn't yet moved to AFNetworking to 2.0 either.

Would it be a way to support both? 1.3 and 2.0?

from dznphotopickercontroller.

mirceamironenco avatar mirceamironenco commented on May 27, 2024

Honestly i haven't tried it , the migration process from 1.3 to 2.0 is really easy to do , however if your app requires 1.3 there is a problem . My app requires 2.0 and i have a problem with this library, should i try using ryan's pull ?

from dznphotopickercontroller.

dzenbot avatar dzenbot commented on May 27, 2024

I'll suggest to give a try to Ryan's pull. The only issue is that you would not be able to install it with pods...
I still want to merge that change someday soon, but 1.3 is still a bit popular. And RestKit hasn't yet upgraded either. Having 2 versions of AFNetworkings with pods, makes no sense.

from dznphotopickercontroller.

mirceamironenco avatar mirceamironenco commented on May 27, 2024

I'll give it a go , thanks . Why don't you make a version available that uses afn 2.0 . Right now you can pod AFN 1.3 and 2.0 , similarly a user could pod DZN 1.0 and let's say 2.0 ( which uses AFN 2.0 ) . Wouldn't this solve the issue?

from dznphotopickercontroller.

dzenbot avatar dzenbot commented on May 27, 2024

It's actually a good idea, but the library still need hot fixes to move to 2.0
If I create 2.0 today, it will not benefit of this fixes...isn't it?

from dznphotopickercontroller.

mirceamironenco avatar mirceamironenco commented on May 27, 2024

Theoretically if ryan's pull solves the issue and migrates it to 2.0 , just create 2.0 and update it using that ?

from dznphotopickercontroller.

dzenbot avatar dzenbot commented on May 27, 2024

Actually my question was more related to git.
Let's say I create 2.0 with @ryanfitz's pull. When more bugs are fixed on 1.0+, is there a way with git to move those changes to 2.0 and create a new tag with these? If not, 2.0 will only have AFNetworking upgrade but no improvements in other stuff.

from dznphotopickercontroller.

mirceamironenco avatar mirceamironenco commented on May 27, 2024

The changes would only apply to the branch you were
working on . An example of this would actually be afn . Updates
for afn 1.3 and 2.0 are done separetly i believe.

On Tuesday, March 18, 2014, Ignacio Romero Z. [email protected]
wrote:

Actually my question was more related to git.
Let's say I create 2.0 with @ryanfitz https://github.com/ryanfitz's
pull. When more bugs are fixed on 1.0+, is there a way with git to move
those changes to 2.0 and create a new tag with these? If not, 2.0 will only
have AFNetworking upgrade but no improvements in other stuff.

Reply to this email directly or view it on GitHubhttps://github.com//issues/28#issuecomment-37951501
.

from dznphotopickercontroller.

dzenbot avatar dzenbot commented on May 27, 2024

That's what I though. I'm going to read a bit more about this and get back to you for a solution.
On the meantime, cloning Ryan's repo might be a quick solution ;)

from dznphotopickercontroller.

dzenbot avatar dzenbot commented on May 27, 2024

Closing this for now.

from dznphotopickercontroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.