Coder Social home page Coder Social logo

atomatigit's People

Contributors

aki77 avatar austp avatar codenameeli avatar diiq avatar jonathanwiesel avatar oliverpool avatar raynes avatar s0r00t avatar schani avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

atomatigit's Issues

Atom.Object.defineProperty.get is deprecated.

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.

Atom.Object.defineProperty.get (C:\Users\Fathur\AppData\Local\atom\app-0.177.0\resources\app\src\atom.js:54:11)
Object.insertCommands (C:\Users\Fathur\.atom\packages\atomatigit\lib\atomatigit.coffee:76:9)

Atom.Object.defineProperty.get is deprecated.

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.

Atom.Object.defineProperty.get (/usr/share/atom/resources/app/src/atom.js:53:11)
Object.insertCommands (/home/itaibh/.atom/packages/atomatigit/lib/atomatigit.coffee:75:9)

Add 'stage all'

Is there the possibility to add a stage all, so with one command i can add all files?
Thx

Name of branch undefined

Hi,
first of thanks for great work on this package!

I think I found a problem with it. Steps to reproduce:

  1. Create folder
  2. Run git init in it.
  3. Run Atomatigit show command.
  4. Name of branch and commit is undefined.

Reproduced on windows 7, atom 0.155

Screenshot :

undefined

crash on deactivation

When deactivating atomatigit I am getting this error:

Error deactivating package 'atomatigit' TypeError: Cannot read property 'destroy' of undefined
at Object.module.exports.deactivate (c:\Users\Administrator.atom\packages\atomatigit\lib\atomatigit.coffee:34:10)
at Package.module.exports.Package.deactivate (c:\Users\Administrator\AppData\Local\atom\app-0.157.0\resources\app\src\package.js:531:21)
at PackageManager.module.exports.PackageManager.deactivatePackage (c:\Users\Administrator\AppData\Local\atom\app-0.157.0\resources\app\src\package-manager.js:431:12)
at Package.module.exports.Package.deactivate (c:\Users\Administrator.atom\packages\package-cop\lib\package.js:296:30)
at Package.module.exports.Package.enableDisable (c:\Users\Administrator.atom\packages\package-cop\lib\package.js:247:14)
at PackageCopItemView.module.exports.PackageCopItemView.enableDisablePackage (c:\Users\Administrator.atom\packages\package-cop\lib\package-cop-item-view.coffee:317:9)
at PackageCopItemView.module.exports.PackageCopItemView.enableNoneSetup (c:\Users\Administrator.atom\packages\package-cop\lib\package-cop-item-view.coffee:334:8)
at HTMLDivElement. (c:\Users\Administrator.atom\packages\package-cop\lib\package-cop-item-view.coffee:419:70)
at HTMLDivElement.handler (c:\Users\Administrator\AppData\Local\atom\app-0.157.0\resources\app\src\space-pen-extensions.js:112:34)
at HTMLDivElement.jQuery.event.dispatch (c:\Users\Administrator\AppData\Local\atom\app-0.157.0\resources\app\node_modules\space-pen\vendor\jquery.js:4681:9)
at HTMLDivElement.elemData.handle (c:\Users\Administrator\AppData\Local\atom\app-0.157.0\resources\app\node_modules\space-pen\vendor\jquery.js:4359:46)

Attribution for code?

Hi,

I'm a newbie here, and somehow I thought I should write an svn client. So I just started and it turns out I have no idea what to do, so I'm borrowing heavily from atomatigit.

I've added some blurb to the README, but is it enough? Should I add some language to each file that uses copied code?

https://github.com/kgrossjo/atom-svn

Warnung: This is not usable at this point. You can look at the source code and laugh about newbie mistakes, if you like :-)

Thanks a lot,
Kai

Uncaught TypeError: object is not a function

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 0.169.0
System: Mac OS X 10.10.1
Thrown From: atomatigit package, v1.2.0

Stack Trace

Uncaught TypeError: object is not a function

At /Users/jangsegwon/.atom/packages/atomatigit/lib/atomatigit.coffee:46

TypeError: object is not a function
  at Object.module.exports.show (/Users/jangsegwon/.atom/packages/atomatigit/lib/atomatigit.coffee:46:18)
  at atom-workspace.<anonymous> (/Users/jangsegwon/.atom/packages/atomatigit/lib/atomatigit.coffee:64:55)
  at atom-workspace.handler (/Applications/Atom.app/Contents/Resources/app/src/space-pen-extensions.js:115:32)
  at atom-workspace.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4681:9)
  at atom-workspace.elemData.handle (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4359:46)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:243:29)
  at CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:3:61)
  at CommandRegistry.module.exports.CommandRegistry.dispatch (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:156:19)
  at Ipc.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:65:30)
  at Ipc.emit (events.js:107:17)
  at process.<anonymous> (/Applications/Atom.app/Contents/Resources/atom/renderer/api/lib/ipc.js:22:29)
  at process.emit (events.js:110:17)

Commands

     -0:00.0 atomatigit:show (ul.list-inline.tab-bar.inset-panel)

Config

{
  "core": {}
}

Installed Packages

# User
atomatigit, v1.2.0
compare-files, v0.2.6
language-qml, v0.1.0

# Dev
No dev packages

/cc @atom/core

Atomatigit replaces file contents after opening a git mv-ed file

After opening file I expect:

asdfasdf
asdfasdfasdfasdf

But i get a diff:

diff --git a/newfile b/newfile
deleted file mode 100644
index 5a54362..0000000
--- a/newfile
+++ /dev/null
@@ -1,2 +0,0 @@
-asdfasdf
-asdfasdfasdfasdf

Steps to reproduce

  1. Create a new file newfile in a git managed repo
  2. Add file and commit a few changes
  3. In a terminal: git mv newfile newlocation
  4. Open newlocation in atom (if you open the file and no weird behaviour present, save the file)

P.S.
I'll try disabling atomatigit, and try to reproduce it might not be atomatigit related (although I think it is)

Atom.Object.defineProperty.get is deprecated.

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.

Atom.Object.defineProperty.get (c:\Users\Administrator\AppData\Local\atom\app-0.174.0\resources\app\src\atom.js:55:11)
Object.insertCommands (c:\Users\Administrator\.atom\packages\atomatigit\lib\atomatigit.coffee:76:9)

Fresh repositorys

I ran into another issue my friend. Even though I'm not sure if this is an error in atomatigit or rather in the git wrapper you are using (gift):

Initialize a new git-repo with git init and open atomatigit on that repo:

bug_fresh_repo

I have one or two ideas how one might fix this, but I am missing the expierence to do so with Coffee-/JavaScript and failed horribly while trying. ;)

  1. Clean way

    Use git show-ref to check for an 'unborn branch' as git calls it (no HEAD available). In bash you can do that pretty easily:

    git show-ref --quiet || echo "Unborn branch!"

    Alternatively I think one can use this aswell:

    git rev-parse --verify --sq HEAD 

    Handy bash-usable commit hash if there is a HEAD: 'f8be7fd987bfff6687fdc67d093644c62c47aab7' atomatigit

    And an error if there is none: fatal: Needed a single revision

    But I think gift will break that method by modifying the original git response.

  2. Dirty way

    I noticed atomatigit prints the name as "undefined", a simple @localname == "undefined" may do. However I'm not sure how this will work on languages other than english.

    Maybe just printing an error alert when you try to open atomatigit on an freshly intialized repo would to for the time being? It should be a rare error anyway.^^

Greetings

COMMIT_EDITMSG file in wrong location

The COMMIT_EDITMSG files seems to be created at project.git directory, instead of the default project/.git directory.

This is the your real intention? Or it's really some mistake?

IMHO, the default directory seems a better solution.

Show diff in commit message

WIBNI the commit message showed the diff that's to be committed? Well, perhaps not everyone would like that, so it could be an option.

Update editor git feedback coloring

Using the default git package that comes with Atom you get your new/deleted/modified lines and files colored (green/red/yellow) in the editor.

Normally when you commit your changes the coloring disappears (since now everything is clean).

With atomatigit after committing the coloring doesn't update, you need to change focus to another app an come back so the coloring goes off.

EditorView.redraw is deprecated.

Please remove from your code. ::redraw no longer does anything

EditorView.redraw (/Applications/Atom.app/Contents/Resources/app/src/editor-view.js:390:14)
HTMLDivElement.<anonymous> (/Users/adammw/.atom/packages/atomatigit/lib/views/repo-view.coffee:321:30)
HTMLDivElement.opt.complete (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:8506:12)
fire (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:2913:30)
Object.done (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:2959:7)
Animation (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:8032:4)
HTMLDivElement.doAnimation (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:8344:16)
Function.jQuery.extend.dequeue (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:3700:7)
HTMLDivElement.<anonymous> (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:3742:13)
Function.jQuery.extend.each (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:590:23)
[object Object].each (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:237:17)
[object Object].queue (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:3735:9)
[object Object].animate (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:8355:22)
[object Object].show (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:8326:18)
RepoView.module.exports.RepoView.get_input (/Users/adammw/.atom/packages/atomatigit/lib/views/repo-view.coffee:319:25)
Repo.<anonymous> (/Users/adammw/.atom/packages/atomatigit/lib/views/repo-view.coffee:3:61)
triggerEvents (/Users/adammw/.atom/packages/atomatigit/node_modules/backbone/backbone.js:207:57)
Repo.trigger (/Users/adammw/.atom/packages/atomatigit/node_modules/backbone/backbone.js:148:19)
Repo.initiateGitCommand (/Users/adammw/.atom/packages/atomatigit/lib/models/repo.coffee:152:19)
HTMLDivElement.<anonymous> (/Users/adammw/.atom/packages/atomatigit/lib/views/repo-view.coffee:211:30)
HTMLDivElement.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4676:9)
HTMLDivElement.elemData.handle (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4360:46)
Object.trigger (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4594:12)
HTMLInputElement.<anonymous> (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:5119:17)
Function.jQuery.extend.each (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:590:23)
[object Object].each (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:237:17)
[object Object].jQuery.fn.extend.trigger (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:5118:15)
[object Object].trigger (/Users/adammw/.atom/packages/command-logger/lib/main.coffee:65:24)
CommandPaletteView.confirmed (/Applications/Atom.app/Contents/Resources/app/node_modules/command-palette/lib/command-palette-view.js:110:32)
CommandPaletteView.confirmSelection (/Applications/Atom.app/Contents/Resources/app/src/select-list-view.js:269:21)
HTMLDivElement.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/select-list-view.js:108:24)
HTMLDivElement.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4676:9)
HTMLDivElement.elemData.handle (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4360:46)
KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:399:16)
KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:180:22)
HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:146:20)

(The above message was generated by Deprecation Cop)

Authentication

I'm having trouble to perform pulls, fetchs, pushs, etc. Because it asks for a username and password, via terminal is doable because I type it, but in the package it fails displaying the next problem:

Error: Command failed: /bin/sh -c git push origin development -u
Fatal: could not read Username for: 'http://mypersonalservice.someurl': Input/Output error

Make commit more obvious, avoid infinite spinner

First time for me to use atomatigit. So I invoke it, I stage some files, and then I hit c to commit. A new editor opens for the commit message. Very good. So I enter my commit message, and then I instinctively hit cmd-S (to save) and cmd-W (to close). Gone is my commit message, but the commit isn't happening.

May I propose to either prevent hitting those keys, or to make them do something meaningful. (cmd-W with a saved commit message could finish the commit, and cmd-W with an unsaved commit message could abort the commit.)

At the very least, the message that's shown in the commit message editor could indicate what I need to do.

I confess that my instinct to hit cmd-S and cmd-W may have been learned from other version control packages for Sublime Text or Atom...

opening settings tab in Atom 0.94.0 with atomatigit enabled gives TypeError - iterator

if you have atomatigit 0.3.1 in Atom 0.94.0 and then bring up the Settings tab pane (cmd-, or Command Palette then Settings: Open), you get a TypeError on iterator if you look in the Atom Dev Tools console (cmd-option-i or cmd-alt-i).

the error trace from the Atom Dev Tools console is below.

best,

— faddah wolf
portland, oregon, u.s.a.

Window load time: 1282ms /Applications/Atom.app/Contents/Resources/app/src/window-bootstrap.js:18
Error activating package config for “atomatigit” TypeError {} /Applications/Atom.app/Contents/Resources/app/node_modules/settings-view/lib/settings-view.js:406
iterator /Applications/Atom.app/Contents/Resources/app/node_modules/settings-view/lib/settings-view.js:406
(anonymous function) /Applications/Atom.app/Contents/Resources/app/node_modules/settings-view/node_modules/async/lib/asy…:111
_each /Applications/Atom.app/Contents/Resources/app/node_modules/settings-view/node_modules/async/lib/asy…:32
async.each /Applications/Atom.app/Contents/Resources/app/node_modules/settings-view/node_modules/async/lib/asy…:110
module.exports.SettingsView.activatePackages /Applications/Atom.app/Contents/Resources/app/node_modules/settings-view/lib/settings-view.js:411
(anonymous function) /Applications/Atom.app/Contents/Resources/app/node_modules/settings-view/lib/settings-view.js:101
_tickCallback node.js:605

Failed to activate package named 'atomatigit' TypeError: Cannot call method 'getWorkingDirectory' of null

Atom 0.106.0

$ grep version ~/.atom/packages/atomatigit/package.json 
  "version": "0.4.0",
Failed to activate package named 'atomatigit' TypeError: Cannot call method 'getWorkingDirectory' of null
  at Git.setPath (/Users/rngadam/.atom/packages/atomatigit/lib/git.coffee:13:44)
  at Git.initialize (/Users/rngadam/.atom/packages/atomatigit/lib/git.coffee:9:6)
  at Git.Backbone.Model (/Users/rngadam/.atom/packages/atomatigit/node_modules/backbone/backbone.js:258:21)
  at new Git (/Users/rngadam/.atom/packages/atomatigit/lib/git.coffee:7:3)
  at Object.<anonymous> (/Users/rngadam/.atom/packages/atomatigit/lib/git.coffee:105:13)
  at Object.<anonymous> (/Users/rngadam/.atom/packages/atomatigit/lib/git.coffee:1:1)
  at Module._compile (module.js:455:26)
  at Object.requireCoffeeScript [as .coffee] (/Applications/Atom.app/Contents/Resources/app/src/coffee-cache.js:54:19)
  at Module.load (/Applications/Atom.app/Contents/Resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
  at Function.Module._load (module.js:311:12)
  at Module.require (module.js:363:17)
  at require (module.js:379:17)
  at Object.<anonymous> (/Users/rngadam/.atom/packages/atomatigit/lib/views/repo-view.coffee:8:9)
  at Object.<anonymous> (/Users/rngadam/.atom/packages/atomatigit/lib/views/repo-view.coffee:1:1)
  at Module._compile (module.js:455:26)
  at Object.requireCoffeeScript [as .coffee] (/Applications/Atom.app/Contents/Resources/app/src/coffee-cache.js:54:19)
  at Module.load (/Applications/Atom.app/Contents/Resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
  at Function.Module._load (module.js:311:12)
  at Module.require (module.js:363:17)
  at require (module.js:379:17)
  at Object.<anonymous> (/Users/rngadam/.atom/packages/atomatigit/lib/atomatigit.coffee:1:12)
  at Object.<anonymous> (/Users/rngadam/.atom/packages/atomatigit/lib/atomatigit.coffee:1:1)
  at Module._compile (module.js:455:26)
  at Object.requireCoffeeScript [as .coffee] (/Applications/Atom.app/Contents/Resources/app/src/coffee-cache.js:54:19)
  at Module.load (/Applications/Atom.app/Contents/Resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
  at Function.Module._load (module.js:311:12)
  at Module.require (module.js:363:17)
  at require (module.js:379:17)
  at Package.module.exports.Package.requireMainModule (/Applications/Atom.app/Contents/Resources/app/src/package.js:455:34)
  at Package.module.exports.Package.activateConfig (/Applications/Atom.app/Contents/Resources/app/src/package.js:176:12)
  at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app/src/package.js:158:14)
  at Package.module.exports.Package.handleActivationEvent (/Applications/Atom.app/Contents/Resources/app/src/package.js:518:12)
  at HTMLDivElement.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/package.js:3:61)
  at HTMLDivElement.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4676:9)
  at HTMLDivElement.elemData.handle (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4360:28)
  at Object.jQuery.event.trigger (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4594:12)
  at HTMLInputElement.<anonymous> (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:5119:17)
  at Function.jQuery.extend.each (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:590:23)
  at [object Object].jQuery.fn.jQuery.each (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:237:17)
  at [object Object].jQuery.fn.extend.trigger (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:5118:15)
  at CommandPaletteView.module.exports.CommandPaletteView.confirmed (/Applications/Atom.app/Contents/Resources/app/node_modules/command-palette/lib/command-palette-view.js:110:32)
  at CommandPaletteView.module.exports.SelectListView.confirmSelection (/Applications/Atom.app/Contents/Resources/app/src/select-list-view.js:269:21)
  at HTMLDivElement.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/select-list-view.js:108:24)
  at HTMLDivElement.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4676:9)
  at HTMLDivElement.elemData.handle (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4360:28)
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:395:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:176:22)
  at HTMLDocument.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:90:29)
  at HTMLDocument.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4676:9)
  at HTMLDocument.elemData.handle (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4360:28)
 /Applications/Atom.app/Contents/Resources/app/src/package.js:166

Src refspec undefined does not match any

When trying to push commits while on a branch other than master I get this:
screenshot from 2014-10-08 12 56 29

Undefined should actually be the branch name, so atomatigit seams to fail to acquire the branch name. Typing push into the command palette opened by colon works, so I suppose atomatigit tries to do something more clever than just issuing push

Option to use a tab instead of a pane?

This is looking very good. As a heavy magit user (and then Sublime Git) I was thinking of writing this myself.

Is there any way to get an option to use a full tab instead of a pane? Particularly after using emacs for so many years it seems really strange.

Great job.

`Uncaught TypeError: undefined is not a function` for various actions

Uncaught TypeError: undefined is not a function /usr/share/atom/resources/app/node_modules/space-pen/vendor/jquery.js:5603
jQuery.fn.extend.detach /usr/share/atom/resources/app/node_modules/space-pen/vendor/jquery.js:5603

It seems detach is called without being bound to the object it should call remove on. Thus it tries to call it on window, which throws an error.

Here's the stack trace:

jQuery.fn.extend.detach (/usr/share/atom/resources/app/node_modules/space-pen/vendor/jquery.js:5603)
setTimeout (async)
OutputView.initialize (output-view.coffee:20)
View (/usr/share/atom/resources/app/node_modules/space-pen/lib/space-pen.js:137)
OutputView (output-view.coffee:7)
(anonymous function) (repo.coffee:139)
tryCatch1 (/home/despairblue/.atom/packages/atomatigit/node_m…es/promised-git/node_modules/bluebird/js/main…:43)
Promise$_callHandler (/home/despairblue/.atom/packages/atomatigit/node_m…s/promised-git/node_modules/bluebird/js/main…:648)
Promise$_settlePromiseFromHandler (/home/despairblue/.atom/packages/atomatigit/node_m…s/promised-git/node_modules/bluebird/js/main…:662)
Promise$_settlePromiseAt (/home/despairblue/.atom/packages/atomatigit/node_m…s/promised-git/node_modules/bluebird/js/main…:825)
Promise$_settlePromises (/home/despairblue/.atom/packages/atomatigit/node_m…s/promised-git/node_modules/bluebird/js/main…:968)
Async$_consumeFunctionBuffer (/home/despairblue/.atom/packages/atomatigit/node_m…es/promised-git/node_modules/bluebird/js/main…:75)
Async$consumeFunctionBuffer (/home/despairblue/.atom/packages/atomatigit/node_m…es/promised-git/node_modules/bluebird/js/main…:38)
_tickCallback (node.js:378)

It happens for example when opening and closing the atomatigit pane while it still shows the result dialog from the last action (which is empty btw).

screenshot from 2014-10-07 17 58 18

Uncaught TypeError when opening the pane when using color

When I set the following in my .gitconfig:

[color]
    diff = always

I get the following traceback in the console:
screen shot 2014-06-23 at 12 59 24

This looks a lot like #4, but it is not caused by submodules.

The workaround is, of course, to remove the color config from the .gitconfig, but I would like to be able to keep it.

Commit

The package work well, but the commit not work.
When i write commit, after i save but nothing happens so i must write commit with terminal and then i can push the the commit.

Atom.Object.defineProperty.get is deprecated.

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.

Atom.Object.defineProperty.get (/Applications/Atom.app/Contents/Resources/app/src/atom.js:55:11)
Object.insertCommands (/Users/giuseppelobrutto/.atom/packages/atomatigit/lib/atomatigit.coffee:75:9)

Error: Command failed: error: pathspec

When i press cmd-alt-c to complete a commit, i take this error:
Error: Command failed: error: pathspec
/path/to/workspace/...
did not match any file(s) known to git.
I think because the path contain a space, in my case the folder with git workspace is in the tre under 'Google Drive' folder. In fact in the error message the path start with Drive/... in opposite to /Users/...

Focus gets botched on toggling atomatigit on, then off

I am editing a file, the cursor is blinking nicely. I keep staring at the spot where the cursor blinks so that I can see what is going on. While staring, I hit cmd-alt-g to show the Atomatigit pane. Of course, the cursor stops blinking, as the editor has just lost focus. Good. Still staring, I hit cmd-alt-g again, this time to hide the Atomatigit pane. Now I expect that cursor to start blinking again. But it doesn't! Bad.

I can then do ctrl-0 to focus the tree view (where the file I'm staring at was selected, quite convenient for this bug report), and then I can hit Return, and then the cursor will start blinking again. Yay.

So I have a workaround, but nevertheless, it's a bug.

scratches head

Actually, I'm not sure if it's an Atomatigit bug or an Atom bug...

Cant' push code

Hello,

Everytime I try to push my code I see a

fatal : could not read Username for 'https://github.com': No such device or address

After a few search and seeinf the second answer here, it could come from a missing console device.

Any idea on what to do ?

j and k key bindings

I think the j and k key bindings are backwards. Vim, less, etc. use j to go down and k to go up. What do you think about switching them?

Atom.Object.defineProperty.get is deprecated.

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.

Atom.Object.defineProperty.get (/Applications/Atom.app/Contents/Resources/app/src/atom.js:54:11)
Object.insertCommands (/Users/LequiosCreative/.atom/packages/atomatigit/lib/atomatigit.coffee:75:9)

Mac OS X Yosemite / 10.10.2
Atom Version 0.181.0

Uncaught TypeError when opening the pane

I get this error when I open this package in the editor.

/.atom/packages/atomatigit/node_modules/gift/lib/diff.js:77
Uncaught TypeError: Cannot read property '0' of null
module.exports.Diff.parse

This looks really cool, looking forward to using it.
Thanks,
Sean

Atom.Object.defineProperty.get is deprecated.

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.

Atom.Object.defineProperty.get (/Applications/Atom.app/Contents/Resources/app/src/atom.js:53:11)
ErrorView.initialize (/Users/jmp/.atom/packages/atomatigit/lib/views/error-view.coffee:19:9)

No response on invoking Atomatigit.

Hi there! I'm sorry to be a bother, but I seem to be having a little trouble invoking this package. When I mash the keybinding, run the command from the Quick Panel, or click the menu item, nothing happens at all: the panel fails to appear, and nothing is logged to Atom's developer console. I tried toggling "Debug mode" on to see if that would at least get me an error message, but to no avail. I even removed everything from my ~/.atom directory, started fresh, and installed Atomatigit by its lonesome, in case another package was causing a conflict, but still couldn't get it to respond.

I'm using Atom 0.165.0 on Mac OS X Yosemite. My system Git is v2.2.1 and my system Node is v0.10.34, in case that's useful; I think my PATH is being correctly inherited by Atom, since the various linters I've tried can all find their executables.

Thanks in advance for any troubleshooting suggestions you can muster! Looks like a fantastic piece of work; hope I get to futz with it soon.

Crashes Atom

When hitting the key combination, atom quickly becomes unresponsive.

Nothing else visibly happens.

Show output of command

Some commands update the main view, so I can see what happened. But some do not, for example push. After pushing, I have no idea whether it was successful.

I searched the command list with cmd-shift-P (entered "atomatigit") and couldn't find any command that looked as if it might show the output.

I searched the README file and couldn't find any command that looked as if it might show the output.

I opened the inspector (cmd-option-I) and looked at the Console there and didn't find any output. (I'm not saying the output should go there, it's just the last straw I groped for.)

Atom.Object.defineProperty.get is deprecated.

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.

Atom.Object.defineProperty.get (/Applications/Atom.app/Contents/Resources/app/src/atom.js:54:11)
Object.insertCommands (/Users/noahrubin1/.atom/packages/atomatigit/lib/atomatigit.coffee:75:9)

Atom.Object.defineProperty.get is deprecated.

Just receive a warning from Atom as below:

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use `atom.views.getView(atom.workspace)`,
which returns an HTMLElement.

Atom.Object.defineProperty.get (/Applications/Atom.app/Contents/Resources/app/src/atom.js:54:11)
<unknown> (/Users/tianpermana/.atom/packages/atomatigit/lib/models/repo.coffee:59:18)

Show commit results in console or pane

It will be great to show the commit result in the pane or console.

Eg: if you use a pre-commit hook you don't know what happens if it is failing.

Thanks for sharing this!

Automatically refresh view when git status changes

Hi,

I'm using atomatigit and I'm so far pretty happy with it. One thing I'd like to consider:
When the git status changes by another git command (not atomatigit), e.g. executing from command line or via another git plugin (e.g. Git plus) the atomatigit view won't refresh and show the real current state. I need to refresh it manually.
It would be great, if atomatigit recognized changes on the git status itself.

Best regards,

Chris

Windows and Unix commands

On Windows, I've installed Git as an isolated executable to not override some Windows' commands by the Unix ones, this unfortunately results to not have the wc command available.

So the lib/models/branches/local-branch.coffee should preferably use the find command instead on Windows platform not having the wc command.

[Suggestion] Detection with /^win/.test(process.platform) along with require('child_process').spawnSync("where wc") where returned object.status > 0?

Apparently, the equivalent to wc -l would be find /v /c ""

HTML is rendered in the pane diff.

I believe this is a bug and not a feature.
I'm expecting something like:

- <h2> hello </h2>
+ <h2> {{T "simple greeting"}} </h2>

But I get:
screenshot from 2014-05-19 20 44 33

As you might have noticed the h2 tag gets rendered (and doesn't appear in the diff).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.