Coder Social home page Coder Social logo

eventie's Issues

Breaking react server side rendering?

The line

var elem = document.querySelector('#my-elem');

uses document which is not defined on the server side. This means server side rendering of components that use imagesloaded or react-masonry-component (and thus depend on eventie) would fail. Am I missing anything?

'this' context breaks ie8 using browserify.

In eventie.js, this context is an empty object on ie8.

( function( window ) {
...
})( this );

To fix, change 'this' to 'window' and everybody is happy again:

( function( window ) {
...
})( window );

I noticed this issue using your other library 'doc-ready.js'. In that source code, it requires 'eventie.js'. It seems that 'doc-ready' has already replaced 'this' with 'window':

desandro/doc-ready#5

How about supporting an `event capturing`?

example,
when I want to know that images are loaded, I use following code

<div id='parent'>
     <img src="blabla">
     <img src="blabla">
     <img src="blabla">
</div>
var el = document.getElementById("parent");
var checkCount = el.getElementsByTagName("img").length;
function onCheck() {
     checkCount--;
     if(checkCount <= 0) {
        el.removeEventListener("load", onCheck, true);
        el.removeEventListener("error", onCheck, true);
        console.log("complete");
     }
}

el.addEventListener("load", onCheck, true);
el.addEventListener("error", onCheck, true);

if I can't use 'event capturing', I must attach event of all of images.
but if I am able to use 'event capturing', I can attach only one element.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.