desandro / eventie Goto Github PK

In eventie.js, this context is an empty object on ie8.

( function( window ) {
...
})( this );

To fix, change 'this' to 'window' and everybody is happy again:

( function( window ) {
...
})( window );

I noticed this issue using your other library 'doc-ready.js'. In that source code, it requires 'eventie.js'. It seems that 'doc-ready' has already replaced 'this' with 'window':

desandro/doc-ready#5

example,
when I want to know that images are loaded, I use following code

<div id='parent'>
     <img src="blabla">
     <img src="blabla">
     <img src="blabla">
</div>

var el = document.getElementById("parent");
var checkCount = el.getElementsByTagName("img").length;
function onCheck() {
     checkCount--;
     if(checkCount <= 0) {
        el.removeEventListener("load", onCheck, true);
        el.removeEventListener("error", onCheck, true);
        console.log("complete");
     }
}

el.addEventListener("load", onCheck, true);
el.addEventListener("error", onCheck, true);

if I can't use 'event capturing', I must attach event of all of images.
but if I am able to use 'event capturing', I can attach only one element.

I'm dropping support for IE8 & 9 in 2016. As such, eventie will no longer be supported starting January 2016.

The line

var elem = document.querySelector('#my-elem');

uses document which is not defined on the server side. This means server side rendering of components that use imagesloaded or react-masonry-component (and thus depend on eventie) would fail. Am I missing anything?