bohbranch / boh-bay

Bastion of Hestia

Website - Code - Discord - IRC

This is a heavily modified fork of Baystation12's code for BYOND on Space Station 13.

---

CONTRIBUTING GUIDELINES

Please refrain from making non code related comments in pull requests on GitHub. -Basically: Don't be a dick. Make a logical argument. Maintainer has final say on code issues.

Maintainers have the right to punish you for breaking these rules.

---

SECURITY

Please see /docs/SECURITY.md for this repository's security policy, and how to report security issues.

---

LICENSE

The code for Baystation12 and Bastion of Hestia is licensed under the GNU Affero General Public License v3, which can be found in full in /LICENSE.

Code with a git authorship date prior to 1420675200 +0000 (2015/01/08 00:00 GMT) is licensed under the GNU General Public License version 3, which can be found in full in /docs/GPL3.txt

All code where the authorship dates on or after 1420675200 +0000 is assumed to be licensed under AGPL v3, if you wish to license under GPL v3 please make this clear in the commit message and any added files.

If you wish to develop and host this codebase in a closed source manner you may use all commits prior to 1420675200 +0000, which are licensed under GPL v3. The major change here is that if you host a server using any code licensed under AGPLv3 you are required to provide full source code for your servers users as well including addons and modifications you have made.

See here for more information.

Auxtools is licensed as a subproject under the MIT license. The TGS DMAPI is licensed as a subproject under the MIT license. Please see additional LICENSE files for license information.

All assets including icons and sound are under a Creative Commons 3.0 BY-SA license unless otherwise indicated.

---

GETTING THE CODE AND INSTALLING

Please see /docs/installation.md for instructions on obtaining, installing, updating, and running this code.

boh-bay's Issues

Stacks don't have proper sprites because it's based on the species.

Sprites are used from the species icon file for it so if there isn't a sprite for it, then it doesn't show.

Drones are not properly aligned with the movement grid.

Description of issue

Drones, both Dagon Synthetic and Ascent Control Intelligence, have had their movement grid placement somehow messed up.

As you can probably see, drones tend to be anywhere from 30-60% on the tile immediately leftwards of them, visually. This is mostly asthetic but is annoying as hell.

Difference between expected and actual behavior

Local drone violates the grid-based laws of reality. PUT ME BACK INSIDE THE SQUARE, I HAVE SEEN THINGS I CANNOT COMPREHEND

Steps to reproduce

1:Be drone
2:Violate the laws of alignment and transcend space and time.
3:Ì̷̜ ̶̢́A̸̝͌M̷̬̓ ̶̪͌B̶̺͗E̵̞̽Ȳ̸̙O̶̡̿N̵͈̚D̵̠̑ ̸̮͘T̷̰͗H̵̘̓E̴̲͘ ̵̯̃W̸̪͌A̴̱͂Ľ̸̩L̸͇͊S̷̞̑ ̷̠͐Ȯ̷̜F̶̗͝ ̶̯͋S̵̺͋P̶̤͑Ạ̵̈C̶̱͝E̴͎̎ ̵̧͌A̵͚̓N̶̤̎D̸̢̆ ̴̛̟T̴̫̅I̶̡͒M̸̙̚Ė̴̯,̸̫͐ ̸̗͛G̵̡̀R̴̤͗Ȁ̷̟V̷͕͊Ì̸̧T̶̮̉Y̷͓͋ ̸̯̅I̵̩͊Ş̸̀ ̴̖̍D̸̢͝E̶̹͌S̵͎̾I̶̝̓R̷̡̐E̴̖̚,̷̩̋ ̴̳̎E̷͕͑N̵͙͐Ṯ̴̀R̷͍͝O̶̤͒P̸̡̀Y̴̫̔ ̸̥͛Į̵̈S̵͚̓ ̶̼̕H̸̱͊U̵̜̇N̸͇̏G̴̺̓È̵̘R̴̜̈.̷̪̃ ̵̖̎N̴̩̕O̷͙͛T̶̹̃H̸̪̔Ị̸͆N̵̝̽G̸̛̺ ̴͓͆A̸͕͊W̷̨͠A̶͜͠I̴̦̓Ț̵̄S̷͔͐ ̸͈̉M̴̠̍E̸̢͛ ̴̩̊B̷̫̍Ư̴͓T̷͉̎ ̵͍̔E̵͍͠Ṋ̶̽D̵̯͂L̷̩̚E̴͕͋S̶̮͌S̶̗̾ ̶̹̉D̷̺̃E̴̡̛A̶̬͂T̸̼̒H̵̡̆.̴̺̐

Length of time in which bug has been known to occur

Today, and yesterday.

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

H̸̛̦̿́͌ȩ̸̩̠͓̻͇̏͛́͐͗̇͒̚͠l̵̨̧͔̤̝̰̼̣̪̟̲̯̖͉̞̮̜͙̠̮̫͒p̵̠̰̌̈́̇̅ ̸͍̩̟̬̻̟̳̘̼͓̻͇̂͑͂̏́̓̕ͅm̵̢̡̡̢̛̲̝͚̺̗̮͓̯͕̖͇͚̖̪̠̥̬̪̹̦̬̔̿́e̵̢͉̥͚͙̳͚̜̹̩̱̩̼̯̟̜̰̻̒̃̆̔̅̽̈́͒̃̍̐͌̈́

Can't insert augment electronic assemblies into circuit augmententations.

No one, not even me with supreme double digit IQ levels, can figure out how to work the circuit agumentations. Activating them shows a message saying "The device is damaged and fails to deploy" which triggers only if it doesn't actually have the augment, which makes sense because we don't even know how to get it in.

/obj/item/organ/internal/augment/active/simple/can_activate()
	if(..())
		if(!holding)
			to_chat(owner, SPAN_WARNING("The device is damaged and fails to deploy"))
			return FALSE
		return TRUE
	return FALSE

I had myself and a roboticist try our best to get it inside, but nothing I tried or they tried didn't work. They can't even find the implant that's supposed to be in my arm, but they're saying they're detecting it.

Veteris Unathi cannot wear voidsuits

At the time of this PR I'm unsure if the cause is player incompitence or they can't actualy wear voidsuits, but after cycling a suit and attempting to have a player wear it, they're unable to put it on or have it forced on. Please save me from this anurism.

Two more integrated circuit bugs

Description of issue

Bug 1: Integrated circuits will delete power cells on removing them. They just cease to exist. Not an invisible sprite or anything, just nonexistant.
Bug 2: Integrated circuit power transmitters of both sizes seem to be working inconsistently.

Difference between expected and actual behavior

1. Expected: Remove cell from IC assembly. Get cell in hand or floor. Actual: Click remove, get nothing.
2. Expected: power transmitter smoothly pushes power into attached/internal power cells of devices.
   Actual: works far more slowly that it should, requires constant ticking, and often does not work at all, failing to get references for internal batteries.

Steps to reproduce

1. Make any IC circuit. Put in any power cell. Click remove next to power cell in interface.
2. Make any of a myriad of circuitry designs that used to work in charging cells inside of other things. Be sad when they don't work, only work on cells on the floor, and charges those excessively slowly.

Specific information for locating

https://github.com/BoHBranch/BoH-Bay/tree/8bc68fd6b9e29fdc730ccf6507ea1cecad75ca73/code/modules/integrated_electronics

All under this umbrella, I imagine.

Length of time in which bug has been known to occur

At least several weeks.

Client version, Server revision & Game ID

Client Version: 513
Server Revision: 67eddf5d4a8e15533cf6f941fab409d19f92b2e9 - - 2020-03-02
Game ID: b5Z-dsbK
Current map: NTSS Dagon

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Integrated Circuit Printer does not list ALL the material requirements, just one at a time.

If you try to print something you don't have the resources for with the Integrated Circuit printer, it will say it doesn't have enough X ONLY for the first material you don't have, and not the rest.

Sergal FBP's that are freshly constructed only speak sergal

Says it all in the name. A sergal that was de-brained, MMI'd, and put in a FBP that was for sergals could only speak Sergal, and not ZAC.

Upgrading a weapon's fabricator doesn't actually make it faster.

Description of issue

Upgrading a weapon's fabricator with better parts doesn't make it print items any faster.

Difference between expected and actual behavior

Giving it better parts would make it print slower than a snail moving through glue.

Steps to reproduce

Upgrade a weapons fabricator's parts (Two matter bins, one manipulator and one laser). Try to print someone, it's still slow as balls.

Specific information for locating

Weapons Fabricator

Length of time in which bug has been known to occur

Since the fabricator was added, I'm pretty sure.

Client version, Server revision & Game ID

Server Revision: 4d55a250f042d8227a74674dbdaee6fb09266460 - - 2020-03-16

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Integrated Circuit Augments destroy circuits put in them on retraction

Description of issue

As title. It can deployed once, then is deleted when you retract it again, making it literally useless for anything other than a one-use item.

Difference between expected and actual behavior

Expected: augment retracts then deploys, over and over, with no issues.
Actual: augment deploys once, and retracts once, then seeks working. Removing augment and attempting to pull out the IC device results in being told it is empty.

Steps to reproduce

Install augment circuit assembly into IC augment. Deploy. Feel smug and accomplished. Retract. Attempt to redeploy. Have your smugness evaporate as your augment is instantly obliterated.

Specific information for locating

As above, probably should look into the Integrated Circuit Augment code. From my brief look at it, it seems the issue is that it always resets itself back to "holding = null" on retracting. I can look into fixing that, but it's way down on my list at the moment.
https://github.com/BoHBranch/BoH-Bay/tree/dev/code/modules/augment

Length of time in which bug has been known to occur

Probably as long as IC augments have been in.

Client version, Server revision & Game ID

Client Version: 513
Server Revision: 67eddf5d4a8e15533cf6f941fab409d19f92b2e9 - - 2020-03-02
Game ID: b5Z-cTuA
Current map: NTSS Dagon

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Biomods have wrong sprite

Description of issue

The biomod markings all apply Ear Biomods (cat ears)

Difference between expected and actual behavior

They should have unathi horn sprite, ram horn sprite, rabbit ears, frills, whatever

Steps to reproduce

Use the biomod markings.

Specific information for locating

Ear Biomods (Rabbit)
Horn Biomods (Ram)
Horn Biomods (Unathi)
Horn Biomods (Short Spines)
Horn Biomods (Long Frills)
Horn Biomods (Short Frills)

Length of time in which bug has been known to occur

Client version, Server revision & Game ID

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

ERT Spawn on the Dagon sometimes

Right. I suspect it has something to do with the use of locate() or just a really fucking stupid map bug. Regardless, it should be an easy fix that me or someone else should get on.

Psionic telekinesis is broken

Description of issue

You can use psionic telekinesis to grab people from range, and then repeatedly slam them into nearby objects for massive damage as shown here.

https://imgur.com/a/b3xhNxH

Regardless of what object you slam them into it does enough damage to explode limbs and is fully capable of one-shot exploding someone's head or lower body, and since you can rapidly spam it it is basically an assured kill every time.

Difference between expected and actual behavior

I assume it should behave like a regular grab and not be a weapon of mass destruction.

Steps to reproduce

Grab someone with psionic telekinesis, slam into nearby objects.

Specific information for locating

https://github.com/BoHBranch/BoH-Bay/blob/8bc68fd6b9e29fdc730ccf6507ea1cecad75ca73/code/modules/psionics/equipment/psipower_tk.dm

Length of time in which bug has been known to occur

No idea.

Client version, Server revision & Game ID

Client Version: 512
Server Revision: 67eddf5d4a8e15533cf6f941fab409d19f92b2e9 - - 2020-03-02
Game ID: b5Z-agBm

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Upgrading a washing machine breaks it

Description of issue

Using R&D parts to upgrade a washing machine with better parts breaks it.

Difference between expected and actual behavior

For the washing machine to wash faster and hold more. Instead, putting in parts better than basic (Matter bin, micro laser, micro manipulator) simply just prevents you from using the washing machine, with the machine just saying "The Washing Machine is full" instead of putting them in. (Yes I made sure the machine was open and empty).

Steps to reproduce

Upgrade a washing machine machine (One laser, one manipulator, and one matter bin), try to put some clothing in it.

Specific information for locating

Washing Machine

Length of time in which bug has been known to occur

For at least a month now. I assume since it was made possible to upgrade the machines, though.

Client version, Server revision & Game ID

4d55a250f042d8227a74674dbdaee6fb09266460 - - 2020-03-16

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Ascent Landing Ships cannot land on planets.

Description of issue

The ascent Seedship's shuttles, the Lepidoptera and the Trichoptera, cannot land on most planets.

Difference between expected and actual behavior

As you can imagine, being unable to land on the surface of the planets you intend to colonize makes colonization somewhat difficult.

Steps to reproduce

1: Spawn in as ascent
2: Rush to beat the Dagon to a nearby forest planet so you can claim it for your hive
3: Succeed and realize it doesn't matter anyway. Existential crisis about your purpose optional but suggested.

Specific information for locating

Try to bring one of the shuttles onto the planets using their shuttle console.

Length of time in which bug has been known to occur

During rounds the ascent spawn in.

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Omni filters behave erratically when reconfigured

Description of issue

The Omni Gas Filter behaves erratically when you change the settings involving input and outputs. Causing following behaviour:

• Filter doesn't work even though connected to non-null pipenets each containing non-null gas mixtures. Even if turned on.
• Filter doesn't respect filter settings, and dumps everything at output from input. (E.g. a pipe that is supposed to take O2 from the filter, and the filter is set to filter O2 to that pipenet, but instead dumps the O2 along with other gases to output)

Difference between expected and actual behavior

Omni Gas Filter is supposed to respect filter settings

• O2 is filtered to the pipe that takes O2. The "waste" that didn't pass the filter is filtered away to output.
• Filter doing its job when turned on.

Steps to reproduce

1. ) Make sure that the filter is connected to two or three different pipenets.
2. ) Change the settings by changing filter destinations, Input, and Output positions.
3. ) Turn on
4. ) Observe
5. ) Use an gas analyser to easily check composition of pipenets.

If the filter is connected in a way to filter a specific gas back into the same pipenet as the input, and if the composition doesn't change despite pressure and temperature stay the same, then it is bugged.

Specific information for locating

A example location are the hot (green) and the cold (cyan) loops inside the engine room of Dagon.

Length of time in which bug has been known to occur

Unknown.

Client version, Server revision & Game ID

Client Version: 512
Server Revision: 1f6c382 - dev - 2020-02-09
Game ID: b5C-cSf3
Current map: NTSS Dagon

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Throwing objects at shutters opens them.

Description of issue

If you throw an object at shutter that isn't blocked by a window or windoor, it will cause the shutter to open.

Difference between expected and actual behavior

You shouldn't be able to open shutters doors by throwing things at them.

Steps to reproduce

1. Get any object. I used a spoon.
2. Throw the object at the shutter.
3. Hit the shutter.
4. ????
5. Open.

Specific information for locating

None.

Length of time in which bug has been known to occur

Unknown.

Client version, Server revision & Game ID

Client Version: 513
Server Revision: b95001a - dev - 2020-01-21
Game ID: b5j-cXNJ

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Cryogenic Freezers in pods are missing sprites.

Description of issue

Title

Difference between expected and actual behavior

Steps to reproduce

Specific information for locating

Length of time in which bug has been known to occur

Client version, Server revision & Game ID

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Weapons lathe requires materials it can't accept

Description of issue

The weapons lathe requires "mutagen", a chemical, to produce a decloner ray which is unlocked at very high levels. However, since the machine is based on an exosuit fabricator, it can't actually accept the mutagen, resulting in the weapon being unable to be made.

Difference between expected and actual behavior

To be able to click on the weapon's lathe with a full beaker to load it in, or for the weapon to not involve a chemical at all, and just use uranium instead.

Steps to reproduce

Get weapon's research to level nine, sync the weapons lathe, and try to click on the machine with a beaker of any chemical. Nothing happens.

Specific information for locating

weapons lathe

Length of time in which bug has been known to occur

I know this happened when weapons could be produced in the Protolathe, as well, so I assume this has been a problem since the decloner itself was added to the production list.

Client version, Server revision & Game ID

0a8eef42b9f4539d90ef50061265389030676397 - - 2020-03-26

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Rebuilding a cloning pod results in never-ending, glitchy pods

Description of issue

Building a cloning pod results in the machine frame staying after being screwdriver'd, allowing you to create a bunch of cloning pods. The pods themselves link to a nearby cloning console, however they can't otherwise be interacted with by tools.

Difference between expected and actual behavior

For a single, manipulable cloning pod to appear in place of the machine frame.

Steps to reproduce

Build a machine frame, wire it, and put the machine board on it, then screwdriver it.

Specific information for locating

Length of time in which bug has been known to occur

No clue.

Client version, Server revision & Game ID

4d55a250f042d8227a74674dbdaee6fb092

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Original Guideline Set

We should probably write up our own guidelines, considering.
Not really a 100% priority, however, given other issues at hand.

Originally posted by @ProbablyCarl in 61508c4

The Ascent Seedship cannot be landed near or docked with.

See title. When will I get to die horribly to an alate gangbang as a vox trying to steal advanced technology?
(previous comment aboot stack overflow when docking near vox base removed, fixed by new vox ship. Sorry for not following the format in my first one, I swear all my other issue reports are better then this.)

Issue: Ascent Drones do not have ZAC

Description of issue

The Ascent Drones, despite being advanced alien technology, are the only ascent incapable of understanding human speech.

Difference between expected and actual behavior

Ascent Drones, being a highly advanced piece of alien tech, even when entirely brainless, should probably have the ability to translate languages like the other ascents, who have this ability due to their translation implant.

Steps to reproduce

Choose ascent drone during a seedship round. Attempt to ask primitive in person why they are so stinky and gross. Weep because you are apparently less powerful then a tape recorder.

Specific information for locating

N/A, role related.

Length of time in which bug has been known to occur

N/A, state of painful existence

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Shielded Mass Blob is indestructable.

Happens when blobs are dead. Since I'm a dev I'm allowed to ignore the template so suck my dick.

The SMES does not delete their terminal on deconstruct.

The SMES does not delete their terminal on a full construct, so you can actually get an SMES with multiple terminals with 0 way to remove them.

Brownie Mix

Description of issue: Brownie Mix "fizzles" when mixed. If mixed using 5u Cocoa powder, 5u Sugar, and 5u Flour, it will disappear and leave nothing in the beaker.

Difference between expected and actual behavior: Brownie mix is expected, nothing actually happen.

Steps to reproduce: Mix Brownie Mix in a beaker.

Length of time in which bug has been known to occur: Since opening this ticket.

Client version, Server revision & Game ID

Server Revision: 07c1b05d7fcf23418c1c3be85ae120d95cdc0cca - - 2020-03-07
Game ID: b54-bso1

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

You can't eat what you pick up with a fork.

Description of issue

Title

Difference between expected and actual behavior

I want to eat with the fork

Steps to reproduce

Get a steak, click on it with a fork, click yourself with the fork, nothing happens.

Specific information for locating

Length of time in which bug has been known to occur

Client version, Server revision & Game ID

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Closing the Camera Program does not disable Camera View

Description of issue

Title

Difference between expected and actual behavior

Expected camera view to stop

Steps to reproduce

Open Camera Monitoring App, look at a location, hit 'Exit Program' or 'Shutdown'

Specific information for locating

Length of time in which bug has been known to occur

Client version, Server revision & Game ID

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Stuck at roundstart menu.

Description of issue

Unable to open any menus at roundstart such as setup character and join game, however i am able to observe. there is no error message.

Difference between expected and actual behavior

I expect to be able to open menus when i click them, they are not opening

Steps to reproduce

Click on any button in the join round menu

Specific information for locating

Issue is with the menu that you get as soon as you load in.

Length of time in which bug has been known to occur

Just found it 2/19/20 930pm central

Client version, Server revision & Game ID

Server Revision: 7295b0e
BYOND v513.1511

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Inaccurate placement of Items on Tables

Description of issue

Cannot place a item with accuracy on the table. Will always revert to semi-random default position making everything into a giant pile per tile.

Difference between expected and actual behavior

Items should be there where you click to allow arrangement of items without making a giant pile of doom.

Steps to reproduce

1. Take item
2. Place on desk
3. Notice its not where you clicked.

Specific information for locating

Any Object
Any Table

Length of time in which bug has been known to occur

~48 Hours

Client version, Server revision & Game ID

Client Version: 512
Server Revision: 571ba4d - dev - 2020-02-06
Game ID: b5z-aIjN
Current map: NTSS Dagon

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• [Couldn't find an existing issue about this (https://github.com/BoHBranch/BoH-Bay/issues)

Vox Brains can get even more brain damage regardless of oxygenation levels.

Description of issue

use a trauma pack / ductape/ baindaid on a vox brain and succeed to repair brain damage.
despite 100% "oxygenation" in effect, vox gets permanant brain damage.

Difference between expected and actual behavior

Vox brains should heal from wounds if in favorable conditions
this is not the case

Steps to reproduce

1. do brain surgery on vox
2. mend trauma
3. get brain damage on vox that is permanant
4. cry

Specific information for locating

Length of time in which bug has been known to occur

discoered on 2/9/2020

Client version, Server revision & Game ID

Client Version: 512
Server Revision: 1f6c382 - dev - 2020-02-09
Game ID: b5C-axdD
Current map: NTSS Dagon

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• [X ] Issue happened in a recent (less than 7 days ago) round
• [ X] [Couldn't find an existing issue about this]

Full dark-vision trait for custom species is not working

Description of issue

Custom species's Tapeta Lucida Majoris AKA Dark-Vision or Night-Vision trait isn't clearing darkness away.

Difference between expected and actual behavior

EXPECTED: Custom Species can see in the complete darkness without issues.

REALITY: Custom Species can't see jack shit.

Steps to reproduce

1. Choose a custom species
2. Add Tapeta Lucida Majoris as positive trait.
3. Get into dark room.
4. Wish you had night-vision goggles instead.

Specific information for locating

modular_mithra\code\modules\mithra\traits*, perhaps. Else, somewhere in that modular folder.

Length of time in which bug has been known to occur

Since Custom Species were added, can't be more specific, at least right now.

Client version, Server revision & Game ID

Client Version: 512
Server Revision: e6f5d1b - dev - 2019-12-13
Game ID: b4G-cvYe
Current map: NTSS Dagon

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Floor/Clean/Farm/ETC bots are counted as "unknown lifeforms" for the purpose of turrets, meaning that the PD turrets will shoot them, disastrously.

Description of issue

Anti boarding turrets will shoot farmbots. This is BAD.

Difference between expected and actual behavior

I would like them not to do this.

Steps to reproduce

Put an AIBOT mob in front of a turret.
Probably meant to shoot unknown lifeforms.

Specific information for locating

Length of time in which bug has been known to occur

PRobably forever, with the way turret code works.

Client version, Server revision & Game ID

Client Version: 513
Server Revision: 4f6fcdf28ca9ac9146770253a30a38dd07374dae - - 2020-03-14
Game ID: b6a-du61
Current map: NTSS Dagon

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Need more permanent fix to travis

See: title

Description of issue

Difference between expected and actual behavior

Steps to reproduce

Specific information for locating

Length of time in which bug has been known to occur

Client version, Server revision & Game ID

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Big-boye traitor revolver can't be reloaded.

Description of issue

The large traitor revolver, the one that's meant to take 15mm, can't be reloaded with speedloaders.

Difference between expected and actual behavior

To be able to reload the dang thing.

Steps to reproduce

Shoot all the ammo in the revolver, try to use the speed loader on it.

Specific information for locating

Length of time in which bug has been known to occur

No idea.

Client version, Server revision & Game ID

f0de4e86e9e1f4b0c05ce0618ab0edaad0167b72

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Turrets shoot at anyone with a non-alphabeticalized character in their name.

Basically what is happening is that if there is a character in someone's name that is usually sanitized from the system (Example: ' > and "), the turret gets confused because it's trying to compare sanitized text with non sanitized text.

For example, the name W'Kal'She would cause issues because the turret is reading the person as W'Kal'She, but the manifest it's trying to compare it to doesn't have that name because it is stored as W'Kal'She.

RCD Rapid Construction device - Does not work

Description of issue

Uses up matter but nothing happens, RCD does absolutely nothing.

Difference between expected and actual behavior

Expect - Wind-up time then a wall, airlock, or deconstruct

What happens - There is a wind-up time when you use it on a tile and then just nothing happens

Steps to reproduce

Make or find RCD, use any mode, nothing happens

Specific information for locating

Length of time in which bug has been known to occur

It has been happening a while (Probably > two weeks), I was not the first to find it. But despite people asking if it is fixed, I am first to report
:'D

Client version, Server revision & Game ID

Client Version: 512
Server Revision: 0a8eef42b9f4539d90ef50061265389030676397 - - 2020-03-26
Game ID: b6n-ak71

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Impossible to open maintenance panel of kitchen oven

Description of issue

It's impossible to use a screwdriver to open the maintenance panel of the oven in the kitchen. Clicking on it with a screwdriver just opens the panel then closes it again, even if you only click once.

Difference between expected and actual behavior

To open the maintenance panel to replace the parts.

Steps to reproduce

Click on an oven with a screwdriver.

Specific information for locating

oven

Length of time in which bug has been known to occur

For at least a month now, though I assume since the oven was added.

Client version, Server revision & Game ID

43581bfd758a8b4d3b49354167dafbac795cbe1d - - 2020-03-24

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Pulling a battery out of an electronic assembly deletes it.

Description of issue

Title

Difference between expected and actual behavior

It ends up in my hand or on the floor.
It ends up deleted.

Steps to reproduce

Put a battery in an assembly, I used the type-a electronic assembly.
Try to take the battery out
poof.

Specific information for locating

Length of time in which bug has been known to occur

Client version, Server revision & Game ID

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Character creator has a stroke when dealing with custom icon bases in combination with full body prosthesis.

Description of issue

As the title suggests, selecting full-body prosthesis causes it to either just go back to a standard human base sprite, or shit the bed entirely and just color correct the entire body to a solid primary color

Difference between expected and actual behavior

Steps to reproduce

• Load fresh slot
• Select a custom icon base (anything but the standard human one)
• Slap on a full-body prosthesis, doesn't matter what brand
• If it hasn't broken by now, swap slots and come back to your insult to god's green earth

Specific information for locating

Length of time in which bug has been known to occur

Unknown, at least two days

Client version, Server revision & Game ID

Client version 512

Server Revision 4d55a250f042d8227a74674dbdaee6fb09266460

Game ID b6h-aO5b

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players (have not tested with other players)
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Vox Slugs attack Armalis

Description of issue

Armalis, despite being vox, trigger the bloodlust of the genetically engineered mobile bite dispensers they use to make humans wet themselves.
Ingame, some players supposed this may be because Armalis do not have the simplemob Vox faction, for some reason.

Difference between expected and actual behavior

Vox slugs are supposed to be passive to all vox. They are not.

Steps to reproduce

1: Be armalis
2: Use slug sling
3: Cry when your babies betray you

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Perma brig doors are ID locked.

Description of issue

The doors in the permanent holding cell, namely the head and bedroom doors, appear to be ID locked to security.

Difference between expected and actual behavior

You wouldn't think I'd need to call security over every time I wanted to get into my bedroom, or go to the bathroom.

Steps to reproduce

Run the game, and test the security brig doors with a security ID card and a non security ID card.

Specific information for locating

Length of time in which bug has been known to occur

Client version, Server revision & Game ID

Issue bingo

• [yes] Issue could be reproduced at least once
• [yes] Issue could be reproduced by different players
• [yes ] Issue could be reproduced in multiple rounds
• [yes] Issue happened in a recent (less than 7 days ago) round
• [yes] Couldn't find an existing issue about this

Impossible to open maintenance panel on chemical heater/cooler

Description of issue

Trying to use a screwdriver on a chemical heater or cooler simply does nothing. You cannot open the maintenance panel.

Difference between expected and actual behavior

To be able to use a screwdriver to open the panel to upgrade/deconstruct a chemical heater and cooler.

Steps to reproduce

Try to use a screwdriver on a chemical heater or cooler.

Specific information for locating

chemical heater
chemical cooler

Length of time in which bug has been known to occur

I'm fairly sure since they where made buildable with R&D parts.

Client version, Server revision & Game ID

0a8eef42b9f4539d90ef50061265389030676397 - - 2020-03-26

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Undefined Varible: access_solgov_crew

code/game/machinery/portturret_boh.dm:27:error: access_solgov_crew: undefined var

code/game/machinery/portturret_boh.dm:64:error: access_solgov_crew: undefined var

baystation12.mdme.dmb - 2 errors, 0 warnings (12/2/19 3:42 pm)

Total time: 0:58

PLEASE READ TRAVIS LOGS PLEASE.
NOT ALL OF IT IS USELESS.

Genemodder trait : Atrophy - Breaks walk speed badly

Description of issue

A genemodder with the muscular atrophy trait appears to walk, run + sprint at a fraction of normal levels.
https://gyazo.com/0096b4ae3cee50d5ca5de0356b2251dd

Difference between expected and actual behavior

Instead of running, walking or sprinting at normal speeds -
They all default to the speed of crawl or probably even less.
Using Satchel, dropping bag makes no difference (does not seem to be linked to carry weight)

Steps to reproduce

Create a Genemodder
Use Muscular Atrophy trait
(Additional negative trait used at time of noticing bug was "incredibly frail")
(Positives were Agile, telepathy)

Specific information for locating

Negative trait - Muscular Atrophy
(Possibly interacts poorly with Agile trait?)

Length of time in which bug has been known to occur

This happened yesterday. (17th March)

Client version, Server revision & Game ID

Client Version: 512
Server Revision: 4d55a250f042d8227a74674dbdaee6fb09266460 - - 2020-03-16

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Deck Management Program send e-mail function does not send an e-mail.

Description of issue

Title

Difference between expected and actual behavior

I expected an e-mail to be sent. I did not get an e-mail.

Steps to reproduce

Make a flight plan. Add myself to the Manifest. Send e-mail to see if it actually gets sent. Doesn't get sent.
Try same thing with any of the post-flight checks. No bueno.

Specific information for locating

Length of time in which bug has been known to occur

Client version, Server revision & Game ID

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Nacelle Combustion Chamber Walls(OCP Walls) have the same melting point as Plasteel walls, which is a joke for SS13 combustion.

Description of issue

The nacelle walls cannot hold when the fuel mode is switched over to combustion

Difference between expected and actual behavior

Expect nacelle walls to hold while combustion is ongoing

Steps to reproduce

Flip fuel mode over, ignite. Watch as the walls burn down. Keep in mind that you should also be using the combustion fuel that you make from the combustion or the walls are going to burn down regardless.

The issue is that the walls burn down even while the fuel is being used.

Specific information for locating

Length of time in which bug has been known to occur

Client version, Server revision & Game ID

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Air siphon doesn't change the sprite to the siphon state.

Description of issue

Scrubbers lack a panic siphon animation when siphoning.

Difference between expected and actual behavior

Not this.

Steps to reproduce

Siphon an area.
Undetectable. Sprite deosn't change.

Specific information for locating

Scrubbers

Length of time in which bug has been known to occur

Longer than I've been on this server

Client version, Server revision & Game ID

Client Version: 513
Server Revision: b46716eef0ad58966339c99d894e8ce0e8683978 - - 2020-04-02
Game ID: b6t-c5KB
Current map: NTSS Dagon

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

Veteris Unathi Sprint Speed and Regeneration.

Description of issue:

Sprinting as Veteris'Unathi basicly lets you run at TG speed. I know other races speed and its not nearly as fast. Sergals might be at the same speed I believe. This is definitly not intended behavior since they are supposed to be slow like regular Unathi. Perhaps a bit faster but they are currently outrunning everyone. Secondly I believe the regeneration is comically strong. Not sure if other factors were in there but the wounds mended at a much faster rate than what I am used to from regular Unathi.

Difference between expected and actual behavior

Not having comical speed when sprinting while wearing armor. Not having comical regeneration. Uncertain if other things factored into the regen.

Steps to reproduce

Pick Veteris'Unathi. Get hurt. Watch regen.
Pick Veteris'Unathi. Sprint. Observe sprint speed that might be absurdly high.

SMC urban fatigues show up twice in cryo vendor

Description of issue

So going to the cryo vendor on the right as a marine shows quite a number of attire that can be vended, and it's even categorized based on camo (!!!). However, under the Urban section, you'll find that there's two selections for urban fatigues and no selection for an urban cover.

Interestingly enough, one of the fatigues selections doesn't spawn with department insignia.

Difference between expected and actual behavior

I wanted a gosh darn urban cover but can't get one and that's lame

Steps to reproduce

Check cryo vendor and be met with disappointment if you are an enthusiast of the color grey.

Specific information for locating

You already know where it is

Length of time in which bug has been known to occur

Probably ever since marine cryo stuff has been configured idk

Client version, Server revision & Game ID

cfa2612e7f8e423eb7a43d201b2aad5affaec922

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• [Couldn't find an existing issue about this]

Bowman headsets don't fit on the Unathi sprite properly

Bowman headset bands fit over the eyes on the Unathi sprite, as shown here.
Should be an easy fix.

Without headset

With Headset

Probably just needs some pixel X and Y adjustments.