ament / google_benchmark_vendor Goto Github PK

Incomplete -V compiler option in vendor package while building for QNX

need to use master branch to include QNX patch in google benchmark commit 1302d2ce094a9753b0f81a81ea74c0fa71fae582

I am setting CMAKE_INSTALL_PREFIX in a cmake toolchain for certain technical reason. In this case toolchain overrides command line parameters, so
https://github.com/ament/google_benchmark_vendor/blob/main/CMakeLists.txt#L66 has no effect and the installation logic below https://github.com/ament/google_benchmark_vendor/blob/main/CMakeLists.txt#L74 fails.

Is there a reason for installing external project to a temporary directory? It looks like an unnecessary step --CMAKE_INSTALL_PREFIX can be passed directly to the external project without extra install command. This would work just fine in my environment as well.

To keep source checkout up to date, I download the latest sources, and rebuild workspace.
Version 0.0.5 has been built, the following error occurs when trying to build the newly received 0.0.6 version source.

--- stderr: google_benchmark_vendor
error: patch failed: cmake/thread_safety_attributes.cpp:1
error: cmake/thread_safety_attributes.cpp: patch does not apply
make[2]: *** [CMakeFiles/benchmark-1.5.2.dir/build.make:101: benchmark-1.5.2-prefix/src/benchmark-1.5.2-stamp/benchmark-1.5.2-patch] Error 1
make[1]: *** [CMakeFiles/Makefile2:76: CMakeFiles/benchmark-1.5.2.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

Failed <<< google_benchmark_vendor [0.29s, exited with code 2]

As I guess, ver 0.0.5 and 0.0.6 use same version of benchmark 1.5.2 makes this error.
Is there a solution other than deleting and rebuilding the build?

Build process fails when cross compiling for QNX because patch executable not found