Coder Social home page Coder Social logo

Comments (3)

nuclearsandwich avatar nuclearsandwich commented on June 29, 2024

@clalancette FYI

from google_benchmark_vendor.

clalancette avatar clalancette commented on June 29, 2024

Is there a solution other than deleting and rebuilding the build?

Not right now, as far as I know.

The whole "cmake externalproject + patches" thing that we use is, frankly, pretty brittle. It's been hard to make it work on Windows without administrator, it's been hard to make the patches compatible across all platforms, and you have to add magic CMake incantations to make it work at all. Even though we've made it work, we still have problems:

  • If you use git to check things out (which you often do because of using git apply for patches), it always prints a message out to stderr, and there is no way to disable it
  • You can't rebuild when upgrading, because then the patches don't apply

I think we may want to reconsider how we are doing vendoring for H-Turtle.

All of that said, if you figure out a way to make it work with the current system, I'd be happy to review a patch.

from google_benchmark_vendor.

asherikov avatar asherikov commented on June 29, 2024

What about embedding the project sources with git read-tree and patching in place?

from google_benchmark_vendor.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.