yprez / django-logentry-admin

Show all LogEntry objects in the Django admin site

django-logentry-admin

Show all LogEntry objects in the Django admin site.

Originally based on: Django snippet 2484

Supported versions

• Django 3.2, 3.1, 2.2
• Python 3.9, 3.8, 3.7, 3.6, 3.5

Installation

Install by using pip or easy_install:

pip install django-logentry-admin

Or install from source:

git clone [email protected]:yprez/django-logentry-admin.git
cd django-logentry-admin
python setup.py install

To add this application into your project, just add it to your INSTALLED_APPS setting:

INSTALLED_APPS = (
    ...
    'logentry_admin',
)

Running tests

Test on all Python / Django versions with tox:

$ pip install tox
$ tox

Or just a specific Django / Python version:

$ tox -e py35-django19

Or run on multiple CPUs in parallel with detox to make it faster:

$ pip install detox
$ detox

django-logentry-admin's Issues

Django 1.9.5 - AttributeError: 'NoneType' object has no attribute 'app_label'

.env/lib/python2.7/site-packages/logentry_admin/admin.py", line 121, in object_link
'admin:%s_%s_change' % (ct.app_label, ct.model),
AttributeError: 'NoneType' object has no attribute 'app_label'

Names of actions conflict with translations elsewhere

I think the names of the actions (addition, deletion, change) should be marked for translation with context (pgettext_lazy), to avoid them being incorrectly translated. Mainly the word “change” is problematic, because it is ambiguous in English (can be either a verb or a noun).

Missing Django 2.2. dependency in tox.ini causing Travis tests to fail

There is a missing dependency in the tox.ini file for django22, meaning when tox is trying to run the tests for enviornment: {py38,py37,py36,py35}-django22, instead of testing against Django 2.2, it is actually testing against the latest release, Django 3.2, and failing.

Can you update PyPi?

Update package on PyPI and in "Releases"

Cannot display other than admin

I can only consult admin logs. The user users logs are not displayed. Am I missing something ?

Locales (translations) are not included in the dist package

Installing from PyPI results in no localisations being available.

Fix Django 1.8 warning

RemovedInDjango18Warning: `LogEntryAdmin.queryset` method should be renamed `get_queryset`

RemovedInDjango18Warning

I get a warning error:
(django_processman)➜ processman git:(master) ✗ python manage.py runserver
/Users/lwiskie/.virtualenvs/django_processman/lib/python2.7/site-packages/django/forms/widgets.py:143: RemovedInDjango18Warning: LogEntryAdmin.queryset method should be renamed get_queryset.
.new(mcs, name, bases, attrs))

/Users/lwiskie/.virtualenvs/django_processman/lib/python2.7/site-packages/django/forms/widgets.py:143: RemovedInDjango18Warning: LogEntryAdmin.queryset method should be renamed get_queryset.
.new(mcs, name, bases, attrs))

Seems ike a quick fix.

Add test for Django 3.1

Add test for Django 3.1 and update Django 3.1 compatibility list in README.md and setup.py

Admin should probably be completely readonly

Currently the delete object action is still enabled, which strikes me as wrong (unless you have no superusers and dish out all permissions precisely). Something like this has worked for me in the past:

    def get_actions(self, request):
        actions = super(LogEntryAdmin, self).get_actions(request)
        if 'delete_selected' in actions:
            del actions['delete_selected']
        return actions

In Django 2.0 links to user and object are escaped

Support for the allow_tags attribute on ModelAdmin methods is removed. Now you should return marked safe strings in user_link and object_link methods.

Tox tests failing for py36-flake8 / Django 3.2

Tox tests for py36-flake8 are currently failing.

There is no Django version specified for py36-flake8, so tox is testing with the latest version of Django, 3.2.

Django 3.2. requires a SECRET_KEY (source: Django 3.2 Settings) to run, so to fix the failing test this SECRET_KEY needs adding to the conftest.py file.

It would make sense at the same time to introduce tests for the latest versions of Python (3.9) and Django (3.2).

Remove unsupported versions of Python and Django

Official support for Python 2.7 ended some months ago, after that no bug fixes or security updates has been released.

Additionally the oldest Django version support is 2.2. LTS that support only Python 3.5+

I think it is time to remove code from Django LogEntry Admin related to Python 2.7-3.4 and Django < 2.2

The following checklist can tracks the progress of this endeavour:

• remove Python 2-3.4 / Django < 2.2 support in .travis.yml and tox.ini
• remove Python 2-3.4 / Django < 2.2 classifiers in setup.py
• remove six from the code
• remove __future__ statements from the code
• update README.rst accordingly
• remove comments related to Python 2-3.4 / Django < 2.2 from the code

This query requires pytz, but it isn't installed.

When using a fresh install of django 1.9.2 with logentry-admin, you get this error when navigating to /admin/admin/logentry/

prevent escaping urls

For user_link and object_link you must use django.utils.format_html to prevent escaping url on template

Some field titles are not marked for translation

For example, 'user' and 'object'.

Write some tests

A simple django project that runs syncdb/migrations/validate/check and perhaps tests the admin views for a bit would be enough.

Would be nice to autorun tests with travis using different envs (python/django version)

Use get_change_message instead of change_message

Django does some nice pretty printing in get_change_message method of LogEntry model. Would be really helpful.