Admin should probably be completely readonly about django-logentry-admin

[jaylett]

eg jaylett@e0a4d6f

My fork contains various other hopefully-useful things, some from other forks, some from djangosnippets, and some from me; mostly things that can be cherry-picked separately as required — all my changes are also ISC licensed.

[yprez]

Why do you think "delete" shouldn't be allowed? For example, deleting older entries could be useful in some cases...

[yprez]

Then again, cleaning up the history from the admin site sounds kinda worng.

I'm not actively maintaining this package recently, mostly because there isn't much to maintain. But some of your changes look very useful. If you feel like creating a pull-request for your changes (or part of them) I can release a newer version on pypi.

[jaylett]

Yeah, my attitude is that log entries shouldn't be deleted. If you really need to, you can do it via the shell.

Are there particular changes you do/don't want in a pull request? I think modulo any license concerns (it's not entirely clear without statements in the files themselves if all the authors have consented to ISC, although I think the djangosnippets stuff is certainly safe, so it's really Vaal's ActionListFilter).

5bf1b88 from gotlium also looks very useful; in particular on one of my projects, I make a LogEntry for various user actions (as a kind of simple audit trail), like switching subscription plans, so without constraining the filter to staff only, I wouldn't be able to use it there.

Maybe the safest thing is if I make a PR for my changes and the ones from djangosnippets (which explicitly allows broad reuse under the T&Cs). And/or someone (it's Saturday evening, I'm getting lazy ;) could email Vaal and gotlium to see if they're happy with their changes going in as well.

[yprez]

I think that the license being there in the folder also covers all the code (don't really know the law here, but it's what every open source project does).
Otherwise, sounds good.