yosriady / continuous-token

ERC20 token with built-in Automated Market Maker + Bonding Curve

Hi there 👋 I’m Yos

I'm a web3 builder with a strong interest in security. I'm a smart contract engineer and technical lead at Chainlink Labs.

Check out my content on yos.io.

Contact me if you’re interested in chatting about web3 or a project you’re working on.

continuous-token's Issues

Wrong calculation in BancorFormula.sol

Hi.

I think there are some mistakes in the implementations of forumlas in BancorFormula.sol.
For example:
In the 'calculatePurchaseReturn' function you have used the formula:
tokenBought = _supply * ((1 + _depositAmount / _reserveBalance) ^ (_reserveRatio / MAX_RESERVE_RATIO) - 1)
This formula already accounts the difference between new token supply and old token supply, hence returning newTokenSupply.sub(_supply) is wrong because you now have subtracted _supply twice.
I have not yet run the same calculation through for the 'calculateSaleReturn' function but i'd imagine that this issue also occurred there.