Coder Social home page Coder Social logo

wmbeers / cmv-app Goto Github PK

View Code? Open in Web Editor NEW

This project forked from cmv/cmv-app

1.0 1.0 2.0 6.19 MB

CMV - The Configurable Map Viewer - A community supported open source mapping framework built with the Esri JavaScript API and the Dojo Toolkit

Home Page: https://demo.cmv.io/

License: MIT License

JavaScript 86.92% CSS 4.22% HTML 8.69% Batchfile 0.16%

cmv-app's People

Contributors

alexathomas avatar alexthomaseog avatar amcgee avatar benaiahpitts avatar btfou avatar davidspriggs avatar duckblaster avatar friendde avatar green3g avatar greenkeeper[bot] avatar iled avatar msereda avatar sivetic avatar snyk-bot avatar tmcgee avatar tr3vorm avatar tsamaya avatar wmbeers avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar

cmv-app's Issues

AOI Interactive Extract Has Stopped Working

How often can you reproduce it?

  • Always
  • Sometimes
  • Rarely
  • Unable
  • I didn’t try

Description:

The interactive polyline RCI extract tool has stopped working.

Steps to reproduce:

  1. Start editing an AOI
  2. Click Add Feature
  3. Select the New Line tab
  4. Click Extract from RCI Basemap
  5. Click on a roadway

Expected results:

A point is shown on the map where you clicked, and the roadway you clicked on is highlighted.

Actual results:

The point appears, but not the roadway.

Labels defined in map service for a feature layer do not appear when the feature layer is loaded directly.

Description:

Reported by at least one user to Lex: Labels are defined in several of our map services, and work as expected, but if a labelled feature layer is added directly, the labels do not appear.

Seems similar to cmv#41, where the answer was just "load the map service". Our user was happy with this work-around, but as we move forward with Thematic Maps this is something we'll ultimately have to address.

Steps to reproduce:

  1. Load the WBIDs feature layer directly as a feature layer
  2. Zoom in to 1:50K or higher, so that the layer starts drawing.

Expected results:

Labels appear on the map.

Actual results:

Labels do not appear. Compare to loading the entire Water Quality map service.

Metadata links not working for feature layers

How often can you reproduce it?

  • Always
  • Sometimes
  • Rarely
  • Unable
  • I didn’t try

Description:

For layers loaded singly, as feature layers, the metadata links are no longer working.

Steps to reproduce:

  1. Use the layer browser to load a single feature layer from a map service (using the "Add to Map" button on the right-most screen, not the "Add All to Map" button).
  2. View the metadata for the layer (click the hamburger menu next to the layer name in the layers widget, select metadata)

Expected results:

Metadata for that layer opens in new window

Actual results:

Nothing.

Identify widget configuration should provide support for dynamically updating "identifies" based on data passed to addLayerInfos

We dynamically load layers into our implementation of the CMV application, invoking the Identify widget's addLayerInfos method. This works fine, but does not let us configure the identify result template for the layer being loaded. We can't use config/identify.js to handle this, because we don't know at design time what the layer's identifier will be. (We store info on all of our possible layers, hundreds of them, in a database; users can choose to load at run time any combination of services and feature layers they need.)

A simple addition to Identify.js, to look for an "identifies" property of layerInfo objects sent to addLayerInfos method and append that the the widgets "identifies" object would allow us to configure identify results dynamically.

Users with multiple orgs see full list of editable alts, not just the expected alts of selected project

How often can you reproduce it?

  • Always
  • Sometimes
  • Rarely
  • Unable
  • I didn’t try

Description:

If all of the following are true:

  1. A user has multiple orgUser accounts with project editing authority
  2. Follows a link from the EST to edit a given project (index.html?editProject=1234)
  3. The orgId of the project isn't the same as the orgId of their first (by PK, apparently) orgUserId

Then instead of seeing the list of alternatives for project 1234, they see all editable alternatives for that district. This is because of code in the callback function from MapDAO.getEditableAlternativeOfProjectList that changes the currentAuthority to match that of the project, which subsequently (via subscription on the currentAuthority observable) triggers a call to the listProjectAlts method.

Steps to reproduce:

  1. Log on as a user with multiple org user accounts
  2. Find a project with multiple editable alternatives, for an organization that is not the same as the org associated with the user's first orgUser account
  3. Follow the link to edit the project

Expected results:

The list of alternatives for the project is shown

Actual results:

All editable alternatives of all projects for the org associated with the project are shown.

Folders within a dynamic map service are not toggled on when user selects Turn On All Sublayers (nor off)

How often can you reproduce it?

Always

Description:

If a dynamic map service contains folders, e.g. Critical Lands and Waters Identification Project (CLIP), the options to toggle sublayers do not affect the folders, only the layers within the folders. So if you have the CLIP_V4 and CLIP Opportunities folders unchecked, and select Turn on All Sublayers, the layers within the folders are checked, but not their parent folder, and so the layers are still effectively not visible.

Steps to reproduce:

  1. Add any map service that has folders, such as the CLIP service (under Wildlife and Habitat)
  2. Turn off the folders by unchecking each checkbox next to a folder icon.
  3. Select Turn On All Sublayers menu option from the layer's "hamburger" menu

Expected results:
All layers and folders are checked and visible

Actual results:
All layers are checked, but the folders that were unchecked in step 2 remain unchecked, so layers within the folders are not visible in the map.

WATERSS report and AOI type

Lex has added a new value to the LU_PROJECT_TYPE lookup table for supporting AOI analysis for WATERSS.

PK_PROJECT_TYPE: 18
PROJECT_TYPE: WATERSS
Description: Watershed Approach to Evaluate Regional Stormwater Solutions

We don't read from this table, so it needs to be added to the projectTypes array in AoiEditor.js

See also Issue #55 for enhancement to load thematic maps, how we're implementing the WATERSS maps.

Metadata links need to take ArcGIS Server folder structure into account

https://repo.fla-etat.org/bugzilla/show_bug.cgi?id=5730

The current method for getting the layer name for a given layer within a service assumes the map service's list of layers will contain the same list of references to layers within the service as we have in t_rest_services_mxd.

The way the LayerControl widget (core CMV) works is it only interrogates ArcGIS Server to get the info it needs to render the control in the widget, and it knows nothing about the rest of our internal configuration (info from t_rest_services_mxd, etc.) We have code in the viewMetadata method that gets the layerName by just using the id (really the index) from the LayerControl widget to as an index into our array. That works fine without folders, because the ids from AGS and indexes in our table are the same. But when you add folders in the mix, the ids from AGS no longer match up with the index from our table.

Two ways come to mind to fix this:

  1. Filter the layers coming from AGS to exclude folders (not entirely throughout the application, just in this one function, find the index of the layer in the filtered list (ignoring that first id entirely), and use that index to find the layerName from our table. This is simpler, but I'm concerned that there might be some other quirk of AGS that might trip us up.
  2. We do track the layer indexes in t_rest_services_mxd. If we include that in the generated layerLoader.js config file, we can use AGS id (first column) to find the record. More complicated because it's a change to the map and the LLC, but (assuming our database is up to date), but it reduces the (small) chance the first method will get tripped up by some AGS quirk.

When SDR report completes, the report name doesn't turn into a link like it did for Study Area Report

How often can you reproduce it?

  • Always
  • Sometimes
  • Rarely
  • Unable
  • I didn’t try

Description:

image

Steps to reproduce:

  1. Create an AOI
  2. Select Sociocultural Data Report
  3. Wait for it to complete processing

Expected results:

Links appear under the Sociocultural Data Report label with links to the individual reports (1 for each of the AOI analysis areas [alts]) when Status changes to complete.

Actual results:

No links appear.

Select-identity not showing up for users with >1 identity when creating new AOI

How often can you reproduce it?

  • Always

Description:

Users with more than one orgUser account should see the option to select the organization they're creating an AOI for. The select does show up on the open AOI dialog.

Steps to reproduce:

  1. On AOI widget, click Create

Expected results:

Drop-down with list of organizations account is associated with should appear.

Actual results:

It does not appear, and AOI is created for the default orgUser, or whatever was selected on the Open AOI dialog.

Extract from RCI basemap should not return zero-length lines

How often can you reproduce it?
Sometimes.

Description:

Depending on the roadway ID and mileposts selected, an extract (in AOI or project editor) from the RCI basemap can produce zero-length lines (stored in the db as ST_GEOMETRY(12, 0, 0, 0, 0, 0, NULL, NULL, NULL, NULL, 0, 0, 3087, NULL) ),

https://repo.fla-etat.org/bugzilla/show_bug.cgi?id=5933

Steps to reproduce:

  1. Create a new AOI
  2. Use the Extract function, enter roadway 57070000, BMP 0, EMP 4.592
  3. Click Extract

Expected results:
One feature, labeled "57070000 from 0.000 to 4.592", with a valid line, 4.592 miles long

Actual results:
In addition to the correct one expected, we also get a second labeled "57070000 from 4.592 to 4.592", with 0 length.

Layer names for feature layers is defaulting to layer ID in legend for printed maps

Description:

The legend in printed map has the wrong title for feature layers, something like "graphicLayer4", rather than the proper title.

Steps to reproduce:

  1. Add layers to map (follow steps below or just load this map: https://preprod.fla-etat.org/est/secure/map/?loadMap=481)
    1.1 Use the Layer Browser to add a single feature layer to the map (Add Layer to Map)
    1.2. Use the Layer Browser to add the map service the feature layer is in (Add All to Map)
    1.3. Make sure both the layer loaded individually, and the layer loaded as part of a service are toggled visible
    1.4. Zoom into an extent that causes the map
    1.5. Turn off all other layers
  2. Print the map

Expected results:

Printed map shows same title for both

Actual results:

Printed map shows correct title for layer loaded via service (step 1.2), but incorrect title like "graphicsLayer4" for feature layer (step 1.1)

See also:
https://repo.fla-etat.org/bugzilla/show_bug.cgi?id=5864

Print Layout Needs North Arrow

Jonathon Bennet wrote to the help desk pointing out that printed maps lack a north arrow. I took a quick look and it doesn't seem to be an available option with the out-of-the-box print widget, per, and is likely controlled by the print service. Currently it's configured to use one from arcgisonline.

We could create our own print service, or find another existing print service. There's also this widget to consider.

One thing I do note is the authorText is hard-coded to "Me". I think we should default it to "FDOT" or something.

Identify Widget addLayerInfo method isn't handling feature layers correctly

This block of code in the addLayerInfo method of the Identify widget has a flaw:
// If is a feature layer that does not support // Identify (Feature Service), create an // infoTemplate for the graphic features. Create // it only if one does not already exist. if (layer.capabilities && array.indexOf(layer.capabilities.toLowerCase(), 'data') < 0) {

The layer.capabilites returned from ArcGIS Server is a comma-separated string, not an array. array.indexOf will always return -1.

I recommend changing it to:
if (layer.capabilities && layer.capabilities.toLowerCase().indexOf('data') < 0) {

The end result is that an unnecessary block of code is run to create new infotemplates from the REST service endpoint for the layer, not from the data already returned by the features. This became apparent when Lex noted that results for one service didn't include links. The data had the links, but the rest endpoint list of fields for the layer did not, so it wasn't in the info template, and thus the links aren't shown, even though they're there in the feature's (graphic object) attributes.

Clicking Next on the AOI Editor Analysis Areas screen should not require two clicks

How often can you reproduce it?

  • Always
  • Sometimes
  • Rarely
  • Unable
  • I didn’t try

Description:

The Next button isn't working correctly on the Analysis Areas screen

image

Steps to reproduce:

  1. Create/edit an AOI
  2. Work you way through to the Analysis Areas screen
  3. On the Analysis Areas screen, click Next

Expected results:

Screen changes to show the Analysis Options

Actual results:

A flash of the loading overlay, but the screen doesn't change. Click again and there's another flash of the loading overlay and the screen changes.

Help not available when opening map to edit project

How often can you reproduce it?

  • Always
  • Sometimes
  • Rarely
  • Unable
  • I didn’t try

Description:

Bill, Steph might have told you this already, so sorry if it’s a duplicate, but just in case she didn’t get a chance: when a user opens the Project Map Editor from the Create Project Wizard, it opens as expected ready to add features to the selected analysis area. However, because that is past the initial screen on the tool, the links to the help are no longer available and nothing to indicate that they need to click the little x to get to it. Since they can’t get to the editor help through the help menu, should we have an icon next to the little x as the user navigates through the tool to open a popup with the links to the editor help documentation? If so (or if you have a better idea) can you get it to stage for the webinar tomorrow?

I work around it, but would prefer not to interrupt the work flow to show it to them.

Thanks,

Ruth

Steps to reproduce:

  1. Follow any link/menu option from the EST to edit a project

Expected results:

Project editor opens, with ability to access help.

Actual results:

Project editor opens, but you have to close the project to get to help.

All project features should be visible by default, not just polylines.

https://est-dev-team.slack.com/archives/CHRMG0NNM/p1586789652033800

Mike Apr 13th at 10:54 AM
@Bill map viewer issue with the Projects (Draft/Currently in Review/Previously Reviewed)

Mike 7 days ago
By default, the only sub-layer visible for these is Analysis Area Features > Lines

Mike 7 days ago
I think it should be Analysis Areas instead, or all of Points/Lines/Polygons

Mike 7 days ago
otherwise a project like #14447 is not visible in the default view
image.png
image.png

Bill 7 days ago
Sounds reasonable. That's defined in the map service. I can override it in the viewer, but it's much better if Lex/Danny set it that way in the MXD that defines the service.

Mike 7 days ago
@danny @lex tag you're it 😆

Bill 7 days ago
(For clarity, I'm not just being lazy, it would be a maintainance headache, because if we ever add another layer, or change the order/folder structure in any way, and the viewer-side config wasn't changed accordingly, very weird things would happen.)
👍
1

Danny 7 days ago
I can change it to whatever you like, so would you rather see Analysis Areas, or alll Points/Lines/Polygons?

Mike 7 days ago
making all feature types visible by default looks better to me. the analysis areas appear kind of fuzzy and blotchy compared to the sharper features. or change the default renderer for analysis areas, but it may be that way for a reason.

Mike 7 days ago
points/lines/polys visible by default please

Danny 7 days ago
Roger. Which particular services are these?

Bill 7 days ago
https://leo.at.geoplan.ufl.edu/arcgis/rest/services/oem_services/PREVIOUSLY_REVIEWED_DEV/MapServer, https://leo.at.geoplan.ufl.edu/arcgis/rest/services/oem_services/ETAT_REVIEW_DEV/MapServer, https://leo.at.geoplan.ufl.edu/arcgis/rest/services/oem_services/ELIMINATED_DEV/MapServer, and https://leo.at.geoplan.ufl.edu/arcgis/rest/services/secure_services/DRAFT_PROJECTS_DEV/MapServer, and their equivalents on stage and prod.

Danny 7 days ago
Hmm, that is what confused me. All layers are on by default in those services.
etat_rev_dev.PNG
etat_rev_dev.PNG

Bill 7 days ago
Yep, I was just checking the config and it I'm overriding it in the config.
🔙
1
👍
1

Bill 7 days ago
So I can change it to default to the service definition, or just set it there, since I'm already down that road.

Bill 7 days ago
Do we anticipate that we'll ever change these services? Re-order them, add or remove a layer, change the folder structure?

Danny 7 days ago
As far as I know, this is the structure that we want and it should be staying this way. That being said, I am merely a soldier in this fight. I'll check with Lex.
👍:skin-tone-2:
1

Bill 7 days ago
And now I'm wondering why I have it set to only have lines on by default. I don't recall any feedback from Ruth or users that we'd want it that way, but I don't know why I would have gone through the effort to add the code necessary to override the default presentation.

Bill 7 days ago
I committed the change on 1/22 with the comment
Changing default presentation of projects
Only showing the alternative lines. I considered removing this as an operational layer, but it seems to break the CMV a bit (throws an exception, but then seems to function) if there isn't at least one operational layer present.

Was there a time when these map services had nothing turned on, and I added this so that at least lines were visible.?

Bill 7 days ago
("Considered removing this as an operational layer" means changing how the service is loaded in the CMV, removing it from a section of the config called operationalLayers, to something I add on-the-fly, like other layers.)

Danny 7 days ago
I'm pretty sure they were always turned on, but early on there may have been no features present.

Bill 7 days ago
I'll ask Ruth in this afternoon's meeting. Seems plausible to me that maybe we thought it was too busy to have everything turned on, and I just went too far in paring it down.

Mike 7 days ago
i really don't think that's the case, why would we not want to see some entire projects or features of projects

Bill 7 days ago
By "everything" I mean all the other layers, like termini and buffers.

Mike 7 days ago
oh, right, yeah i would not want to see all that. but i do want to see all feature types of projects in these layers, not just the lines

Bill 7 days ago
I agree.
👍
1

Danny 7 days ago
Lex doesn't foresee any changes with these services. He'll get with you guys at the 1:00 meeting.

Bill 7 days ago
Thanks Danny. Since I already have the code in place to set visible layers, I'll just add the indexes of the point and poly layers to the config.

Bill 7 days ago
(I did find an unattributed comment from some rough notes I took way back in December 2018:
Lines are labelled even when the Features/Labels/Line Labels are turned off. When turned on, duplicate labels appear.
Default visibility: lines on, labels and buffers off
I don't know if that was just my thoughts or notes from a meeting. Don't have any more detailed notes with me here. I'll bet "lines" was just shorthand for "project features".)

Enforce feature_name required in user interface

From: Konikoff, Michael [email protected]
Sent: Monday, April 13, 2020 11:02 AM
To: [email protected]
Subject: [EXTERNAL] Re: ETDMV3STAGE.S_INPUT_SEGMENTS_UPD failed

I believe this was from me testing bug 2925, and trying to blank out the feature name.

Bill, can we add validation to that feature name input? I think it's a low priority fix since there are no errors in the UI, it just doesn't allow the update (even though it looks like it does).

Mike

Michael Konikoff
Senior Software Developer, Transportation, Florida
M +1-850-543-2730
D +1-850-688-1355
[email protected]

AECOM
1625 Summit Lake Dr.
Tallahassee, FL 32317-7940, USA
T +1-850-688-9941
aecom.com

Built to deliver a better world

LinkedIn Twitter Facebook Instagram


From: [email protected] [email protected]
Sent: Monday, April 13, 2020 10:44 AM
To: [email protected] [email protected]
Subject: [EXTERNAL] ETDMV3STAGE.S_INPUT_SEGMENTS_UPD failed

pk_input_segment : 25743
objectid : 15682
my_caller : [email protected] (TNS [email protected]

ORA-01407: cannot update ("ESTDATAV3STAGE"."S_SEGMENTS"."SEGMENTID") to NULL

ORA-06512: at "ESTDATAV3STAGE.S_INPUT_SEGMENTS_UPD", line 19

Show draft features from projects if available and authorized, fall back to milestone max if draft not available or user not authorized

In a situation where an alt of a given project has been through review, but a draft alt added after that review, results in the draft alt not showing up in the map after a call to addProjectToMap. This is because the routine adds the milestone max, which includes only the first alt (the second, still being draft, isn't in that layer), then stops if it finds something. It only adds draft if not found in milestone max.

See email from Lauren Brooks 10/30/2020:

Greetings, Help Desk!

We are hoping to release ETDM Project #14334 to the ETAT next week. We just received comments from OEM. Jonathan Turner (OEM) indicted that you can’t see the linework in the EST for Segment 2 of the referenced project. He’s correct… for some reason it is hidden under the road network of the base map.

What do we need to do to correct this. Any assistance you can provide would be greatly appreciated. Thanks!

Lex proposed adding a new milestone event like "ready for review" to push the draft alt to milestone max. Mike proposes we just invert the search and show draft if available, and only milestone max if user doesn't have draft access or nothing found in draft.

AOI Analysis Area Creation Sometimes Fails

How often can you reproduce it: Sometimes

Description:

Under certain circumstances the behind-the-scenes creation of analysis areas (features in S_AOI representing the geographic union of buffers of features created by the user) fails, resulting in errors running analysis and reports. It often can recover if you close the AOI, re-open it, and try again, but not always.

I do not have clear steps to reproduce, but it can sometimes be triggered by using the undo/redo functionality in conjunction with deleting a feature, or by extracting a zero-length line from the RCI basemap (an issue to be addressed separately).

AOI features table should be visible on the results screen to facilitate toggling visibility of individual features while viewing results

One unanimous bit of feedback from our meeting 1/27/2021 with AOI power users was that when they're looking at the results screen (last page of the wizard, which you can get to directly by clicking the "results" button on the AOI list tab.

Creating a read-only version of the features table from the second page of the wizard, maintaining the functionality of selecting and toggling visible individual features, while disallowing editing of the name or buffer distance, is the most straightforward approach.

Prior to logging this issue, I made an attempt to address this by linking to analysis results in the identify results when clicking on an AOI map service loaded into the map, rather than the individual feature graphics controlled by the AOI editor. This has been committed to a local branch not yet synced up with this repo. TODO update this with reference to the branch and commit.

Thematic Maps

Description:

Users need the ability to load a set of map services/layers pulled from various EST (and possibly external) sources. We can't necessarily get there by creating new map services, as that might get hard to maintain. Building off saved maps seems like the logical starting point.

Server-side code changes in https://repo.fla-etat.org/bugzilla/show_bug.cgi?id=6223

Enhanced support for external service

Per email from Lex 5/25/2020, as we start supporting loading up layers from external services, there's a few issues that would need to be addressed:

  1. Need a description for topics, so we can show users some sort of disclaimer that these are from some external service provider etc.
  2. Some services come without scale dependency, all layers turned on, and can be quite messy when first loaded.
    a. Add a field to T_REST_SERVICE to store a comm-separated list of layer index values for the layers to be on when loaded.
    b. If possible, also set scale dependency dynamically

Alternatives tagged as study areas should only allow polygons to be added.

How often can you reproduce it?

  • Always
  • Sometimes
  • Rarely
  • Unable
  • I didn’t try

Description:

If a project alternative is tagged as a study area, our system only allows digitizing polygons. However, the user is still presented with the option to digitize points and lines, and receives a vague growler error after digitizing one:

image

"Internal error during object insert"

The following is emailed to [email protected]:

ORA-20000: cannot create a point as part of a designated ACE Study Area

ORA-06512: at "ETDMV3STAGE.T_PROJECT_POINT_CKSTUDYAREA", line 22
ORA-06512: at "ETDMV3STAGE.T_PROJECT_POINT_CKSTUDYAREA", line 15
ORA-06512: at "ESTDATAV3STAGE.S_INPUT_POINTS_INS", line 27

Steps to reproduce:

  1. Find an editable alternative with Study Area flag set to "Y"
  2. Start editing
  3. Digitize a point or a line.

Expected results:

Options for creating points and lines are enabled, but an error occurs when digitizing finishes.

Actual results:

Error message "Internal error during object insert" is shown.

Link to Study Area Report goes to CRDR, link to CRDR goes nowhere

How often can you reproduce it?

  • Always
  • Sometimes
  • Rarely
  • Unable
  • I didn’t try

Description:

User reports that when she clicks on Study Area Report, the system provides the Cultural Resource Data Report.

Steps to reproduce:

  1. Create AOI
  2. Select Study Area Report option
  3. When analysis is complete, click link to Study Area Report

Expected results:

Link to page showing Study Area (GIS) reports.

Actual results:

CRDR report opens as PDF

Other Notes:

The link to the CRDR currently is just "todo".

External links to open AOI only work the first time.

How often can you reproduce it?

  • Always
  • Sometimes
  • Rarely
  • Unable
  • I didn’t try

Description:
Per Mike: direct link to view AOI on the map works in Chrome the first time or when no map window is open, and then fails after that. It will switch to the map tab but won't load the next AOI.

Steps to reproduce:

  1. Go to https://stage.fla-etat.org/est/secure/Search.do?searchTerms=AOI%20AND%20type:aoi
  2. Click on any of the View on Map links
  3. Wait for map to open
  4. Leave map window open, go back to search results, click another link

Expected results:

Map should get focus, add the second AOI, zoom to the second AOI's extent.

Actual results:

Map gets focus, but nothing else happens.

Add All-layers-on/off toggle

Alex Marks suggested adding the ability to turn all layers on or off. LayerControl widget has code already to do this, but no UI to invoke it.

Make infowindow popup movable

Email to help desk 4/29/2020:

Team,

Is there a way to get the data box to be movable? Right now, it covers up the polygon or resourced when you have the area selected. Example below, I cannot see the outline of the census block because the data box is on top of it. If you don’t select the resource, you cannot see the area the resource covers.

image

Thanks,

Jonathon A. Bennett...

Saved maps with no layers show misleading error message when loaded

How often can you reproduce it?

  • Always
  • Sometimes
  • Rarely
  • Unable
  • I didn’t try

Description:

When loading a saved map that has no layers defined, the message "No savedMap passed to _loadMap function" is growled.

image

Steps to reproduce:

  1. Load a map that has no saved layers, e.g. https://stage.fla-etat.org/est/secure/map/index.html?loadMap=341

Expected results:

A clearer warning, rather than a vague error.

Actual results:

The error message shown above.

AOIs should be searchable within the AOI editor

Open AOI dialog currently provides options for toggling between the user's AOIs, or those for their district(s), but no other filtering option (except to include expired). Text search filtering like we have on datatables would help. Requested by our AOI power users.

Print fails after using Find Address or Place to zoom to an area

Description:

Steph reports:

Print feature doesn't work when using 'find address or place' to zoom to area

I used the 'Zoom to Region' feature to go to Sarasota and panned over to Galvin Park and added some layers. Print worked as expected that route. Also tested loading projects and AOIs and then printing and that worked as expected too.

Bugzilla #5809

Steps to reproduce:

  1. Open the map.
  2. Optional: Use the print function to print the map, just to verify no other problem is causing the behavior.
  3. Enter a place name or address in the search box overlaid over the map, in the upper left.
  4. After map zooms to the selected place, select Print

Expected results:

  1. Setup
  2. Optional: no error
  3. Marker is shown on map
  4. Map prints.

Actual results:

Uncaught TypeError: this.symbol.toJson is not a function
    at Object.toJson ((index):1279)
    at Object._createFeatureCollection (PrintTask.js:23)
    at Object._createOperationalLayers (PrintTask.js:48)
    at Object._getPrintDefinition (PrintTask.js:27)
    at Object._execute (PrintTask.js:9)
    at Object.execute (PrintTask.js:5)
    at Object.print (Print.js:216)
    at Object.<anonymous> ((index):64)
    at Object.<anonymous> ((index):64)
    at Object.c [as onClick] ((index):120)

Create a Street View Widget that doesn't require a Google license.

The included CMV widget requires a Google Street View license, but linking to Google Street View does not. This enhancement is to create a new widget for a map-click context-menu to open street view at the clicked geographic location.

Bug 4506 - Provide a way to open Google Street View in new window for selected location

Select-identity drop-down behaves poorly in IE

How often can you reproduce it?

  • Always
  • Sometimes
  • Rarely
  • Unable
  • I didn’t try

Description:

Users with > 1 orgUser account see a drop-down on the open AOI dialog. In Chrome, this looks like a standard HTML select, but in IE it renders poorly, and does not behave correctly.

Steps to reproduce:

  1. Log in as a user with > 1 orgUser account
  2. Click Open on the AOI widget
  3. Click in the select organization drop-down to change the orgUser

Expected results:

Drop-down displays options, allows you to click to select one.

Actual results:

Drop-down displays briefly, then options collapse.

Environment:

Software Version
CMV Version
Browser Internet Explorer
Operating system

Workaround:

User can set focus to the select element, then use keyboard arrow keys to cycle through options.

See also issue #10

Folders show up as layers in layer browser

Dynamic map services that have layers organized into folders should either present only the actual feature layers within the service (excluding the folders), or branch out to show layers within a folder.

Currently the highest-level folders show up as layers, and the layers within those folders and subfolders do not show up at all.

If you select a folder from the center column and attempt to load it as a layer, the button turns into a wait spinner, but nothing ever loads.

Include topic in layer search -- Bug 5684

See email exchange 6/12/2020. Search results for the term "ARC Lands" don't include the map layers in the ARC Lands topic. Mike has adjusted the search indexer to include the parent topic name so these layers show up.

I noticed while verifying this that even prior to this change the ARC Lands topic is included in the results (with type=category) returned from SOLR, but not making its way through the UI to show it as a topic/category/service that can be loaded. This is due to SOLR returning type=["Category"] (as an array), and my code expecting it to be a simple string.

https://repo.fla-etat.org/bugzilla/show_bug.cgi?id=5684

AOI Analysis Area creation should be clearer.

Users have expressed some confusion about the Analysis Areas screen, it's purpose, and utility. In addition to issues related to how this tool dynamically creates the analysis area polygons based on user input (see #71).

To address this I created a mockup, committed to branch https://github.com/wmbeers/cmv-app/tree/AOI-Enhancement-Mockup, captured in the attached
Presentation

Presented to users on 1/20, but this proposed change didn't really help clarify things. It wasn't just the wording, but the workflow as well. Discussed in a deeper dive meeting on 1/27, we settled on just giving the users the option to union the buffers of all features to a single analysis area, or create individual analysis areas for each feature. The more complex third option shown in the presentation isn't a use case they think they need, and can be accomplished by just creating another AOI.

Add Support for Linking from Analysis Report

Allow for loading a layer by layerName (same as metadata name), via link from analysis report, optionally filtered by autoId, or by mgrs.
Originally paired with Bug 5617 (new analysis report), I've created new Bug 5812 to test just these changes to the viewer, independent of testing on the new analysis report.

Include the Thematic Maps Quick Steps in the Help menu on the EST Map Viewer

Bug 5654 - Include the Thematic Maps Quick Steps in the Help menu on the EST Map Viewer

  • Copy file to /ufnas/geo-fs6-fast/EST-DATA/web_assets/dev/est/MapViewer/QuickSteps_ThematicMaps.pdf
  • Copy to Stage folder (same path as above, replace "dev" with "stage")
  • Copy to Prod folder (same path as above, replace "dev" with "prod")
  • Add link to HelpDialog.html as /assets/est/MapViewer/QuickSteps_ThematicMaps.pdf
  • Merge to Stage and publish
  • Update 5654 to resolved/fixed
  • Change Approval Request
  • Merge to prod and publish

Layer control for map Services should be expanded by default

Description:

If you use the Browse or Search functions to add a layer to the map, it comes in collapsed by default. This leads to confusion if the layers within the service are not turned on.

https://repo.fla-etat.org/bugzilla/show_bug.cgi?id=5784

Steps to reproduce:

Use the Search or Browse function to add the Rail service to the map.

Expected results:

Layers within the rail service appear on the map.

Actual results:

"Rail" service appears in the LayerControl widget, checked, but because the layers within the service are all turned off, nothing changes in the map. It's not obvious why because the Dynamic widget created for the Rail service is collapsed.

Unexpected behavior from Identify task for feature layers

How often can you reproduce it?

Always, when feature layers are loaded stand-alone, not as map services. If layers are loaded via a map service, the issue does not occur.

Description:

Jonathon Bennet called the help desk to report that when he clicked on areas with overlapping features, the identify results only show the topmost.

Steps to reproduce:

  1. Load feature layers into the map that have overlapping features, e.g. Mitigation Banks, RIBITS Mitigation Banks by USACE, and Mitigation Bank Service Areas.
  2. Click on an area that has features in all layers, e.g. FOX BRANCH RANCH MB in the RIBITS layer, which overlaps features in the other layers

image

Expected results:

Identify window with arrows for multiple results:

image

Actual results:

See first screenshot above, only the topmost layer results are shown

Buffered features in AOI editor appear smaller than expected

Lex reports that the actual size of buffered features is smaller than expected, based on the buffer distance/units input by users.

After confirming that the appropriate units are being sent to the buffer operation, and nothing unexpected is happening to the buffer distance, I looked at other parameters that are passed, and suspect it has something to do with the “geodesic” parameter passed to the geometry server buffer operation (https://developers.arcgis.com/rest/services-reference/buffer.htm)

When I added geodesic=true to the request, I get a buffered feature that looks to have the correct distance (sort of eyeballing with the measure tool). Currently I don’t set it, letting it default. (The default varies on the spatial reference and buffer unit, per the documentation linked above.)

What’s confusing is that seems to be the opposite of what their documentation says (see https://developers.arcgis.com/javascript/3/jsapi/bufferparameters-amd.html#geodesic and https://developers.arcgis.com/javascript/latest/api-reference/esri-tasks-support-BufferParameters.html#geodesic): “If the input geometries are in a geographic coordinate system, set geodesic to true to generate a buffer polygon using a geodesic distance.” The input/output spatial reference is Web Mercator, and the unit linear, and I previously wasn’t setting the parameter, so per this graphic (https://developers.arcgis.com/rest/services-reference/bufferpcs.htm) it’s defaulting to nongeodesic buffering. (Which jibes with the actual request URL that the JSAPI is generating, like: https://tasks.arcgisonline.com/ArcGIS/rest/services/Geometry/GeometryServer/buffer?f=json&unit=9001&unionResults=false&geodesic=false&geometries=%7B%22geometryType%22%3A%22esriGeometryPoint%22%2C%22geometries%22%3A%5B%7B%22x%22%3A-9356490.880719082%2C%22y%22%3A3549898.889026748%2C%22spatialReference%22%3A%7B%22wkid%22%3A102100%2C%22latestWkid%22%3A3857%7D%7D%5D%7D&inSR=102100&distances=1&outSR=102100

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.