Saved maps with no layers show misleading error message when loaded about cmv-app

[wmbeers]

Related: I don't think loadMap and _loadMap should return deferred, and should instead handle the errors internally (moving code from the getSavedMapBeanById callback function in loadMap to _loadMap, and not worrying about having loadMap return a deferred at all, because we don't use it anywhere.

[wmbeers]

Related:

Katie Marley 8 minutes ago
Also, if I try to share a map and I have not saved my changes, I get the 'Unsaved Changes' dialog asking me to save or cancel --- which is expected. However, If I close the dialog or click cancel, the 'Share Map' dialog containing the link still displays.

Bill 6 minutes ago
Oh, good catch.
👍
1

Bill 3 minutes ago
Do you think changing the "You have unsaved changes" dialog from showing "OK" and "Cancel" buttons to "Yes" and "No" buttons would be a good way to fix that last issue?

Bill 2 minutes ago
The user might be thinking, "I don't want to save these changes, but share what I originally had"

Katie Marley < 1 minute ago
That could work. Should we also add a note or more detail that mentions by clicking no, you can still share, but it will be whatever the map was when it was last saved?

Your map has unsaved changes.
Click Yes to save and share your map with the latest changes.
Click No to share the map from when it was last saved.

[wmbeers]

Related: when saving the very first saved map, it doesn't show up in user's list of available maps to open until the map/Index.html page is reloaded in the browser.