whittlem / pycryptobot Goto Github PK

Python Crypto Bot (PyCryptoBot)

License: Apache License 2.0

Python 99.59% Dockerfile 0.14% Smarty 0.16% JavaScript 0.03% Shell 0.08%

backtester backtesting backtesting-trading-strategies binance binance-api coinbase-pro coinbase-pro-api cryptocurrency kucoin kucoin-api

pycryptobot's People

Contributors

Stargazers

Watchers

Forkers

atav928 stuti-madaan phoque6 wizcap melnimr shorif2000 theangelsofwar joaopfsilva ass77 lukewbecker dennislwm silkwire antazoey shinoby92 mikeyquantr danman01 seppedl jcmilanez mvahit seanstephenson hkarhani alloulir maestrocodex macster d-arken sciencederp utekakca hasanalrasyid stefanoregis afrodao ril3y silent-industries ravening elhmohamed horamarques jurij-ch gpx joe-nano ikonushok t3ch9 malakeel densz nyirendareuben lvlie diemesleno maxbrizolla deep-learning-newbie apereverzin jpcarreira ghamarian abhimalamkar feltespt carlosmartinarenas teehanming woododocode alexandreafc mordor-ai unshifty bill538 joaoccgomes digi604 arby1108 thebusted marco-gerardi gibbstp ismaelalvarez xavamros robotron2084 patchedsoul freeperro devwonder01 ronaldzgithub camilolcoder rvn911 pvenancio pigh04ymsm sakurameii lehoaian savon40 gelashiola michaelpeck xpros mcastillomolina ardius21 sur1v peekp i3re4k ali-kin4 canchito-dev letsautom8 sendcapital pianetarosso adamprobert laindream vsnomad omgzy ithom samuel-corcaud-keyconsulting csalinasonline htx2015

pycryptobot's Issues

Cant specify granularity of 1m

Im getting error when specifying 1m as granularity

▶ python3 pycryptobot.py --granularity 1m
--------------------------------------------------------------------------------
|                             Python Crypto Bot                                |
--------------------------------------------------------------------------------
|          Bot Mode : TEST - test trades using dummy funds :)                  |
|       Bot Started : 2021-04-01 17:35:31.677124                               |
================================================================================
Exception: Something went wrong!

Same error even when mentioning "granularity" : "1m", in config.json

5m works fine though

python3 pycryptobot.py --granularity 5m
--------------------------------------------------------------------------------
|                             Python Crypto Bot                                |
--------------------------------------------------------------------------------
|          Bot Mode : TEST - test trades using dummy funds :)                  |
|       Bot Started : 2021-04-01 17:36:40.428803                               |
================================================================================
2021-04-01 15:35:00 | BTCEUR (BEAR) | 5m | Close: 50250.0 | ^ EMA12/26: 50245.46 > 50203.67 ^ | ^ MACD: 41.79 > 40.27 ^ | ^ OBV: -86.2756 (4.13%) ^ | ERI: buy | WAIT

Unable to pull docker image

I'm unable to pull the docker image, seeing this permission error:
Error response from daemon: pull access denied for ghcr.io/whittlem/pycryptobot/pycryptobot, repository does not exist or may require 'docker login': denied: permission_denied: read_package

I've setup a personal access token with the required read package and I've also verified I'm logged in.

XLM problem

Hi
I got an error when the bot triggered an Order for XLM
XLM balance before order: 190.81
EUR balance before order: 0.0
{'product_id': 'XLM-EUR', 'type': 'market', 'side': 'sell', 'size': 190.81}
error: POST (400) https://api.pro.coinbase.com/orders - size is too accurate. Smallest unit is 1.00000000
XLM balance after order: 190.81
EUR balance after order: 0.0

Would you consider adding support for CCXT?

The CCXT library unifies many coin exchanges and would allow for a broader audience for pycryptobot.
https://github.com/ccxt/ccxt

CoinbasePro requiring minimum balance of 50

This there a reason why CoinbasePro is set to have a minimum balance of 50 rather than 0.001?

Line 1084 of PycryptoBot.py
Line 53 of pycryptobot.py

BinanceAPIException: Timestamp for this request was 1000ms ahead of the server's time

Hi,

I just encountered this issue (pasted stack trace in screen dump). Had the bot running for like 12h. Might be of interest for you.

Thanks for a cool bot!

Bot locking up

Seems to be happening a couple times now. It could be issues with coinbase. The bot sometimes just stops updating the console window (until manually restarted) with no errors listed.

I've also noticed some of these lines today as well when running:
error: GET (500) https://api.pro.coinbase.com/products/CGLD-USD/ticker - Internal server error
They show up randomly and is not unique to CGLD-USD.

I've only been using the bot since the last 24 hours, so this may very well just be a current issue with the coinbase API causing problems. Although i'm curious why the bot is just "hanging" and not outright crashing.

runing test unexpected output

fresh repo clone, instaled req and runned
python3.9 pycryptobot.py --market BTC-GBP --granularity 3600 --sim fast --verbose 0

got no config file error

created file

got this error

client_id regex in Telegram model

Hi Michael,

could you put your regex update in the models/Telegrams.py class also, to allow the optional dash in the telegram client id. You previously put the update in the PyCryptoBot.py class file.

re.compile(r"^-*\d{7,10}$")

Thanks.

Adrian.

I thought the fee for market orders on Binance was 0.5%, not 0.05% ?

pycryptobot/models/Binance.py

Line 84 in ae88713

base_quantity = base_quantity * 0.9995

I believe the Binance fee is 0.1% for limit orders, but 0.5% on for market orders.
So I think the row on line 84 should be:
base_quantity = base_quantity * 0.995
rather than
base_quantity = base_quantity * 0.9995
right?

wrong multiplier value in Binance.py

Hi,
I think there is some typo in Binance.py line 196,
For granularity = 15m multiplier should be equal to 15, not 10.

elif(granularity== '15m'):
multiplier = 10

Graphs not working correctly

I updated to the latest code. When I run the following:

python pycryptobot.py --exchange binance --market ENJUSDT --granularity 1h --sim fast --graphs 1

The following is displayed once the simulation ends:

Simulation Summary

Buy Count : 3
Sell Count : 3

Margin : -3.98%

In the graphs folder, there are 6 png files that look identical. (see attachment)
For reference, can you provide an example of your chart? Is the chart supposed to display any trade information?

Originally posted by @t3ch9 in #29 (comment)

The graphs generated for a buy or sell is sort of a work in progress.

Is the chart supposed to display any trade information?
Can @whittlem post an example of a chart for reference?

I would like to experiment with different settings and be able to view the trades.

The graphs generated for a buy or sell is sort of a work in progress. I thought it may be useful to have graphs generated to see what was happening at the time of the buy or sell. I've created loads of graphs in the views/TradingGraphs.py file. At the moment the graphs get generated when ever there is a buy or sell so for 3 buys and 3 sells you will create 6 images. Maybe there is more relevant graphs to show or maybe we would want to generate a graph on a buy or sell but not both. If you are interested in graphs being generated let me know what you think would be useful and I'll see what I can do.

Originally posted by @whittlem in #34 (comment)

config clarity - "nosellatloss"

In the configuration, "nosellatloss" is the variable with option 0 (false) or 1 (true)
It is described in documentation with double negative:
"* No not sell at a loss (no small losses but could prevent getting out before a big crash)"
And when the app runs, it is described as:
"Sell At Loss : False" (with 1)

It is confusing.
nosellatloss = false = sell at loss = false ?

Maybe we can use the same term in both config and app? ("sellatloss" or "nosellatloss" but not both) - my vote is to use "sellatloss" so to avoid double negative....

Or edit the text in app to say "Do not sell at loss"

Buy and Sell Count is Zero when testing?

I'm testing the bot and I'm seeing no buy or sell activity. I have sim'ed, as well as waited over the course of a couple days.

Configuration:
"config" : {
"cryptoMarket" : "BTC",
"fiatMarket" : "USD",
"live" : 0,
"sellatloss" : 1
}

I'm using Coinbase Pro. Is there anything I'm doing wrong? Does my account need to have BTC in it in order for purchasing to occur?

error: POST (400) https://api.pro.coinbase.com/orders - size is too small. Minimum size is 0.00100000

I'm not sure what happened here. The bot was able to create a buy order for ETH this morning, but when it attempted to sell this afternoon, it hit the below error. I can confirm that I still have a ETH-USD balance far greater than 0.00100000. It didn't sell, but the bot kept running, and as you can see, it thought it actually did sell. Not sure if the problem is with the Coinbase Pro API or a pycryptorobot bug.

Thanks!
Todd

2021-04-11 21:15:00 | ETH-USD 900 | Close: 2140.82 | SELL
Fibonacci Retracement Levels: {'ratio0_382': 2134.51, 'ratio0_286': 2148.14}

ETH balance before order: 0.0
USD balance before order: 0.0
{'product_id': 'ETH-USD', 'type': 'market', 'side': 'sell', 'size': 0.0}
error: POST (400) https://api.pro.coinbase.com/orders - size is too small. Minimum size is 0.00100000
ETH balance after order: 0.0
USD balance after order: 0.0
2021-04-11 17:24:38 | ETH-USD (BULL) | 900 | Current Price: 2138.14
2021-04-11 17:29:39 | ETH-USD (BULL) | 900 | Current Price: 2135.91
2021-04-11 21:30:00 | ETH-USD (BULL) | 900 | Close: 2135.17 | v EMA12/26: 2140.37 < 2141.71 v | v MACD: -1.35 < 0.63 v | v OBV: 22461.6819 (-1.72%) v | ERI: sell | WAIT | Last Action: SELL
...

Error with binance lib

Hello,
I'm trying to run the bot with binance and I have an error

Details

| Python Crypto Bot |

| Market : BTCDOGE |
| Granularity : 1h |

| Bot Mode : TEST - test trades using dummy funds :) |
| Bot Started : 2021-04-20 15:42:03.872121 |

Traceback (most recent call last):
File "/Users/jeremmm/pycryptobot/pycryptobot.py", line 870, in
executeJob(s, app)
File "/Users/jeremmm/pycryptobot/pycryptobot.py", line 89, in executeJob
trading_data = app.getHistoricalData(app.getMarket(), app.getGranularity())
File "/Users/jeremmm/pycryptobot/models/PyCryptoBot.py", line 790, in getHistoricalData
return api.getHistoricalData(market, granularity)
File "/Users/jeremmm/pycryptobot/models/Binance.py", line 224, in getHistoricalData
resp = self.client.get_historical_klines(market, granularity, '13 days ago UTC')
File "/Users/jeremmm/pycryptobot/env/lib/python3.9/site-packages/binance/client.py", line 873, in get_historical_klines
return self._historical_klines(symbol, interval, start_str, end_str=None, limit=500, spot=True)
File "/Users/jeremmm/pycryptobot/env/lib/python3.9/site-packages/binance/client.py", line 917, in _historical_klines
first_valid_ts = self._get_earliest_valid_timestamp(symbol, interval, spot)
File "/Users/jeremmm/pycryptobot/env/lib/python3.9/site-packages/binance/client.py", line 846, in _get_earliest_valid_timestamp
kline = self._klines(spot=spot,
File "/Users/jeremmm/pycryptobot/env/lib/python3.9/site-packages/binance/client.py", line 829, in _klines
return self.get_klines(**params)
File "/Users/jeremmm/pycryptobot/env/lib/python3.9/site-packages/binance/client.py", line 817, in get_klines
return self._get('klines', data=params, version=self.PRIVATE_API_VERSION)
File "/Users/jeremmm/pycryptobot/env/lib/python3.9/site-packages/binance/client.py", line 320, in _get
return self._request_api('get', path, signed, version, **kwargs)
File "/Users/jeremmm/pycryptobot/env/lib/python3.9/site-packages/binance/client.py", line 265, in _request_api
return self._request(method, uri, signed, **kwargs)
File "/Users/jeremmm/pycryptobot/env/lib/python3.9/site-packages/binance/client.py", line 260, in _request
return self._handle_response()
File "/Users/jeremmm/pycryptobot/env/lib/python3.9/site-packages/binance/client.py", line 313, in _handle_response
raise BinanceAPIException(self.response)
binance.exceptions.BinanceAPIException: APIError(code=-1121): Invalid symbol.

{
  "binance": {
    "api_url": "https://api.binance.com",
    "api_key": "<truncate>",
    "api_secret": "<truncate>",
    "config": {
      "base_currency": "BTC",
      "quote_currency": "DOGE",
      "granularity": "1h",
      "live": 0,
      "verbose": 1
    }
  }
}

Have you an idea about this?

Thanks

Stops with timeout within some minutes

| Python Crypto Bot |

| Market : ADAEUR |
| Granularity : 1h |

| Bot Mode : LIVE - live trades using your funds! |
| Bot Started : 2021-04-16 21:32:57.015384 |

================================================================================
| Iteration : 1 (BULL) |
| Timestamp : 2021-04-16 20:00:00 |

| Close : 1.19 |
| EMA12 : 1.18 |
| EMA26 : 1.19 |
| Crossing Above : False |
| Currently Above : False |
| Crossing Below : False |
| Currently Below : True |
| Condition : EMA12 is currently below EMA26 and has crossed over |
| SMA20 : 1.18 |
| SMA200 : 1.11 |

| MACD : -0.01 |
| Signal : -0.01 |
| Currently Above : True |
| Currently Below : False |
| Condition : MACD is currently above Signal and has crossed over |

| Action : WAIT |

2021-04-16 21:38:05 | ADAEUR (BULL) | 1h | Current Price: 1.2
2021-04-16 21:43:09 | ADAEUR (BULL) | 1h | Current Price: 1.20164
socket.timeout: The read operation timed out

During handling of the above exception, another exception occurred:

urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='api.binance.com', port=443): Read timed out. (read timeout=20)

During handling of the above exception, another exception occurred:

requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='api.binance.com', port=443): Read timed out. (read timeout=20)

why requiring python 3.9?

Any specific reason? I am struggling to install all the packages on a Raspberry, a lower version would be much easier. Is there any reason?

Failed to establish a new connection

For the last 2 weeks I tested your bot on 6 currency pairs with dummy funds. Amazing gains! :)

Today I have noticed that some bots returned

Failed to establish a new connection

and stopped working. It has happen to 2 bots out of 6. So it was probably temporary network issue on my PC, or Binance API.

However maybe it's worth considering adding retry on this error?
And if it fails then send error information via Telegram?

Full error message below

how to add multiple api's from one exchange in config.json?

So what exchanges, markets, and config are you all using?

According to Github there are 333 of you regularly updating your bots. I'm glad you are finding it useful :)

I was just curious how all of you are doing?

Which exchange(s) are you using? Coinbase Pro, Binance, or both?
How many bots are you running?
How much are you trading per bot?
Which markets are you trading?
What config is working well for you?

I'll start off...

I'm using Coinbase Pro only
I have 5 bots running (in case you didn't see Coinbase Pro now supports 10 portfolios!)
Up until yesterday I was trading £500 per bot. When ever the bots have a successful trade I transfer the profits to my bank account. I increased this to £1500 a bot yesterday.
I'm trading "ADA-GBP", "BCH-GBP", "BTC-GBP", "ETH-GBP", and "LTC-GBP". I was trading "XLM-EUR" but I found it too unreliable, too volatile for my liking. From my analysis ADA looks like a better option as it looks more stable and also more independent from Bitcoin and Ethereum.
I'm actually trying out a new config from this morning. I have disabled "sellatloss" for a few weeks and it has been working really well for me. The change I made this morning was to "disablebullonly", "disablebuyobv", and "disablebuyelderray". The reason I disabled them is because they were there to prevent losses but I have "sellatloss" disabled so they are redundant with that on. I would rather be more liberal with my trades and trade more often. So I'm only using EMA crossovers and MACD with sell at loss disabled. I'll let you know how this works out.

As an example my BTC-GBP config.json looks like this (with my keys removed):

{
    "coinbasepro" : {
        "api_url" : "https://api.pro.coinbase.com",
        "api_key" : "",
        "api_secret" : "",
        "api_passphrase" : "",
        "config" : {
            "base_currency" : "BTC",
            "quote_currency" : "GBP",
            "live" : 1,
            "sellatloss" : 0,
            "disablebullonly" : 1,
            "disablebuyobv" : 1,
            "disablebuyelderray" : 1
        }
    },
    "telegram" : {
        "token" : "",
        "client_id" : ""
    }
}

log messages with mixed time (maybe time zone related)

Hi Michael

First, let me congratulate you for the great work and for taking the time to share it. I have installed pycryptobot on my Windows 10 box and it is running, so far no orders were triggered though. I have it using Binance and configured for BTC-BRL pair.

I noticed that there seems to be a mix of local time in some messages and a different time in others. I am posting a screen capture so you can see. My system is configured for ETC-3 (Brazil). You will see that at the time I took the capture (local time was about 16:44) there are previous messages showing time at 19:30. Maybe some messages derive time from the API of Binance? Or something related to time zones.

Let me know if you need more info on the case.

Timestamp error

Got this stacktrace after leaving the bot running for 5 days. The bot haven't bought nor sold anything.
Traceback (most recent call last): File "/app/pycryptobot.py", line 885, in <module> s.run() File "/usr/local/lib/python3.9/sched.py", line 151, in run action(*argument, **kwargs) File "/app/pycryptobot.py", line 845, in executeJob account.saveTrackerCSV(app.getMarket()) File "/app/models/TradingAccount.py", line 293, in saveTrackerCSV df = self.getOrders(market, '', 'done') File "/app/models/TradingAccount.py", line 94, in getOrders resp = self.client.get_all_orders(symbol=market) File "/usr/local/lib/python3.9/site-packages/binance/client.py", line 1803, in get_all_orders return self._get('allOrders', True, data=params) File "/usr/local/lib/python3.9/site-packages/binance/client.py", line 320, in _get return self._request_api('get', path, signed, version, **kwargs) File "/usr/local/lib/python3.9/site-packages/binance/client.py", line 265, in _request_api return self._request(method, uri, signed, **kwargs) File "/usr/local/lib/python3.9/site-packages/binance/client.py", line 260, in _request return self._handle_response() File "/usr/local/lib/python3.9/site-packages/binance/client.py", line 313, in _handle_response raise BinanceAPIException(self.response) binance.exceptions.BinanceAPIException: APIError(code=-1021): Timestamp for this request is outside of the recvWindow

Help with understanding BUY signal

Hi,

I wounder if you can help me understand why a buy signal was not detected at the point in the screen dump, below is the log from the bot. I'm new into the bot and does not fully understand how to read the information yet.

Thanks for cool open source code, I appreciate your help!

Telegram client ID regex

Hi Michael,

great job on the bot. Thanks.

My telegram client ID starts with a dash followed by digits. So it fails the regex in the PyCyrpoBot and Telegram models.

re.compile(r"^\d{7,10}$")

To make it work I changed to :
re.compile(r"^-\d{7,10}$")

I put the telegram bot in group with myself, perhaps this is the reason there is a dash at the beginning of the client id.

BR,
Adrian.

binance problem on last action decision

guess i enountered a small issue in the last running, last action was BUY as i had 0.0765 ETH, but on my wallet there was still 0.0973 USDT, in this case 0.09 USDT > 0.07 ETH and the script was going always in last action = SELL

python3 /root/cryptobinance/pycryptobot/pycryptobot.py --exchange binance --market ETHUSDT --live 1 --sellupperpcnt 2 --selllowerpcnt -2 --granularity 15m

base = ETH
quote = USDT
base = 0.0765
quote = 0.0973

| Python Crypto Bot |

| Bot Mode : LIVE - live trades using your funds! |
| Bot Started : 2021-04-13 04:01:27.560784 |

================================================================================

| Sell Upper : 2.0% |
| Sell Lower : -2.0% |

================================================================================

after this i added a small constriction to go over

if account.getBalance(app.getBaseCurrency()) < account.getBalance(app.getQuoteCurrency()) and account.getBalance(app.getQuoteCurrency()) > 50 :
        last_action = 'SELL'
elif account.getBalance(app.getBaseCurrency()) > account.getBalance(app.getQuoteCurrency()) and account.getBalance(app.getQuoteCurrency()) < 1 :
        last_action = 'BUY'
print(last_action)

just checked if my quote currency had more then 50 USDT in order to decide BUY/SELL

at the second run, infact, the script went over but it immediately sold the order, unfortunately i couldn't debug more on this

python3 /root/cryptobinance/pycryptobot/pycryptobot.py --exchange binance --market ETHUSDT --live 1 --sellupperpcnt 2 --selllowerpcnt -2 --granularity 15m

| Python Crypto Bot |

| Bot Mode : LIVE - live trades using your funds! |
| Bot Started : 2021-04-13 04:02:22.184992 |

================================================================================

| Sell Upper : 2.0% |
| Sell Lower : -2.0% |

================================================================================

! Profit Bank Triggered (> 2.0%)

Candlestick Detected: Inverted Hammer ("Weak - Continuation - Bullish Pattern - Up")

2021-04-13 02:00:00 | ETHUSDT (BEAR) | 15m | Close: 2166.82 | ^ EMA12/26: 2156.82 > 2150.97 ^ | ^ MACD: 5.85 > 4.37 ^ | ^ OBV: 79702.5118 (0.85%) ^ | ERI: sell | SELL | Last Action: BUY | 99.41%

2021-04-13 02:00:00 | ETHUSDT 15m | Close: 2166.82 | SELL
Fibonacci Retracement Levels: {'ratio0_286': 2155.95, 'ratio0': 2193.9}

ETH balance before order: 0.0765
USDT balance before order: 0.0973
Order quantity after rounding and fees: 0.07646
ETH balance after order: 0.0001
USDT balance after order: 165.5494

POST error on coinbasepro + timestamp issue

Hi,
First, thank you for your amazing work !

i had an error this error today when the bot try to trade. did i do something wrong in the setup ?

2021-04-06 12:00:00 | ETH-DAI 900 | Close: 2122.94 | BUY

ETH balance before order: 0.0
DAI balance before order: 151.5603
error: POST (400) https://api.pro.coinbase.com/orders - funds is too accurate. Smallest unit is 0.01000000
ETH balance after order: 0.0
DAI balance after order: 151.5603

Also, i have an issue with the timestamps in every of my bots. Exemple :

2 hours offset when EMA,MACD...analysis. "Current Price" is accurate
don't know why ?
Ps: i'm in France

Thank you

Size is too accurate. Smallest unit is 1.00000000 - Coinbase

I'm using your bot to trade XLM-EUR but it seems to be having trouble selling.
Besides that, it assumes the sell order was made successfully so it changes the "Last Action" to "SELL.
Here's a picture with the logs.

Connection reset by peer

Hi!

Here in my environment, the bot keeps running for a random time (something between 10 - 30 minutes), then suddenly it halts giving connection errors. Any ideas what is going on?

Here goes part of the error log:

Traceback (most recent call last):
File "/usr/local/lib/python3.9/site-packages/urllib3/connectionpool.py", line 699, in urlopen
httplib_response = self._make_request(
File "/usr/local/lib/python3.9/site-packages/urllib3/connectionpool.py", line 445, in _make_request
six.raise_from(e, None)
File "", line 3, in raise_from
File "/usr/local/lib/python3.9/site-packages/urllib3/connectionpool.py", line 440, in _make_request
httplib_response = conn.getresponse()
File "/usr/local/Cellar/[email protected]/3.9.4/Frameworks/Python.framework/Versions/3.9/lib/python3.9/http/client.py", line 1345, in getresponse
response.begin()
File "/usr/local/Cellar/[email protected]/3.9.4/Frameworks/Python.framework/Versions/3.9/lib/python3.9/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/usr/local/Cellar/[email protected]/3.9.4/Frameworks/Python.framework/Versions/3.9/lib/python3.9/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/usr/local/Cellar/[email protected]/3.9.4/Frameworks/Python.framework/Versions/3.9/lib/python3.9/socket.py", line 704, in readinto
return self._sock.recv_into(b)
File "/usr/local/Cellar/[email protected]/3.9.4/Frameworks/Python.framework/Versions/3.9/lib/python3.9/ssl.py", line 1241, in recv_into
return self.read(nbytes, buffer)
File "/usr/local/Cellar/[email protected]/3.9.4/Frameworks/Python.framework/Versions/3.9/lib/python3.9/ssl.py", line 1099, in read
return self._sslobj.read(len, buffer)
ConnectionResetError: [Errno 54] Connection reset by peer

granularity cannot be changed from 3600 (coinbasepro)

Hi Michael!

I would like to run some simulations using the coinbasepro API and different temporal granularity, but it appears to be always 3600 even if I specify it differently. For instance, below is the (first part of the) output when I ask for 1 day granularity.

I don't know if it helps, but note also the warning in the first lines.

thanks a lot for your help and for this fantastic bot!

 python3 pycryptobot.py --market BTC-GBP --granularity 86400 --sim fast --verbose 0

/Users/---------/opt/anaconda3/envs/py39/lib/python3.9/site-packages/statsmodels/tools/_testing.py:19: FutureWarning: pandas.util.testing is deprecated. Use the functions in the public API at pandas.testing instead.
  import pandas.util.testing as tm
--------------------------------------------------------------------------------
|                             Python Crypto Bot                                |
--------------------------------------------------------------------------------
|          Bot Mode : TEST - test trades using dummy funds :)                  |
|       Bot Started : 2021-04-08 09:41:50.054804                               |
================================================================================
|      Sell At Loss : 0                                                        |
================================================================================
* Candlestick Detected: Inverted Hammer ("Weak - Continuation - Bullish Pattern - Up") 

2021-03-26 20:00:00 | BTC-GBP | 3600 | Close: 39216.07 | EMA12/26: 39216.07 = 39216.07 | MACD: 0.0 = 0.0 | OBV: 51.6704 (0.0%) | ERI: | WAIT 
2021-03-26 21:00:00 | BTC-GBP | 3600 | Close: 39662.42 | *^ EMA12/26: 39284.73 > 39249.13 ^* | *^ MACD: 35.6 > 7.12 ^* | ^ OBV: 80.6316 (56.05%) ^ | ERI: buy | WAIT 
2021-03-26 22:00:00 | BTC-GBP | 3600 | Close: 39525.07 | ^ EMA12/26: 39321.71 > 39269.57 ^ | ^ MACD: 52.14 > 16.12 ^ | v OBV: 44.8543 (-44.37%) v | ERI: buy | WAIT 
2021-03-26 23:00:00 | BTC-GBP | 3600 | Close: 39958.29 | ^ EMA12/26: 39419.64 > 39320.58 ^ | ^ MACD: 99.05 > 32.71 ^ | ^ OBV: 86.557 (92.97%) ^ | ERI: buy | WAIT 
* Candlestick Detected: Inverted Hammer ("Weak - Continuation - Bullish Pattern - Up") 

%% SNIP %%

2021-04-08 06:00:00 | BTC-GBP (BEAR) | 3600 | Close: 41552.12 | v EMA12/26: 41266.36 < 41346.47 v | ^ MACD: -80.12 > -167.09 ^ | v OBV: -63.0605 (-15.9%) v | ERI: buy | WAIT | Last Action: BUY | -3.83%
! Ignore Sell Signal (No Sell At Loss) 

2021-04-08 07:00:00 | BTC-GBP (BEAR) | 3600 | Close: 41520.1 | v EMA12/26: 41305.39 < 41359.33 v | ^ MACD: -53.94 > -144.46 ^ | ^ OBV: -73.1307 (15.97%) ^ | ERI: sell | WAIT | Last Action: BUY | -3.91%

Simulation Summary

   Buy Count : 2
  Sell Count : 2 

      Margin : -0.8% 

  ** non-live simulation, assuming highest fees 

(py39)

Graphs not working correctly

When I run the following command:
python pycryptobot.py --market BTCUSDT --granularity 1h --sim slow --verbose 0 --live 0 --graphs 1

The following is displayed once the simulation ends:

Simulation Summary

Buy Count : 1
Sell Count : 1

Margin : 0.03%

** non-live simulation, assuming highest fees

The graphs folder contain 2 png files. Both are same chart and does not indicate any trade. I have tested on different time frames, markets, and simulation speeds. For example, if there are 4 orders in the simulation, there will be 4 png files, but all are same chart with no trade displayed.

Consider adding telegram Notification ?

Hi,

Woud you consider adding a telegram notification when a buy or sell occurs ?

I'll quickly try and edit your code with these easy steps:

import telegram_send
...

if a buy signal

        if action == 'BUY':
            telegram_send.send(messages=["BUY SIGNAL Market xxxxxxxx"])

...
# if a sell signal
elif action == 'SELL':
telegram_send.send(messages=["SEL SIGNAL Market xxxxx"])

Of course it requires setting your own bot before :
https://medium.com/@robertbracco1/how-to-write-a-telegram-bot-to-send-messages-with-python-bcdf45d0a580

Let me know whatyou think,
thanks

empty Docker logs

Logs are not available when using docker logs (docker logs -f btc-eur).

To fix it include the environment var "PYTHONUNBUFFERED"

        image: ghcr.io/whittlem/pycryptobot/pycryptobot:latest
        container_name: btc-eur
        environment:
            - PYTHONUNBUFFERED=1

default granularity is 3600 minutes

Hey there, and thanks for making this awesome program available to everyone. I noticed that the default granularity is 3600 minutes, but shouldn't it be 60 minutes?

Thanks

How to define size of the trade?

Suppose I have 1000 USDT, I want to trade only 30% of this balance. How to define that?

Binance: An existing connection was forcibly closed by the remote host

Hi, I think I need some help here...

I keep getting this error whenever I try to go live (it happens after around 7 min I start the bot):

2021-04-27 15:35:00 | XRPUSDT (BEAR) | 5m | Close: 1.4 | ^ EMA12/26: 1.39 > 1.39 ^ | ^ MACD: 0.0 > -0.01 ^ | ^ OBV: 59019460.33 (3.66%) ^ | ERI: sell | WAIT | Last Action: BUY | 0% (delta: 1.41) 2021-04-27 15:40:00 | XRPUSDT (BEAR) | 5m | Close: 1.42 | ^ EMA12/26: 1.4 > 1.39 ^ | ^ MACD: 0.0 > -0.01 ^ | ^ OBV: 61230004.87 (7.12%) ^ | ERI: buy | WAIT | Last Action: BUY | 0% (delta: 1.42) Traceback (most recent call last): File "C:\Programs\Python\3.9\env\lib\site-packages\urllib3\connectionpool.py", line 699, in urlopen httplib_response = self._make_request( File "C:\Programs\Python\3.9\env\lib\site-packages\urllib3\connectionpool.py", line 445, in _make_request six.raise_from(e, None) File "<string>", line 3, in raise_from File "C:\Programs\Python\3.9\env\lib\site-packages\urllib3\connectionpool.py", line 440, in _make_request httplib_response = conn.getresponse() File "C:\Users\al\AppData\Local\Programs\Python\Python39\lib\http\client.py", line 1345, in getresponse response.begin() File "C:\Users\al\AppData\Local\Programs\Python\Python39\lib\http\client.py", line 307, in begin version, status, reason = self._read_status() File "C:\Users\al\AppData\Local\Programs\Python\Python39\lib\http\client.py", line 268, in _read_status line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1") File "C:\Users\al\AppData\Local\Programs\Python\Python39\lib\socket.py", line 704, in readinto return self._sock.recv_into(b) File "C:\Users\al\AppData\Local\Programs\Python\Python39\lib\ssl.py", line 1241, in recv_into return self.read(nbytes, buffer) File "C:\Users\al\AppData\Local\Programs\Python\Python39\lib\ssl.py", line 1099, in read return self._sslobj.read(len, buffer) ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host

Here is my config file:

{ "binance" : { "api_url" : "https://api.binance.com", "api_key" : "", "api_secret" : "", "config" : { "base_currency" : "XRP", "quote_currency" : "BRL", "granularity" : "15m", "live" : 1, "verbose" : 0 } }, "telegram" : { "token" : "", "client_id" : "" } }

I changed the quote_currenct to USDT but still got the same error.

How can I solve this issue

During handling of the above exception, another exception occurred:

urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionResetError(10054, 'Varolan bir bağlantı uzaktaki bir ana bilgisayar tarafından zorla kapatıldı', None, 10054, None))

During handling of the above exception, another exception occurred:

requests.exceptions.ConnectionError: ('Connection aborted.', ConnectionResetError(10054, 'Varolan bir bağlantı uzaktaki bir ana bilgisayar tarafından zorla kapatıldı', None, 10054, None))

error when buying on binance

Hello

i got an error message when attempting to buy Algo on binance this morning :

2021-04-25 08:00:00 | ALGOUSDT 1h | Close: 1.15 | BUY

ALGO balance before order: 0.0
USDT balance before order: 199.98
Order quantity after rounding and fees: 172.84
25-04-2021 10:47:14 Binance marketBuy APIError(code=-2010): Account has insufficient balance for requested action.
ALGO balance after order: 0.0
USDT balance after order: 199.98

as you can see, i had ~200 usdt in my acount
thanks

binance granularity

granularity option default for binance config is "1h"
will any other variables work such as 30m, 2h or 900?

With default "1h" it is displayed in app run as "Granularity : 1h seconds" which is a little confusing, but assuming its on the hour.

Not buying in binance

I tried simulator multiple times and whatever crypto-quotation combination I use, the bot only wait and wait.
It does not do buy.
It sold some of the coins but never buy back and I see many trends that are missed because of the wait time.
I tried live funds as well and my fund sits in USDT be it BTC/USDT, DOGE/USDT, or ETH/USDT for 3 days without any buy.
Could it be an issue?

dockerised binance stopping for some reason

When using coinbase config, pycryptobot.log is updating accordingly - i mapped the file on dockerhost and tailed it and it refreshes every 15 min.
In the case of binance config, the log stops updating after the initial 2 lines,

The bot is updating the log correctly if run from host - but when run from container, it stops - only if it is binance.

between 7:00 and 8:19 there is nothing. at 8:19 it updated the log because I restarted the container.

Buy and Sell Count is Zero when testing binance?

I'm testing the bot and I'm seeing no buy or sell activity. in simulation mode for binance
Configuration:
{
"binance" : {
"api_url" : "https://api.binance.com",
"api_key" : "",
"api_secret" : "",
"config" : {
"base_currency" : "ETH",
"quote_currency" : "USDT",
"granularity" : "1h",
"live" : 0,
"verbose" : 0
}
}
}
what should I do?
thank you

Retry on exceptions?

Hey, I'm not sure whether this is a problem with my internet, but I'm often getting API exception, and it stops the bot, so maybe it'd be nice to have a retry on those cases so the bot doesn't "die". What do you think?

How to start bot in windows.

json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Hi
I'm getting this error "json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)"
in ETH-EUR / XLM-EUR and ADA-EUR

any idea ?

Thanks

BINANCE - SMART SWITCH?

great work and communication, thanks for that.
forgot to ask - is binance supporting a smart switching?

doesnt seem to be indicated in the documentation whether yes or no, just absent from config...

thanks

json.decoder.JSONDecodeError: Expecting ',' delimiter: line 1 column 49 (char 48)

I swapped XLM-EUR for ADA-EUR yesterday. I've had this crash twice.

2021-04-16 11:46:53 | ADA-EUR (BULL) | 3600 | Current Price: 1.171
json.decoder.JSONDecodeError: Expecting ',' delimiter: line 1 column 49 (char 48)
ADA-EUR %

Anyone else getting it as well? Or is it ADA specific?

sellupperpcnt not working correctly

I run the bot with the following command:

python pycryptobot.py --exchange binance --market ENJUSDT --granularity 1h --sim fast --verbose 0 --live 0 --smartswitch 1 --sellatloss 0 --sellupperpcnt 9

The sellupperpcnt is supposed to force sell when the margin reaches an upper limit of 9%, but based on the log, the sell happens when profit is less than 9%. (multiple examples attached)

error: POST (400) https://api.pro.coinbase.com/orders - funds is too accurate.

Hi,

I keep getting this error message when trading ETH-DAI :

2021-04-10 16:00:00 | ETH-DAI 900 | Close: 2164.0 | BUY

ETH balance before order: 0.0001
DAI balance before order: 150.4926
error: POST (400) https://api.pro.coinbase.com/orders - funds is too accurate. Smallest unit is 0.01000000
ETH balance after order: 0.0001
DAI balance after order: 150.4926

In fact, i think the issue is that i can't trade 150.4926 but only 150.49.

When i do the trade manually on coinbasepro, that's the amount showing when "MAX" is selected.

I don't know if the problem is present with other currency, i will tryc with usdc

whittlem / pycryptobot Goto Github PK

pycryptobot's People

Contributors

Stargazers

Watchers

Forkers

pycryptobot's Issues

| Python Crypto Bot |

| Market : BTCDOGE | | Granularity : 1h |

| Bot Mode : TEST - test trades using dummy funds :) | | Bot Started : 2021-04-20 15:42:03.872121 |

| Python Crypto Bot |

| Market : ADAEUR | | Granularity : 1h |

| Bot Mode : LIVE - live trades using your funds! | | Bot Started : 2021-04-16 21:32:57.015384 |

================================================================================ | Iteration : 1 (BULL) | | Timestamp : 2021-04-16 20:00:00 |

| Close : 1.19 | | EMA12 : 1.18 | | EMA26 : 1.19 | | Crossing Above : False | | Currently Above : False | | Crossing Below : False | | Currently Below : True | | Condition : EMA12 is currently below EMA26 and has crossed over | | SMA20 : 1.18 | | SMA200 : 1.11 |

| MACD : -0.01 | | Signal : -0.01 | | Currently Above : True | | Currently Below : False | | Condition : MACD is currently above Signal and has crossed over |

| Action : WAIT |

if a buy signal

Recommend Projects

Recommend Topics

Recommend Org

| Market : BTCDOGE |
| Granularity : 1h |

| Bot Mode : TEST - test trades using dummy funds :) |
| Bot Started : 2021-04-20 15:42:03.872121 |

| Market : ADAEUR |
| Granularity : 1h |

| Bot Mode : LIVE - live trades using your funds! |
| Bot Started : 2021-04-16 21:32:57.015384 |

================================================================================
| Iteration : 1 (BULL) |
| Timestamp : 2021-04-16 20:00:00 |

| Close : 1.19 |
| EMA12 : 1.18 |
| EMA26 : 1.19 |
| Crossing Above : False |
| Currently Above : False |
| Crossing Below : False |
| Currently Below : True |
| Condition : EMA12 is currently below EMA26 and has crossed over |
| SMA20 : 1.18 |
| SMA200 : 1.11 |

| MACD : -0.01 |
| Signal : -0.01 |
| Currently Above : True |
| Currently Below : False |
| Condition : MACD is currently above Signal and has crossed over |