webpack / voting-app

An application for casting votes on new webpack features and fixes.

Voting Application

This repository contains all the source for the voting application found at webpack.js.org/vote.

Development

All development of this application should happen here. Upon release, this package is deployed as an npm package and then picked up by the other repository.

• npm start to start the webpack-dev-server
• npm run build to generate the /dist directory

voting-app's Issues

Release Process

I think we need to figure out a good release process for this repo (not sure what the standard is for other webpack-contrib repos). First things first, we should probably create:

• A prepublish npm script that runs the build so we don't forget to before publishing
• Maybe a postpublish npm script that removes the /dist directory?

I did add a release script using standard-version however I'm not really sure how to properly push the tagged commits up to the remote. I don't have permissions to directly push to master and only "Rebase & Merge" / "Squash & Merge" are allowed for PRs which both leave the tag orphaned. Oddly enough, I am able to push tags directly to master so what I've been doing is a "Rebase & Merge", then delete the orphaned tag and create the same one on the new master commit.

Any advice much appreciated. Seeing as I'm not going to be the lead maintainer on this repo, maybe it just makes sense to give master privileges to whoever that's going to be and then they can run the release script and push the commit directly to master.

cc @TheLarkInn @d3viant0ne

Your browser is not supported.

I get this message when I click "Login with GitHub".

I'm using Firefox 65.0.1 (64-bit).

Initial Setup

It works (npm start)!

What still needs to be done:

• webpack.dist.js is not fully fleshed out yet... we'll need to tweak things a bit in order to easily consume from the main repo.
• review and tweak the rest of the configuration, I started it out with what I think is a good boilerplate for a react project but we can tweak it however.
• refactoring, especially in the Wrapper.jsx which essentially contains the whole hierarchy. This has a huge render method which contains a lot of room for improvement (e.g. breaking a lot out into separate components, refactoring and removing inline callback functions, etc.)

Some nice potential additions that may be helpful going forward:

• maybe react-hot-loader for a nicer development workflow
• use automatic changelog generation and releasing as outlined in this pr
• use postcss/cssnext and no sass? CSSNext contains many of the features sass does and has the benefit of actually forcing us to be compliant with what will be supported soon. Plus we're already using postcss for the auto-prefixing so this would allow for just a simpler configuration in general.

I'll create a separate issue for the redesign but I think we should do a little more cleanup first. @NejcZdovc @pksjce or anyone else interested in helping to refactor, please just let me know what you want to tackle and I'll leave that section alone.

Redesign

Moving this conversation from webpack/webpack.js.org#409...

@pksjce the CTA for vote buttons, especially on mobile, are definitely still an issue. If someone has a good idea to rectify this, I'd be happy to incorporate it into the design.

Note: At some point I'll likely be migrating these comps to sketch, but if there are any quick fixes I can make them in the current version. I'll push the current updates to the webpack-design repo as well at some point today.

Here are all the comps for reference:

Logged Out

Logged in as a Normal User

Logged in as an Admin

Admin Settings Menu

Mobile

Auth via GitHub failed

Request URL: https://oswils44oj.execute-api.us-east-1.amazonaws.com/production//login
Status Code: 500 Internal Server Error
Response:

{
    "errorMessage": "[500] Github API user data request failed: {\"message\":\"Must specify access token via Authorization header. https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param\",\"documentation_url\":\"https://docs.github.com/v3/#oauth2-token-sent-in-a-header\"}",
    "errorType": "Error",
    "stackTrace": [
        "/var/task/handlers/login.js:43:28",
        "config.sendError (/var/task/node_modules/github/lib/index.js:798:13)",
        "/var/task/node_modules/github/lib/index.js:805:29",
        "callCallback (/var/task/node_modules/github/lib/index.js:680:17)",
        "IncomingMessage.<anonymous> (/var/task/node_modules/github/lib/index.js:736:25)",
        "emitNone (events.js:72:20)",
        "IncomingMessage.emit (events.js:166:7)",
        "endReadableNT (_stream_readable.js:905:12)",
        "nextTickCallbackWith2Args (node.js:437:9)",
        "process._tickDomainCallback (node.js:392:17)"
    ]
}

Github Login Broken

After #3 I was testing things out quickly to see if it worked.

It looks incredible but noticed there was a error trying to login on github.

Here is an example of the error in question:

I can try and tackle this myself also (cc @skipjack unless you know what this is off the bat)

number in vote app to big for styling

From @sokra on February 20, 2017 7:32

Copied from original issue: webpack/webpack.js.org#918

Please remove [IN PROGRESS] from "CSS as first-class citizen"

It doesn't seem to be in progress anymore, and I'd like to be able to vote on it.

It would also be nice to have "HTML as first-class citizen" and "Files/assets/URLs as first-class citizen".