Comments (5)
The plus sign in the 'calc section' looks misplaced somehow and an underline between the summands and the total would be nice :)
Golden Influence ( + / - )
Influence ( +/ - )
--------------------
Total
from voting-app.
@michael-ciniawsky are you just talking about the mobile comp?
The plus sign in the 'calc section' looks misplaced somehow...
Yea in the mobile comp I see what you mean.. maybe bring it in closer to the count?
... and an underline between the summands and the total would be nice :)
In the normal comp there already is an underline/divider but when I tried to incorporate it into the mobile version it felt a little odd. Any chance you'd be interested in making tweaks and submitting them as a PR over at the design repo? (or just sharing them here) I just pushed all my latest changes up.
from voting-app.
@skipjack Yep mobile 😛 but the plus in general
Any chance you'd be interested in making tweaks and submitting them as a PR over at the design repo?
Sry I don't use Photoshop/Sketch myself, when I design I'm programming it since I'm no real designer :D
from voting-app.
Haha, no worries... I may make the updates myself to the comps but either way whoever starts PR-ing the actual redesign can take the the things mentioned here into account. I'll be submitting a refactoring PR here within the next 24 but after that I'll likely be shifting back to webpack.js.org issues/tasks.
from voting-app.
Ok I may try to tackle this redesign soon if I can find the time. Would be great if we could find someone to maintain this repo longterm though.
from voting-app.
Related Issues (8)
- number in vote app to big for styling HOT 4
- Release Process HOT 3
- Please remove [IN PROGRESS] from "CSS as first-class citizen" HOT 15
- Your browser is not supported. HOT 12
- Initial Setup HOT 2
- Auth via GitHub failed HOT 11
- Github Login Broken HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from voting-app.