Failed to build on MSYS2 MINGW64 about c-ray

[vkoskiv]

Hey, thanks for reporting. Currently, the network protocol is not supported on Windows, as it assumes a Berkeley sockets style API.
I'm guarding the network code with a simple #ifndef WINDOWS. Reworking these guards is needed to get it building on MINGW environments.
I don't have a MINGW environment available, but the included instructions in the README on how to build natively on Windows should still work.

Hey, thanks for reporting. Currently, the network protocol is not supported on Windows, as it assumes a Berkeley sockets style API. I'm guarding the network code with a simple #ifndef WINDOWS. Reworking these guards is needed to get it building on MINGW environments. I don't have a MINGW environment available, but the included instructions in the README on how to build natively on Windows should still work.

Shouldn't it be #ifndef _WIN32? Your usage of #ifndef WINDOWS is wrong. This is the reason why <arpa/inet.h> is still included.

Oh I see, -DWINDOWS is added by you on your CMakeLists.txt. @vkoskiv What about replacing #ifndef WINDOWS in code with #ifndef _WIN32 so you will not need to define -DWINDOWS on CMakeLists.txt? Btw, please have a look at your CMakeLists.txt and add support for MinGW compiler. You could use if (MinGW) to check for MinGW on CMake. Currently you only check for MSVC so -DWINDOWS is not defined when building with MSYS2.

[vkoskiv]

Btw, please have a look at your CMakeLists.txt and add support for MinGW compiler.

I personally don't have a need for MinGW support, nor a test environment to implement that support, but I'd be happy to merge in those changes if someone else works on it.