treeselection about logginglab

[sylvainschmitt]

A note to myself and for you to have an idea, I'm doing my checks in this order:

• check the doc ?fun
• check the example in the doc by running it
• check the code reading it
• check the test by running it manually in the file

[VincyaneBadouard]

Thank you again for your work!

[sylvainschmitt]

Code

The harvestable volume (=20.924047945303)is always higher (by 0.924047945302966) than your objective volume despite the increase in Minimum Falling Diameter (MinFD) (Initial harvestable volume = 29.4223071858134). In order to reach your objective volume, the trees were selected in decreasing order of volume until the objective volume was reached.

• you are missing spaces and use round to not have as many decimals
• harvestable, selected, and futurereserve are in the code but not in my review list? Try to list clearly all the functions I shoudlcheck in every issue.
• Why are you using sp::coordinates to define coordinates and then sf::st_as_sf instead of using directly sf::st_as_sf(coords = c("X", "Y"))

Test

• inventory as 3,5k lines, could you reduced to maybe one subplot or less to decrease testing time (4.4s is a lot and maybe unnecessary to prove that functions are working properly)

[sylvainschmitt]

@VincyaneBadouard , what about :

Why are you using sp::coordinates to define coordinates and then sf::st_as_sf instead of using directly sf::st_as_sf(coords = c("X", "Y"))

[sylvainschmitt]

@VincyaneBadouard , the last comment is okay for me, it's just a detail and won't make you lose a lot of computation time, so I'll consider the code checked.