Comments (3)
Review of the code
@VincyaneBadouard , here is my review of the code. Beware, you can totally disagree with me and it's fine! Also tell me if you like the revision this way or if you would prefer a pull request?
Help
- l. 1 Other parameters is not very specific, something more descriptive would be better, advanced parameters?
- 80 character lines (CTRL+MAJ+/)
- l. 31 meanΟ > mean Ο
- l. 41 consider adding a new line between the example in roxygen and the name of the function
Code
- try avoiding comments in french
- l. 126 use Allometry instead of Models
Test
I don't see the test file?
from logginglab.
I'm unchecking the review of the code as you also lack a test of user inputs (see #23 )
from logginglab.
Ok for me now! Kudos for the input checks.
from logginglab.
Related Issues (20)
- scenariosparameters HOT 2
- How do you create a hyperlink in a help page? HOT 1
- Genericity
- harvestable
- selected HOT 1
- futurereserve HOT 1
- ONFGuyafortaxojoin HOT 1
- directionalfellingsuccessdef in treefelling.R HOT 2
- rotatepolygon in treefelling.R HOT 1
- getgeometry HOT 2
- treefromthesky in createcanopy.R HOT 1
- createcanopy HOT 1
- check function directionalfellingsuccessdef
- cleaninventory
- loggingsummary
- `parallel` version
- Increase user-friendliness
- Issue in `maintrailextract()` HOT 6
- getmask() returns a SpatialPolygons, not a SpatialPolygonsDataFrame
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from logginglab.