Coder Social home page Coder Social logo

loggingparameters about logginglab HOT 3 OPEN

vincyanebadouard avatar vincyanebadouard commented on May 25, 2024
loggingparameters

from logginglab.

Comments (3)

sylvainschmitt avatar sylvainschmitt commented on May 25, 2024

Review of the code

@VincyaneBadouard , here is my review of the code. Beware, you can totally disagree with me and it's fine! Also tell me if you like the revision this way or if you would prefer a pull request?

Help

  • l. 1 Other parameters is not very specific, something more descriptive would be better, advanced parameters?
  • 80 character lines (CTRL+MAJ+/)
  • l. 31 meanΟƒ > mean Οƒ
  • l. 41 consider adding a new line between the example in roxygen and the name of the function

Code

  • try avoiding comments in french
  • l. 126 use Allometry instead of Models

Test

I don't see the test file?

from logginglab.

sylvainschmitt avatar sylvainschmitt commented on May 25, 2024

I'm unchecking the review of the code as you also lack a test of user inputs (see #23 )

from logginglab.

sylvainschmitt avatar sylvainschmitt commented on May 25, 2024

Ok for me now! Kudos for the input checks.

from logginglab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.