Comments (1)
sylvainschmitt
commented on June 4, 2024
- it's okay thanks to NAMESPACES, but take care as
selectedis a common name -
Upcolumn is not very explicit - test is above 1s (9.1s), adding
sample_n(500)toinventoryand decreasing theVOto 10 reduced the timing to 8s for instance, there are still more to do but it might gave you an idea
selected is good to me. Any of my comments is really important. I would understand you don't improve tests for the moment because it doesn't change how the package is working. It is more a suggestion for long term development as keeping short tests make your life easier. Consequently, I'm considering the code as checked.
from logginglab.
Related Issues (20)
- scenariosparameters HOT 2
- loggingparameters HOT 3
- How do you create a hyperlink in a help page? HOT 1
- Genericity
- harvestable
- futurereserve HOT 1
- ONFGuyafortaxojoin HOT 1
- directionalfellingsuccessdef in treefelling.R HOT 2
- rotatepolygon in treefelling.R HOT 1
- getgeometry HOT 2
- treefromthesky in createcanopy.R HOT 1
- createcanopy HOT 1
- check function directionalfellingsuccessdef
- cleaninventory
- loggingsummary
- `parallel` version
- Increase user-friendliness
- Issue in `maintrailextract()` HOT 6
- getmask() returns a SpatialPolygons, not a SpatialPolygonsDataFrame
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from logginglab.